Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp1884726ybg; Thu, 30 Jul 2020 05:23:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxpnmP5jnys5qno6ALkyd1rpY/T9BRyE+mMO0dtRaG6n9AcqVRvxCWugG/cPcirTIHPBEp3 X-Received: by 2002:a17:906:5612:: with SMTP id f18mr2415129ejq.225.1596111782352; Thu, 30 Jul 2020 05:23:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596111782; cv=none; d=google.com; s=arc-20160816; b=R2vO02jUFLt+Yd83ZKGQ2d+BlSlYRnUXI76YvkfXI7d73sNF1hcI83vLoJEtK/0UgE E5j+5Wvug09i+htLjxkbZaoo7xRgbppFsAwUGQSIjx1K8tCkUGTMHlc9fCoITnab2Q2U 4/TlYzWitkIzB9AFIhcCey5AwcdZhY/jGXLC90GLca7kp9WX/tnv7118zQGeW8aZLFNP Mruw5zu/pwfpJTeV5Jmwo7a7oYBybkJvSI2JsjiE8tvc895SKvbqo+RXJi8sP4xHKIRr uPsVagfrqKk/7rIXs6UE15L98A258TRlfZexIztIqFs0qNoz7aYoiJJdtNJ7b0w+aDBx /i1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Of/CcRIRHiXzI+FDIiD8ZQ5hjM3WlzztOGpVy/jJ1zU=; b=McwLGsVgA1jOZZTFTwSc6iB+WA5X2ZheptLb/+26RuOrr1DR7o0ebzy7s5W9c65nbw NEsy+nYX3okK92asS2eQmDOG3nOf5IY0XxyfiBY5YutZS46hgCRw/9SLckR7PLY/YH+q I4q+ezajr0xzN20YmqO7eQFlJf13VQ1L7BCmgqIcU709XPeH9hiIaYTlSnkx2ZdXpNXb 8t5UuGNKuH7lpqvvTehLXXJCopFxj/BGY7eP4u68PGpiWpmMF8jeq0td4pzehxAlcamI U4ohWvEJO1gkuQFJIkUKwFH3zOQQ5lLqeNFnrZ51YkP+q7NzODpPR0NJJ5U5gwbz2c6I +wrQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e7si2167650ejm.580.2020.07.30.05.22.39; Thu, 30 Jul 2020 05:23:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726846AbgG3MWG (ORCPT + 99 others); Thu, 30 Jul 2020 08:22:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:60456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726631AbgG3MWG (ORCPT ); Thu, 30 Jul 2020 08:22:06 -0400 Received: from gaia (unknown [95.146.230.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 61F592082E; Thu, 30 Jul 2020 12:22:04 +0000 (UTC) Date: Thu, 30 Jul 2020 13:22:01 +0100 From: Catalin Marinas To: Sami Tolvanen Cc: Will Deacon , Ard Biesheuvel , Nick Desaulniers , Kees Cook , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, stable@vger.kernel.org Subject: Re: [PATCH] arm64/alternatives: move length validation inside the subsection Message-ID: <20200730122201.GM25149@gaia> References: <20200729215152.662225-1-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200729215152.662225-1-samitolvanen@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 29, 2020 at 02:51:52PM -0700, Sami Tolvanen wrote: > Commit f7b93d42945c ("arm64/alternatives: use subsections for replacement > sequences") breaks LLVM's integrated assembler, because due to its > one-pass design, it cannot compute instruction sequence lengths before the > layout for the subsection has been finalized. This change fixes the build > by moving the .org directives inside the subsection, so they are processed > after the subsection layout is known. > > Link: https://github.com/ClangBuiltLinux/linux/issues/1078 > Cc: # 4.14+ Commit f7b93d42945c went in 5.8-rc4. Why is this cc stable from 4.14? If Will picks it up for 5.8, it doesn't even need a cc stable. Please add a Fixes: tag as well. -- Catalin