Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750925AbWELVn6 (ORCPT ); Fri, 12 May 2006 17:43:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932245AbWELVn6 (ORCPT ); Fri, 12 May 2006 17:43:58 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:28070 "EHLO ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S1750900AbWELVn5 (ORCPT ); Fri, 12 May 2006 17:43:57 -0400 Date: Fri, 12 May 2006 22:43:54 +0100 From: Al Viro To: Linus Torvalds , Erik Mouw , Or Gerlitz , linux-scsi@vger.kernel.org, axboe@suse.de, Linux Kernel Mailing List Subject: Re: [BUG 2.6.17-git] kmem_cache_create: duplicate cache scsi_cmd_cache Message-ID: <20060512214354.GP27946@ftp.linux.org.uk> References: <20060511151456.GD3755@harddisk-recovery.com> <15ddcffd0605112153q57f139a1k7068e204a3eeaf1f@mail.gmail.com> <20060512171632.GA29077@harddisk-recovery.com> <20060512203416.GA17120@flint.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060512203416.GA17120@flint.arm.linux.org.uk> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 881 Lines: 18 On Fri, May 12, 2006 at 09:34:16PM +0100, Russell King wrote: > On Fri, May 12, 2006 at 10:36:57AM -0700, Linus Torvalds wrote: > > Yes. We could just revert that commit, but it seems correct, and I'd > > really like for somebody to understand _why_ that commit matters at all. I > > certainly don't see the overlap here.. > > Reverting the commit breaks MMC/SD in a very real way, and the fix > is plainly correct and is actually the only possible fix that can be > applied. Bullshit. Could you explain what generic code dereferences ->driverfs_dev after del_gendisk()? If you see such beast, please tell; _that_ is the real bug. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/