Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 30 Jul 2020 21:00:05 +0800
From:   Yue Hu <zbestahu@gmail.com>
To:     Catalin Marinas <catalin.marinas@arm.com>
Cc:     will@kernel.org, akpm@linux-foundation.org, mark.rutland@arm.com,
        james.morse@arm.com, peterx@redhat.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        huyue2@yulong.com, zbestahu@163.com
Subject: Re: [PATCH] arm64: mm: add message to die() in die_kernel_fault()
Message-ID: <20200730210005.000069a0.zbestahu@gmail.com>
In-Reply-To: <20200730122723.GN25149@gaia>
References: <20200730114757.13592-1-zbestahu@gmail.com>
        <20200730122723.GN25149@gaia>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 30 Jul 2020 13:27:23 +0100
Catalin Marinas <catalin.marinas@arm.com> wrote:

> On Thu, Jul 30, 2020 at 07:47:57PM +0800, Yue Hu wrote:
> > From: Yue Hu <huyue2@yulong.com>
> > 
> > Just to identify the kernel fault more clearly.
> > 
> > Signed-off-by: Yue Hu <huyue2@yulong.com>
> > ---
> >  arch/arm64/mm/fault.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> > index 8afb238..3a753c7 100644
> > --- a/arch/arm64/mm/fault.c
> > +++ b/arch/arm64/mm/fault.c
> > @@ -289,7 +289,7 @@ static void die_kernel_fault(const char *msg, unsigned long addr,
> >  	mem_abort_decode(esr);
> >  
> >  	show_pte(addr);
> > -	die("Oops", regs, esr);
> > +	die("Oops - Page fault", regs, esr);
> >  	bust_spinlocks(0);
> >  	do_exit(SIGKILL);
> >  }  
> 
> Don't we already print enough information prior to die()?
> 

Yes, we have. But "Oops" is a little common. Add specific message is just to avoid to
use it repeatedly by other callers just like die("Oops - BUG",,), die("Oops - KASAN",,).

Moreover, die() will call panic() if require, panic() does not know which oops it is.
We can let panic() know it for debug expansibility such as store the panic message to
reserved memory.