Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp1966858ybg; Thu, 30 Jul 2020 07:16:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwLWa3VgYDMYhvOn9wijlPz+KJeZ2cEfP7/Lh500kObpzX9xb85KMeFPDoJLOegQ0SdCu4F X-Received: by 2002:a17:906:1f08:: with SMTP id w8mr2905462ejj.535.1596118603149; Thu, 30 Jul 2020 07:16:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596118603; cv=none; d=google.com; s=arc-20160816; b=J3VCnKUpqi9vC8Yjoh/UriCgZzZJSEqjynlkaLF5HNcsGUE0cCHkmOdqn0JQ5jJKne yL6uqWhqROfILR3AbpfZTaFntUm5vGYV1OV+zPnpb9gBf0HTVpl3BKeFzx3qIWM/qvUv W+FFysyxUIarnHW6ZT8g4FMAPzJn+6N3YyltZq38vs9RTRrVR/VwD+XnuNYYdpbuNHf6 zreoF+z0sFvNGdej1LHhN+2b84VmPXQb4ajN11sgeZG8g5JTSeMptiO8V2yebWT/vc19 d+5gYDik8SZ9rHaRZjbKC+LczDQ9sKAmjy+flDPZWU/sHXl1fqVU53PaIwjkEMQffi8h i95g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=1GfYkK7/x88dPSta57qjc35WTcVURqTk5ykRw4B7tRs=; b=asKmnIm2fRRfg161K2cgS7PP9CZbj3uQs+V3HbQ/fAXNy6QAaezbNQ0z5gJciGUzXP QevZUpwOMukxc6tn9noEkOHcQguaIErr5ieGQOB8wkkP66kGTEvMu4uKff5zPdiciPZI 4GExb+mm6zY2oHWTOXhVOrQn5eRrkNq0NKI/RHB2N3LLPGRX1AWyxY47GAABI9vBeoh8 wlTBP1Cie155ZmeaRL/G8bgmqvT/KAjAW1iP5B0JXvTXB4irVs+ooMgXXbeRP12DDH6+ nVkLGvE9oh7SXksEint48yozZigsrrEAgiR5sMcc9of4cXDd0Fpmn1qzq8AJCgkg7c3c e/Kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=aqLfRSJI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g10si3325437ejf.312.2020.07.30.07.16.20; Thu, 30 Jul 2020 07:16:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=aqLfRSJI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729459AbgG3OOH (ORCPT + 99 others); Thu, 30 Jul 2020 10:14:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729252AbgG3OOH (ORCPT ); Thu, 30 Jul 2020 10:14:07 -0400 Received: from mail-qv1-xf41.google.com (mail-qv1-xf41.google.com [IPv6:2607:f8b0:4864:20::f41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50D3EC061574; Thu, 30 Jul 2020 07:14:07 -0700 (PDT) Received: by mail-qv1-xf41.google.com with SMTP id l13so6192880qvt.10; Thu, 30 Jul 2020 07:14:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1GfYkK7/x88dPSta57qjc35WTcVURqTk5ykRw4B7tRs=; b=aqLfRSJIgUYu9JS6xR32xAwjDb6+rBkvWTHYyoxS9ZpZ4SUlL+SYdcII49Ip9Yf7CA pllE5GHAS2zM91bOva74Ab+ZDJB8OfysW7TfskidPcAAxo5kccxxhhPyY9PV5UUxLNn1 9NKNfg3tD3sKoIseu4rgSnxW+cjrrNGrW7QJUkU/zovJ2fgxO1ehXqFOYbzD3tlzurB1 l6JbmmOC7IP8EyR/6wYIzcoD+w59RDR6kX2RhGfZSmf+uTA+FWBuCvBFVwX2NnUj8Rcm s8BWWezcZOwmTemeQeQZ8txA8rpg7Bz4VJE94DL08BC9Dl666N3K9F/SOTG+b16x4nP+ IQTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=1GfYkK7/x88dPSta57qjc35WTcVURqTk5ykRw4B7tRs=; b=VdumjmViXBCSRo/lW5K9yKcSh0U6YgRI1veyR8YzFQlRaiVAnlxNqy5fyLfXW1vdw1 unhryVYUFn6/Maxm1WFcOlMTCI88j8qgz5ydPnPguJsgZhoynx+1WAPfC2ReLTw2O6mn gs4ZWvmTbv/Oq46xcYch16T44HEefawWAaExweJn4s0BTzZDr/KAg8jLR+Se3Ir8YCjp ycTb83brToL0PyiOIYrbagJ1pi8VuA9ct3n2dAbEPvJVY86zQLlLqPPjJN2UpXP1f/Lm Gp4pFIyKKK0yWEV7+j9wZi67ORpRo3lOZ9EHqm52C4QPvsay2yskE9jAmploPRZSuM9I zrag== X-Gm-Message-State: AOAM5324YuNMF65BcTG7e90mBBJPBSIIU/VhOfuXhQpT3/Yt9gBiO9H8 0Y5mnUxn7mQc5MYWq6lG/xCF1t7Nw9I= X-Received: by 2002:a0c:fde4:: with SMTP id m4mr2979870qvu.97.1596118446244; Thu, 30 Jul 2020 07:14:06 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:115b]) by smtp.gmail.com with ESMTPSA id h144sm4091990qke.83.2020.07.30.07.14.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2020 07:14:05 -0700 (PDT) Date: Thu, 30 Jul 2020 10:14:04 -0400 From: Tejun Heo To: Chengming Zhou Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iocost: Fix check condition of iocg abs_vdebt Message-ID: <20200730141404.GA4601@mtj.duckdns.org> References: <20200730090321.38781-1-zhouchengming@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200730090321.38781-1-zhouchengming@bytedance.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, Jul 30, 2020 at 05:03:21PM +0800, Chengming Zhou wrote: > We shouldn't skip iocg when its abs_vdebt is not zero. > > Fixes: 0b80f9866e6b ("iocost: protect iocg->abs_vdebt with > iocg->waitq.lock") > > Signed-off-by: Chengming Zhou Acked-by: Tejun Heo Thanks. -- tejun