Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp1987800ybg; Thu, 30 Jul 2020 07:42:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygES7vTyDWDu7ziE+WB72m2r0AFbOH/VLjAcjv6tPkF015EBOqc+7Oke92QYRoJbiYoSST X-Received: by 2002:a17:906:16c8:: with SMTP id t8mr2902190ejd.484.1596120179473; Thu, 30 Jul 2020 07:42:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596120179; cv=none; d=google.com; s=arc-20160816; b=xXH9uUey+1ch3VY1fRKR2NbQ86L3BVX9r6PdLAgfZ0DBt7pO9/SXCkQO6oSI78t0QZ 6MiFadQAUzE3pvL2m2UdMkvUxYAQ6YDKWMZlIs3KgJ4JH3j1o42QfjTU4KdECVP/rS+i i+lcJPwykxoLLPIh6NN9YguTgGMhzMpkHCzzTBdhLNC3uJNPYNyQthxV2QYrRd+/Z6KK v2OdkivH4qxN8DuEDZSkzwhMDKjwAWoOMiHXqW3Wo5rycWGEbA1Rjic6wWoEA7zcyJ4i oNH9KG0OfX0wDnlvUelRljyfloqfumLbUklLSSNMqaFjtWc2mrnQrTZTFXtliGpnfXHD yzbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Dpt7NYCGMgJLqM5T3Tc/U85T7f72I44GMyjiNHvJGhg=; b=mQe/YiDEktDZa8PeP35blNrjgNeA4YJiPweIGhSbuKL4cgqh69Ow2enWL9iKSsfxCq ArC400Fxn1WC04W4dNfL0t9sGrihb1a4Rf8VIMcUE1T00gsvY5afq6d4VB6vb5AS0mye nLDtXoCoF3X2lpkMyyFwNEH0SEU8iBqL0vEkmH2PcMiv02eKEDM9UTxWiD4gTwYkidc1 pM/EgJNuKcM1ohmLcy/u6wSTILYEVHoJTddr2NWmhgGFaS7H+BnRaALzMrdnNUeLk/iH iQBrEJ3URha6CwXOcINiSFBGcxwwQslMpFypJLvq/6+3FkfN4N8aAcgxPhQ8bXc+LKgc Jopg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UtbTElu+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z5si3278980edr.493.2020.07.30.07.42.37; Thu, 30 Jul 2020 07:42:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UtbTElu+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729652AbgG3OmV (ORCPT + 99 others); Thu, 30 Jul 2020 10:42:21 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:26190 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726873AbgG3OmU (ORCPT ); Thu, 30 Jul 2020 10:42:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596120139; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Dpt7NYCGMgJLqM5T3Tc/U85T7f72I44GMyjiNHvJGhg=; b=UtbTElu+bUCEMtoEnqh8TuS17l+Rc75ZtpYjOO4yg8RLY1gBQCh+gaK/GBWk4rGlHNW6qg Cz1gQXGRfT6lxDbx1PZP1CtJLeA39k65e8A0ff+KhAY/nJSpzQD2fdyyaT7Ar+sh/njbf9 nAYbjTkrdqern8U8egS+W+nDs1xln9w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-303-4CuoGZ18NwaaQEJgytujOQ-1; Thu, 30 Jul 2020 10:42:17 -0400 X-MC-Unique: 4CuoGZ18NwaaQEJgytujOQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 23A04800FEA; Thu, 30 Jul 2020 14:42:16 +0000 (UTC) Received: from treble (ovpn-119-23.rdu2.redhat.com [10.10.119.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 239521992D; Thu, 30 Jul 2020 14:42:15 +0000 (UTC) Date: Thu, 30 Jul 2020 09:42:13 -0500 From: Josh Poimboeuf To: Julien Thierry Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mbenes@suse.cz, raphael.gault@arm.com, benh@kernel.crashing.org Subject: Re: [PATCH v2 5/9] objtool: Make relocation in alternative handling arch dependent Message-ID: <20200730144213.fcitzo4uydshjhxh@treble> References: <20200730094652.28297-1-jthierry@redhat.com> <20200730094652.28297-6-jthierry@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200730094652.28297-6-jthierry@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 30, 2020 at 10:46:48AM +0100, Julien Thierry wrote: > As pointed out by the comment in handle_group_alt(), support of > relocation for instructions in an alternative group depends on whether > arch specific kernel code handles it. > > So, let objtool arch specific code decide whether a relocation for > the alternative section should be accepted. > > Reviewed-by: Miroslav Benes > Signed-off-by: Julien Thierry > --- > tools/objtool/arch/x86/arch_special.c | 13 +++++++++++++ The "arch" in "arch_special.c" is redundant, how about special.c? -- Josh