Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 1/4] objtool: Move object file loading out of check
To:     Josh Poimboeuf <jpoimboe@redhat.com>
Cc:     linux-kernel@vger.kernel.org, peterz@infradead.org,
        mhelsley@vmware.com, mbenes@suse.cz
References: <20200730094143.27494-1-jthierry@redhat.com>
 <20200730094143.27494-2-jthierry@redhat.com>
 <20200730140936.uvw73r655356lhtm@treble>
From:   Julien Thierry <jthierry@redhat.com>
Message-ID: <f0b948c8-c824-4d8e-6a0b-20cde05444d7@redhat.com>
Date:   Thu, 30 Jul 2020 15:42:55 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20200730140936.uvw73r655356lhtm@treble>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 7/30/20 3:09 PM, Josh Poimboeuf wrote:
> On Thu, Jul 30, 2020 at 10:41:40AM +0100, Julien Thierry wrote:
>> +struct objtool_file *objtool_setup_file(const char *_objname)
>> +{
>> +	if (objname) {
>> +		if (strcmp(objname, _objname)) {
>> +			WARN("won't handle more than one file at a time");
>> +			return NULL;
>> +		}
>> +		return &file;
>> +	}
>> +	objname = _objname;
>> +
>> +	file.elf = elf_open_read(objname, O_RDWR);
>> +	if (!file.elf)
>> +		return NULL;
>> +
>> +	INIT_LIST_HEAD(&file.insn_list);
>> +	hash_init(file.insn_hash);
>> +	file.c_file = find_section_by_name(file.elf, ".comment");
>> +	file.ignore_unreachables = no_unreachable;
>> +	file.hints = false;
>> +
>> +	return &file;
>> +}
> 
> How about calling it objtool_open_read()?  It's (sort of) a wrapper
> around elf_open_read().
> 

Sure, I'll update that.

Thanks,

-- 
Julien Thierry