Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751125AbWELWvF (ORCPT ); Fri, 12 May 2006 18:51:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751129AbWELWvE (ORCPT ); Fri, 12 May 2006 18:51:04 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:31720 "EHLO ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S1751118AbWELWvD (ORCPT ); Fri, 12 May 2006 18:51:03 -0400 Date: Fri, 12 May 2006 23:51:01 +0100 From: Al Viro To: Linus Torvalds Cc: Erik Mouw , Or Gerlitz , linux-scsi@vger.kernel.org, axboe@suse.de, Linux Kernel Mailing List Subject: Re: [BUG 2.6.17-git] kmem_cache_create: duplicate cache scsi_cmd_cache Message-ID: <20060512225101.GU27946@ftp.linux.org.uk> References: <15ddcffd0605112153q57f139a1k7068e204a3eeaf1f@mail.gmail.com> <20060512171632.GA29077@harddisk-recovery.com> <20060512203416.GA17120@flint.arm.linux.org.uk> <20060512214354.GP27946@ftp.linux.org.uk> <20060512215520.GH17120@flint.arm.linux.org.uk> <20060512220807.GR27946@ftp.linux.org.uk> <20060512222816.GS27946@ftp.linux.org.uk> <20060512224804.GT27946@ftp.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060512224804.GT27946@ftp.linux.org.uk> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 985 Lines: 22 On Fri, May 12, 2006 at 11:48:04PM +0100, Al Viro wrote: > On Fri, May 12, 2006 at 11:28:16PM +0100, Al Viro wrote: > > Ah, right - there was another uevent mess in fs/super.c. Sorry, got them > > confused... and that FPOS _is_ back. > > Actually... > > What happens is that turd in fs/super.c (one that should not have been > resurrected) triggers call of block_uevent(). Which uses ->driverfs_dev. > Which is a bug. > > So IMO we should simply kill that animal _again_, and see if block_uevent() > is actually need for anything on its own. PS: it _is_ OK to trigger than puppy from add_disk()/del_gendisk() and in between. I'm not sure if anyone needs it for anything, though. Triggering it from bdev_uevent() is definitely bogus. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/