Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 30 Jul 2020 16:26:17 +0000
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
From:   Alexander Lobakin <alobakin@pm.me>
Cc:     Alexander Lobakin <alobakin@pm.me>,
        Ariel Elior <aelior@marvell.com>,
        GR-everest-linux-l2@marvell.com, netdev@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org
Reply-To: Alexander Lobakin <alobakin@pm.me>
Subject: Re: [PATCH v1] qed: Use %pM format specifier for MAC addresses
Message-ID: <SKiAD0R1iJX4FHbr-_GUICKdDvuTvqrJjcR2CQEpE_-GCYtJq-lLbDeec-WmOCZ6NIxW6rca1CRm-d1tSRUu2zFyAapHAjvmgvI5iN6Zvp8=@pm.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Thu, 30 Jul 2020 18:59:20 +0300

> Convert to %pM instead of using custom code.
>=20
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_mcp.c   | 5 ++---
>  drivers/net/ethernet/qlogic/qed/qed_sriov.c | 6 ++----
>  2 files changed, 4 insertions(+), 7 deletions(-)

Thanks!

Acked-by: Alexander Lobakin <alobakin@pm.me>

> diff --git a/drivers/net/ethernet/qlogic/qed/qed_mcp.c b/drivers/net/ethe=
rnet/qlogic/qed/qed_mcp.c
> index 988d84564849..5be08f83e0aa 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_mcp.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_mcp.c
> @@ -2518,11 +2518,10 @@ int qed_mcp_fill_shmem_func_info(struct qed_hwfn =
*p_hwfn,
>  =09}
> =20
>  =09DP_VERBOSE(p_hwfn, (QED_MSG_SP | NETIF_MSG_IFUP),
> -=09=09   "Read configuration from shmem: pause_on_host %02x protocol %02=
x BW [%02x - %02x] MAC %02x:%02x:%02x:%02x:%02x:%02x wwn port %llx node %ll=
x ovlan %04x wol %02x\n",
> +=09=09   "Read configuration from shmem: pause_on_host %02x protocol %02=
x BW [%02x - %02x] MAC %pM wwn port %llx node %llx ovlan %04x wol %02x\n",
>  =09=09info->pause_on_host, info->protocol,
>  =09=09info->bandwidth_min, info->bandwidth_max,
> -=09=09info->mac[0], info->mac[1], info->mac[2],
> -=09=09info->mac[3], info->mac[4], info->mac[5],
> +=09=09info->mac,
>  =09=09info->wwn_port, info->wwn_node,
>  =09=09info->ovlan, (u8)p_hwfn->hw_info.b_wol_support);
> =20
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_sriov.c b/drivers/net/et=
hernet/qlogic/qed/qed_sriov.c
> index aa215eeeb4df..9489089706fe 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_sriov.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_sriov.c
> @@ -3276,14 +3276,12 @@ static void qed_iov_vf_mbx_ucast_filter(struct qe=
d_hwfn *p_hwfn,
> =20
>  =09DP_VERBOSE(p_hwfn,
>  =09=09   QED_MSG_IOV,
> -=09=09   "VF[%d]: opcode 0x%02x type 0x%02x [%s %s] [vport 0x%02x] MAC %=
02x:%02x:%02x:%02x:%02x:%02x, vlan 0x%04x\n",
> +=09=09   "VF[%d]: opcode 0x%02x type 0x%02x [%s %s] [vport 0x%02x] MAC %=
pM, vlan 0x%04x\n",
>  =09=09   vf->abs_vf_id, params.opcode, params.type,
>  =09=09   params.is_rx_filter ? "RX" : "",
>  =09=09   params.is_tx_filter ? "TX" : "",
>  =09=09   params.vport_to_add_to,
> -=09=09   params.mac[0], params.mac[1],
> -=09=09   params.mac[2], params.mac[3],
> -=09=09   params.mac[4], params.mac[5], params.vlan);
> +=09=09   params.mac, params.vlan);
> =20
>  =09if (!vf->vport_instance) {
>  =09=09DP_VERBOSE(p_hwfn,
> --=20
> 2.27.0

Al