Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 30 Jul 2020 16:29:36 +0000
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
From:   Alexander Lobakin <alobakin@pm.me>
Cc:     Alexander Lobakin <alobakin@pm.me>,
        Ariel Elior <aelior@marvell.com>,
        GR-everest-linux-l2@marvell.com, netdev@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org
Reply-To: Alexander Lobakin <alobakin@pm.me>
Subject: Re: [PATCH v1] qede: Use %pM format specifier for MAC addresses
Message-ID: <pXdhhJtDMa8Tr3tB0ugk5KdQcS3D71r1PEgqtPcJ3kBa4P_Yc0xG6HSXW9O1bQB_1FyD4wvS0xiXLiqvUb3OVzDKR9e7lLijB7jf6ZoHfaw=@pm.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Thu, 30 Jul 2020 19:00:57 +0300

> Convert to %pM instead of using custom code.
>=20
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/net/ethernet/qlogic/qede/qede_main.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Thanks!

Acked-by: Alexander Lobakin <alobakin@pm.me>

> diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/e=
thernet/qlogic/qede/qede_main.c
> index 1aaae3203f5a..4250c17940c0 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede_main.c
> +++ b/drivers/net/ethernet/qlogic/qede/qede_main.c
> @@ -144,9 +144,7 @@ static int qede_set_vf_mac(struct net_device *ndev, i=
nt vfidx, u8 *mac)
>  {
>  =09struct qede_dev *edev =3D netdev_priv(ndev);
> =20
> -=09DP_VERBOSE(edev, QED_MSG_IOV,
> -=09=09   "Setting MAC %02x:%02x:%02x:%02x:%02x:%02x to VF [%d]\n",
> -=09=09   mac[0], mac[1], mac[2], mac[3], mac[4], mac[5], vfidx);
> +=09DP_VERBOSE(edev, QED_MSG_IOV, "Setting MAC %pM to VF [%d]\n", mac, vf=
idx);
> =20
>  =09if (!is_valid_ether_addr(mac)) {
>  =09=09DP_VERBOSE(edev, QED_MSG_IOV, "MAC address isn't valid\n");
> --=20
> 2.27.0

Al