Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp2070455ybg; Thu, 30 Jul 2020 09:34:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2R9SSFLUCpSrG0WUUOkqgE2zAGQkn0m0ahwZFDxT1sz9tcNugdXJnMaOdZaVNOnHnaNLW X-Received: by 2002:a05:6402:68b:: with SMTP id f11mr3646096edy.353.1596126894318; Thu, 30 Jul 2020 09:34:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596126894; cv=none; d=google.com; s=arc-20160816; b=alXEouXDCXc6rrWg6yWBH+lelwd8J+5LjLWu2qFmtd7M/1bAVetFZ7/LmRQKR/CVxI 4rp8aD7qed15HMA3qdzQFTpkAW64Cq4BLzBbnBEOJRyAwJ9GaEq21iA5mw3D0WDeBEpp YOrxiwlNy3WL6J4TaFYNjx2HNf80LwasJByhLVB1ALyOT/aHMHHtziKRwVCWQOpLuUqg xf6HjLM6umyt9Ti2kVj33haXBchoQ/Yk8n0p2zQOr3hQTva/aDK3LN+7QIOoeh6WX8yI +uFhwvgG81VE1p4AAGZXBpvrXsNItLOt0JE+pJAlphsC6xF6prrDRw7pUpiWQxFx/t9x SOFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=0UAnNGVJhu93xc5OqQ2RWL81mfOCTEvCRgNc36dFlM4=; b=AsB7ci3AA4Ekpxl7sJHfFEuF+9kL9FQl2/UfTEvlTEwy1qolpKzoV3vOHRAsmOVPIF fCGL9CgiE0ug8QlrRdrY8uLBNh/P1VwgGGpmjT+3OzmXd9qLoLLpkhU7WuAHFQvBZqY/ VYJjwIVrKnSejP7u/XZ9nZproAvIgskPyv2bG75tdGT+jkKgr3vCHM94P6bxgAjduE6O b6OGleU7cHaf/tYBfVylWMEtY/2iyWuvwa0Up0922cSaGIb1Hs7kpKc0XNxKJzBxeROS JH9jlzWlT2STSSMcX/IhrzyWrJC1Gs5A1dYKhKpconXCFTY3KWUEDIQaw//65MDrU+uj trPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y20si3761908edm.448.2020.07.30.09.34.32; Thu, 30 Jul 2020 09:34:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729843AbgG3Qbq (ORCPT + 99 others); Thu, 30 Jul 2020 12:31:46 -0400 Received: from verein.lst.de ([213.95.11.211]:56543 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726275AbgG3Qbq (ORCPT ); Thu, 30 Jul 2020 12:31:46 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id B667468BEB; Thu, 30 Jul 2020 18:31:42 +0200 (CEST) Date: Thu, 30 Jul 2020 18:31:42 +0200 From: Christoph Hellwig To: Al Viro Cc: Christoph Hellwig , Linus Torvalds , Stephen Rothwell , Luis Chamberlain , Matthew Wilcox , Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 22/23] fs: default to generic_file_splice_read for files having ->read_iter Message-ID: <20200730163142.GA22875@lst.de> References: <20200707174801.4162712-1-hch@lst.de> <20200707174801.4162712-23-hch@lst.de> <20200730000544.GC1236929@ZenIV.linux.org.uk> <20200730070329.GB18653@lst.de> <20200730150826.GA1236603@ZenIV.linux.org.uk> <20200730152046.GA21192@lst.de> <20200730161701.GB1236603@ZenIV.linux.org.uk> <20200730162219.GC1236603@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200730162219.GC1236603@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 30, 2020 at 05:22:19PM +0100, Al Viro wrote: > FWIW, none of the dubious (and outright broken) cases I've found go anywhere > near that. And it definitely won't help tun/tap... Then I'm missing something obvious - what is the problem with tun/tap?