Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp2119482ybg; Thu, 30 Jul 2020 10:46:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+a16wQolifX6H0UqHjqYyiXhKnF3eOtCmd5VUwf0pGtyio/vawHtuYht6TVq6nS3Lfi8x X-Received: by 2002:aa7:c88f:: with SMTP id p15mr107947eds.33.1596131196808; Thu, 30 Jul 2020 10:46:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596131196; cv=none; d=google.com; s=arc-20160816; b=D0EKyyxRqyEedMbWKX6bLSo1nGUAfCRO4b90WiBhmVW0OzeL9h0aVUqgcGLZqCTvgw vABc5Rrpc+66lY+l30iPg9cQG8/EBKNHqAY1dxiEttmxfTQulThm8a9Iy3YlwBjg9Q5F yqifTgGzoUW/AeEg3z/DvefNau1IrWhnX1lOBipomqE7CEuAWLffJiUR9Ln25lGfZWRh sm49stHMMBo/YA+93HPy9DxyDNWVXPzAe2Lq8BeVqHd3ZG8P+HlyUveHmJo2Gx9hadbQ 4llll8L219Ug/vRk78gCbhVeAbelf7mbf2qGhaNQoXfE10f+Az24xY3m/Od90se8x2B6 aErA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=Mjw46l0WiX2cgOgOB9HnUvadVnuzoTI29vrJPNcSYdE=; b=JrcL3FcYd2Ez4+RaUXHPfzOPtmjRCHyqPK6oeYJzoM1jtix3KlSfmK8m4ltVtEqqNv /OYBgQcaI/LIQRNTocroH5JnpzDBSkXWWkjElIGa3gRIBJ0J6ajdG96FtaC2JfJS/Lyg 09n35s6Y+6Lc8qFoIh7ass/1cSbaJia8ciykgV/VZ15XBWLU//tfrz307xDHcg9Ylh4x OMeOeIHkUUB7NzHP+XjaGlhGTvXWjkMJVRBWlnfiZFL4f0iXyJNkbozFSpfcyjVwHXUL 9oaW/iAfHEmD/pD25Aw1Sc8OIBN7JrC7nCuEzjb+2bQoCMFWWYMHBFsJG/EoHCvudqL+ u8VA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=tO79DpjB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f22si3664980ejt.233.2020.07.30.10.46.13; Thu, 30 Jul 2020 10:46:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=tO79DpjB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728070AbgG3RqD (ORCPT + 99 others); Thu, 30 Jul 2020 13:46:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726544AbgG3RqC (ORCPT ); Thu, 30 Jul 2020 13:46:02 -0400 Received: from mail-il1-x144.google.com (mail-il1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F705C061575 for ; Thu, 30 Jul 2020 10:46:02 -0700 (PDT) Received: by mail-il1-x144.google.com with SMTP id l17so12975390ilq.13 for ; Thu, 30 Jul 2020 10:46:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Mjw46l0WiX2cgOgOB9HnUvadVnuzoTI29vrJPNcSYdE=; b=tO79DpjBf7dyEFJtFiuMv7DYl6NYwoM4SslJJRQr2CELhHlLvy1t0mj6zr0HNPy80a MEnLhW4EDL5MCV2lUcMEZBcNXPSuTL9BaA3Ix0Aoa/+ooD6lm0gVXYvW02BnmWTRKcU/ 0Plq72094GIXK6XFS14k1u1uzqAl6vhuX2vy4dsipM7KOO+rRwdlEmgiVSoL0BW0skfk hzHZ/QFxYz9HltfzvI6ZjG4cFQ19VCjoqyw67fIIHZk1sA5JMscy3+WEpIhM/j9Yut3j DYtWYatt/I/VbG/cpIjB83+29/KwM61PK8T8x2udZGQLMsAc0+aJopQ//FLWB92fd5ja ePtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Mjw46l0WiX2cgOgOB9HnUvadVnuzoTI29vrJPNcSYdE=; b=Ie3LrosumCh0aXuAljsYLj5KBZptNv17RWHEXRgTi/ga/YOzFMb4XvkoB7l6Tlwcod f6ByriM8O6JGj69az7JFY42N30Y4JRxS7uO395rPtnb5BmxAOu7A8K1cXFoAjlDP+Qxk K3LR7vBRfTaAsy+FjCPbaJ6RbmK64loPyOmPtGlsaFP4OEwX/K9BYWXNPTVjFiC5Bpwr qtMGJNTOl09vuS4x4fYV8ZfM5ZrBJzNIcYiDreifvawlOeXUZNq5Lt8kGX2tQNqDhsIz GaGrW/isPv2QM+LVV9A3N0SOc9P7GdcXZve2kywp6F/DDe5L/BSs4/+qS/5/b1W1KG3w eXGQ== X-Gm-Message-State: AOAM532nSAwl9o6r7fCOj5GdybQ61268kYidvCKe704kXV7IgN6Fc8Wb 7mhYfhLjHmziSTYXut/cp+PXn8XTN3g= X-Received: by 2002:a92:46:: with SMTP id 67mr34706426ila.113.1596131161540; Thu, 30 Jul 2020 10:46:01 -0700 (PDT) Received: from [192.168.1.58] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id r2sm3278374ilc.58.2020.07.30.10.46.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2020 10:46:01 -0700 (PDT) Subject: Re: [PATCH] iocost: Fix check condition of iocg abs_vdebt To: Chengming Zhou , tj@kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200730090321.38781-1-zhouchengming@bytedance.com> From: Jens Axboe Message-ID: Date: Thu, 30 Jul 2020 11:46:00 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200730090321.38781-1-zhouchengming@bytedance.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/30/20 3:03 AM, Chengming Zhou wrote: > We shouldn't skip iocg when its abs_vdebt is not zero. Applied, thanks. > Fixes: 0b80f9866e6b ("iocost: protect iocg->abs_vdebt with > iocg->waitq.lock") Minor note, and I fixed this up, but these should be one line. -- Jens Axboe