Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp2129508ybg; Thu, 30 Jul 2020 11:03:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMngoDVpQfd/2tCr9r5xTIQIFHnRTZDq8EYNWdD7O/1j5S0Wz7zFtfINwzVkhHTaq6Jcva X-Received: by 2002:a50:ccc7:: with SMTP id b7mr182626edj.9.1596132197748; Thu, 30 Jul 2020 11:03:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596132197; cv=none; d=google.com; s=arc-20160816; b=bXyK859lU/+iQWm0ksqu2fzK46/TF+brxOU03QnQ3lim70jnVR9anxnK0MeMiY1Aoa Ua/xZW75MBaHjwsw7TNkR73V9sW2WQihQ4hznhiHM9RLK53LtDOX5PrDxq0gXNbONSW0 rhCTLZogINQppM8mou0og8jbff6YtqGYjrzaAybv3jdTu9zGo9hQ7IqMeLgv9vY+G7pO NSMWat2xcIF8gUG8/j1hth5KXt/m0wzD0F00oSkTTZ5ZViDpJba/I1S2ReNXVcendjbQ +hssVF6rkZ5LAlmgvBEqZebChJ1QW8FWRtMz1uoZTQ8cJHJl8TO7IQXZknqgV0OAXLCH n7tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :dkim-signature; bh=cNgWjzKHskwT0MftVG/9B5dX6kQx1rkKM1Y7gjwQfIo=; b=BvkUxOyjOBB03cu4F+Rpg9PHSzuEJ4zjYXOMmfUjlRpCH92jN0PtTcEj6IgDhZ0g4I eNtaMy9S3shWw8xGKPgbBObUS2KoU3Dy27BQ0SaNCswms4A0hudZsNmRbRXn0eLmWTke r276aLzxuZgCFRhG7ptDwP7nm6CwmvoqNinX5rMwIPYZ/50MYPmuugB2+RZw1LImspvB 2aN+36mwrl4HSUqhh9plQsE4ZoJR4Oq7Oe2xfSub2XCP9Lap5AKi+U/4hJePEbHlUBBe 7veJK8xEPdCO4g/MCqqUdiQdjiRyoGgnW6NiA6OD503re9623645PsAFrRcJgqWa9t8d R5BQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=t4aPDRYe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u21si3590739ejr.295.2020.07.30.11.02.55; Thu, 30 Jul 2020 11:03:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=t4aPDRYe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730356AbgG3SC2 (ORCPT + 99 others); Thu, 30 Jul 2020 14:02:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726275AbgG3SC2 (ORCPT ); Thu, 30 Jul 2020 14:02:28 -0400 Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC913C061574 for ; Thu, 30 Jul 2020 11:02:27 -0700 (PDT) Received: by mail-qt1-x841.google.com with SMTP id w9so21012083qts.6 for ; Thu, 30 Jul 2020 11:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cNgWjzKHskwT0MftVG/9B5dX6kQx1rkKM1Y7gjwQfIo=; b=t4aPDRYed6LP/GqYAZ/1/OhlJjN7mYd7e8LPKEnQS9ZXO5Te0mHernQE6PfLgGDk0Y WHGyAeJr2LLBdPfyVLkyY4wilrUtQb+UrhCynaHFVINnCiAa4612slLDc5DjRVbuyO3g MxOb6Oytk9KLjLkeY0Z9cXet6Pzu02vXp0HYUCKqDjnLq1RnMilpp2JXkr7J5qEmmV5k o0NQodpHuAmj0bAKvTDjL/XQSM7NXO3SLR8bNqujETIk/vdwFcHJTvPOJs+/gzYjtnsn KHUTAKjiXpz+PWWwvA7MJPwNhZfKUgpBydweua4CKc9KuqBw0fbakFOjvd0iu7QGgWsq wprg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:date:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=cNgWjzKHskwT0MftVG/9B5dX6kQx1rkKM1Y7gjwQfIo=; b=quGykgoAfM58Tt52fg1xGP7SigLMiaN/HavF5pw/0ZVt9LqnNP1g7OSVnKjSpBYzKk y5HDUI9uZm9gdnujKfz7n/YX0guUZnfHU95pNNXTIoQtXqXHWqLbjqKg/yXOMOG3XPG7 enZwG4C1rSlUIsZTPuEJ/QY8CnlNjZR3Hpyyq/xFdu6uuvSFtivO3tbSZgBZqYf8OQ8o dyMmGKEKvpNCWkYOp2Grt7cU+OPcR3eRYpVYTS+F0CcgAZ7YSkzukLpqJOZzJpvUDmx5 AloKimQppT2ZxOUlUGPRMk+cdF/OHZd0ZoBDeRMBLQKaUYmr2GoLAnXa+KWsVx0D5ghv POrQ== X-Gm-Message-State: AOAM532k2IgsMIElfpc+BnIEOoHF4AlW01GF3w93aBEQNYUU3rax3LR1 lqD1lC5jUTMJaiBeiTlh3CpygBek X-Received: by 2002:ac8:6a07:: with SMTP id t7mr4201192qtr.1.1596132147185; Thu, 30 Jul 2020 11:02:27 -0700 (PDT) Received: from rani.riverdale.lan ([2001:470:1f07:5f3::b55f]) by smtp.gmail.com with ESMTPSA id e4sm5232739qts.57.2020.07.30.11.02.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2020 11:02:26 -0700 (PDT) From: Arvind Sankar X-Google-Original-From: Arvind Sankar Date: Thu, 30 Jul 2020 14:02:24 -0400 To: Ingo Molnar Cc: Kees Cook , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 00/21] x86/kaslr: Cleanup and small bugfixes Message-ID: <20200730180224.GA1203420@rani.riverdale.lan> References: <20200727230801.3468620-1-nivedita@alum.mit.edu> <20200728225722.67457-1-nivedita@alum.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200728225722.67457-1-nivedita@alum.mit.edu> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 28, 2020 at 06:57:01PM -0400, Arvind Sankar wrote: > v2->v3: > - Fix the first patch: command line size should be strlen + 1 to account > for terminating NUL. Avoid calling add_identity_map if cmdline was > NULL, though it should do nothing in that case anyway. Hi Ingo, I noticed that WIP.x86/kaslr and x86/kaslr both have the v2 version of the first patch. That has a bug in the cmd_line_size calculation (missing the +1). Thanks.