Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 30 Jul 2020 14:32:26 -0700 (PDT)
Message-Id: <20200730.143226.1527353835656521105.davem@davemloft.net>
To:     f.fainelli@gmail.com
Cc:     edumazet@google.com, netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru,
        yoshfuji@linux-ipv6.org, kuba@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] tcp: Export tcp_write_queue_purge()
From:   David Miller <davem@davemloft.net>
In-Reply-To: <2347a342-f0b0-903c-ebb6-6e95eb664864@gmail.com>
References: <20200730210728.2051-1-f.fainelli@gmail.com>
        <CANn89iJETzud8PK7eTj=rXMSCjBtnmcSq1y0qF7EVK8b5M_vXA@mail.gmail.com>
        <2347a342-f0b0-903c-ebb6-6e95eb664864@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Thu, 30 Jul 2020 14:23:50 -0700

> On 7/30/20 2:16 PM, Eric Dumazet wrote:
>> On Thu, Jul 30, 2020 at 2:07 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>> Hmmm.... which module would need this exactly ?
> 
> None in tree unfortunately, and I doubt it would be published one day.
> For consistency one could argue that given it used to be accessible, and
> other symbols within net/ipv4/tcp.c are also exported, so this should
> one be. Not going to hold that line of argumentation more than in this
> email, if you object to it, that would be completely fine with me.
> 
>> 
>> How come it took 3 years to discover this issue ?
> 
> We just upgraded our downstream kernel from 4.9 to 5.4 and this is why
> it took so long.

We really can't do this, sorry.