Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp2292227ybg; Thu, 30 Jul 2020 16:05:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6JYbrKsm2mpCWYeraL1OSghBiOdnsLQv/PI89NcsKsECwV8AeK5cFOzW/gdSgHiEyO3Ig X-Received: by 2002:a17:906:a284:: with SMTP id i4mr1426344ejz.490.1596150327426; Thu, 30 Jul 2020 16:05:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596150327; cv=none; d=google.com; s=arc-20160816; b=NhTXljVdHUVCekFL5FwHLnBdt2aObl5QnmE/53Hnh1q9N/YgasqE17pCzf7b2xx08C 1IdPIlPKl7Rh0Ly1rRx0McoT43GBdgSqQsXr14ldgY1QpTx2eZpB9zEy19syrIYSP0c2 OB8hFPCubRUt49kWNcm4Ico2KZSQzvlvZNRqs7HH+W7qUbJSJvVm5agTNGxsT2R+kHpX pAo5bIkzmn3h0Fa9BPSvD0SkwdGUoIzu10JWHBt56k9Dh4HpCS7v53FtPEQQ4UCbJ2B2 2INJfpcputURLAgK06myA8cSU79xmAp9hyvVfLB40kp9dmrcspLVqHB7df8Pw8JMByu9 EJEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=jKFR4wiBx/HaHrC0VB9Ldio7vQ6cHAEOQAFHiaQMxF8=; b=pvkRXkkL1Cs0SSpPxUTHRDAQXuvp9PdZTx1E0NlFgpgcYUWLjeC2Ez/Ie9AfvdRu3U JXOsGFXkml59gZh+H6PwZPCAbwDKF18wOmoGzuroC4N+EUto3Ut8KR+NOu2y34+WSDFB 5yPIjlWdtvsNPuQiWs+8vPwA9ghVj+055cfU09hkViWABzNmQdSIDHllOGhzFochlbHj fZqo6lnkUC8adwaxbYe//i9e3ZZ/SSZwDYtHjrbqzjKB0CSE1Eb6rcZcUG0nbT6xklC5 Fe+wUqcSwFqkyPSeye0/jse0qoBzPCCSvWfBuJyaWKKkDIaGmFcBWtHJOcK61PDD09tf q+dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=gWBXsx0M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s4si4256074edc.423.2020.07.30.16.05.04; Thu, 30 Jul 2020 16:05:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=gWBXsx0M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730419AbgG3XEv (ORCPT + 99 others); Thu, 30 Jul 2020 19:04:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729896AbgG3XEt (ORCPT ); Thu, 30 Jul 2020 19:04:49 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BB0CC061574 for ; Thu, 30 Jul 2020 16:04:49 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id e22so5968622pjt.3 for ; Thu, 30 Jul 2020 16:04:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jKFR4wiBx/HaHrC0VB9Ldio7vQ6cHAEOQAFHiaQMxF8=; b=gWBXsx0MQGZG2I79NE9hpfvFWlBw7KcZ4qm0j1q0EkUplPt832N4i3YSrKz26ss4kb g2XLI3zVHlek4jfeohPndHZwKOFP8HS/2JiN7Hx9XWpAPtuqo8fV6t5GTuR9Zo55Z41E xsfuBhUXLY5wLMJl8cns++I1VCDtixR66PnkI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jKFR4wiBx/HaHrC0VB9Ldio7vQ6cHAEOQAFHiaQMxF8=; b=U+Grv8rENw1PP21PEFrpNX9KuQ2ZLM226jEKcqwTI11S4KOc8buXQfqatXtd1sTYRe alGYpmT13IJ40e60jGy7dKJs8PRdYsOk1Du5jLsdjlie0KSmzX2xS/E41pI7B8jO/Pxq L+hL2Wf80+p6tybYrW9avrL9YOAzG4kNtTbrTbgbUEm+8QKGUSANmDt8RrS/zbhdhxtQ vH2TGKtlscV/FdBtr59uUkiQzgzzgQUjjcd99wnivE68BF6ddaC/NfAxQNVw3yQ1pW4T J9EKiNG/zIGqp1SUlmM9aL0zzUhnKscKGl0uxbRk/9HDrNQpUyBREIS19kXERH0rRmI3 tl6Q== X-Gm-Message-State: AOAM5339IU5cMvTMBByWVSdWgX9gJmsLE0g4O1Mepc8oWDiUrJB5u1rl UQTLPoiCLpRzQ+vphDMM0iH32zLYX38= X-Received: by 2002:a17:90a:8993:: with SMTP id v19mr1323211pjn.122.1596150288637; Thu, 30 Jul 2020 16:04:48 -0700 (PDT) Received: from google.com ([2620:15c:202:201:a28c:fdff:fef0:49dd]) by smtp.gmail.com with ESMTPSA id l62sm6953337pjb.7.2020.07.30.16.04.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2020 16:04:48 -0700 (PDT) Date: Thu, 30 Jul 2020 16:04:47 -0700 From: Prashant Malani To: "Shaikh, Azhar" Cc: "bleung@chromium.org" , "enric.balletbo@collabora.com" , "groeck@chromium.org" , "linux-kernel@vger.kernel.org" , "heikki.krogerus@linux.intel.com" , "Patel, Utkarsh H" , "Bowman, Casey G" , "Mani, Rajmohan" Subject: Re: [PATCH v2 1/2] platform/chrome: cros_ec_typec: Send enum values to usb_role_switch_set_role() Message-ID: <20200730230447.GE3145664@google.com> References: <20200730225609.7395-1-azhar.shaikh@intel.com> <20200730225609.7395-2-azhar.shaikh@intel.com> <20200730225921.GC3145664@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 30, 2020 at 11:02:28PM +0000, Shaikh, Azhar wrote: > Hi Prashant, > > > > > Please add the list of changes in each version after the "---" line. > > I have added those in the cover letter. > > It is good practice to add these to the individual change too, so that the reader doesn't have to go back to the cover letter to determine what has changed in each patch.