Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp2314391ybg; Thu, 30 Jul 2020 16:49:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTROcAGT+AP1fIKEmz5ka7sg1V8ZPRPCseVTYwpe/rSt00oQfwn4StjRv1HhIC8XrAXocK X-Received: by 2002:a17:906:c083:: with SMTP id f3mr1438723ejz.530.1596152986708; Thu, 30 Jul 2020 16:49:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596152986; cv=none; d=google.com; s=arc-20160816; b=d8U1wkZSGA0+NVdYwTAuXjV4apUZUBbBS3nhjQMRWnae+A6xskN4YJBWQeNSwdLwY8 Vuyd36fEXrNdyZ48Lbj8tjE0zUu+UAQRnd7SUJ9N+ZkZ3YocmxH/7Cmbj0YQcgZSFiaJ Ie9Utr92zGaHgOCFIP2GISinyqzArhQ8RrTbqvZZDTR03z1RxmvTKf7g0Wep28isfGHR jZlP1N20gsi+0zGq8xD33htfjKRff3N7OKH0nIeuPqsH5vCfwu/ID1p0wUiMHlk4nlcS XxLxAziYevBb871z79SHSsn3F9naCOzwD0/GRHMiXTfQ15Vx1VmQ0gLAPsVkOjSzYsVo qD/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=LIOKBGZfRASo2D/3orERxe57iSzMy6S6QL+EcVsSq84=; b=TYKGK7c5UqNBcwszQ/UkgXAzoolofgKyLX3Qd11Ge/KxxbwJN8mf1RSlRgNS+A1bbd c9ZNCzCt5/9KrFPlbVGWowN+BkszY2cb/lOxVrHN/Ur5dI5MJJ2nsBKHlYiYXiBXpzOR gkXBPgFfkHd1qKLgLa2XSGCGEp1mMg9t9lvg1VcaED0F/GZDMwqyMbT/vbuXSMXDaIHh AZJz1KbZg0InhBkVLAk99JwqT1SOIf+dgEocYSJt6xDkOmdoH0NlovBh4SyOMtdqTFBy N6kpvaQRRwJyyR8Vds5EJKtG174HN+gB5y/T+76h56sjF4q1x+p2AR47kA9KQtVpgM8x J02g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=ffhiqppk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kq26si3757067ejb.754.2020.07.30.16.49.17; Thu, 30 Jul 2020 16:49:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=ffhiqppk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730797AbgG3XpE (ORCPT + 99 others); Thu, 30 Jul 2020 19:45:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728047AbgG3XpE (ORCPT ); Thu, 30 Jul 2020 19:45:04 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6488BC061574 for ; Thu, 30 Jul 2020 16:45:04 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id u10so6190864plr.7 for ; Thu, 30 Jul 2020 16:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=LIOKBGZfRASo2D/3orERxe57iSzMy6S6QL+EcVsSq84=; b=ffhiqppkEpp60lNBK9wc8DYAkm/vTkDoboYGbBo2xqlSHEeCPYzHqhVscdsH6Umn+Z fa990Z+7cFxq9gC/X46ceQhRibZBKHXyKFcYDpMzaOoFyw8hb7tlyAhSIXMnuxVIF60Z mIAmKxwy4DD2gc0XiQ2FjJLc/4xT07hC2ePonK1uDEItCRJGu7J372g3q0edaCmupZ0l wK/qCZquibp5Y4CXoN9huGgdpNDUfLyfn2zJ1PhaWYAlx0ZeGJt1+G81BhrTXDPcin8U 1aNKJcw0j1vpp7+Nj6rAjuelaSD6/Wuckn0SKdfzLDblrI6c3NSrMLY12HXCu/YxJUFB CJEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=LIOKBGZfRASo2D/3orERxe57iSzMy6S6QL+EcVsSq84=; b=r8s7ns6ypU2OXYVI8KIVWUdykTRqL8HhhpGdXnhPg+mht9N6wjWKIX2LyN+GebzAWg BQhvVXzjwDGT0+EDYLKQGrTSt0pOmmIiddbiZETL5JgSu35c0Ni/8qQsqET6WGO4ZQ6f XMbLvT5IJro0AjRpLCKCQ0ogks4AbOXV47O2Be8sC8l8dlVyROG2kg2KTEo1BW5heEPl Z2Q4VwygnykWWMduwoU0kyAXk+i3DPVOywjBjzc43qnP0GkGWg0SDwCPiSviGq+YUqUm bLCKhCZ+95SJnoZUHKvyP9C8dD6s7DkyePI14+dSroerVzcCsNeBeBiBXVUBRTFMX6+Y 4E6g== X-Gm-Message-State: AOAM530dDxPRHjFqo7u+wBa20Y4iHQX+xisyKEl70nnwLNYxXDnRkPGb radNvIgsF86p7Sypdn7dbnsrtg== X-Received: by 2002:a17:902:6bc2:: with SMTP id m2mr1463515plt.158.1596152703771; Thu, 30 Jul 2020 16:45:03 -0700 (PDT) Received: from [2620:15c:17:3:4a0f:cfff:fe51:6667] ([2620:15c:17:3:4a0f:cfff:fe51:6667]) by smtp.gmail.com with ESMTPSA id j11sm7475771pfn.38.2020.07.30.16.45.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2020 16:45:03 -0700 (PDT) Date: Thu, 30 Jul 2020 16:45:02 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: qiang.zhang@windriver.com cc: cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mm/slab.c: add node spinlock protect in __cache_free_alien In-Reply-To: <20200730101934.38343-1-qiang.zhang@windriver.com> Message-ID: References: <20200730101934.38343-1-qiang.zhang@windriver.com> User-Agent: Alpine 2.23 (DEB 453 2020-06-18) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Jul 2020, qiang.zhang@windriver.com wrote: > From: Zhang Qiang > > for example: > node0 > cpu0 cpu1 > slab_dead_cpu > >mutex_lock(&slab_mutex) > >cpuup_canceled slab_dead_cpu > >mask = cpumask_of_node(node) >mutex_lock(&slab_mutex) > >n = get_node(cachep0, node0) > >spin_lock_irq(n&->list_lock) > >if (!cpumask_empty(mask)) == true > >spin_unlock_irq(&n->list_lock) > >goto free_slab > .... > >mutex_unlock(&slab_mutex) > > .... >cpuup_canceled > >mask = cpumask_of_node(node) > kmem_cache_free(cachep0 ) >n = get_node(cachep0, node0) > >__cache_free_alien(cachep0 ) >spin_lock_irq(n&->list_lock) > >n = get_node(cachep0, node0) >if (!cpumask_empty(mask)) == false > >if (n->alien && n->alien[page_node]) >alien = n->alien > >alien = n->alien[page_node] >n->alien = NULL > >.... >spin_unlock_irq(&n->list_lock) > >.... > As mentioned in the review of v1 of this patch, we likely want to do a fix for cpuup_canceled() instead.