Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp2337230ybg; Thu, 30 Jul 2020 17:41:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykyGiBZCq8n3THHZ4peM3lbALdU3rgU5cRtI0UlgDfPzDZghdGNxFbBoO/+Gj3pZ9jvr83 X-Received: by 2002:aa7:cb15:: with SMTP id s21mr1598619edt.175.1596156076437; Thu, 30 Jul 2020 17:41:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596156076; cv=none; d=google.com; s=arc-20160816; b=SDfBKZuFb6xOdPIXf8hSVHs8BL1RPiSx1c765y7sRrz4L8C67ze2w5togyeKR6gid6 Ui/tlLqqS8RSamsh7ME8vpgHuwjneFjnbB49YZjkgFy4QFT3R/1kzvWDxTIQIS+LTb1L 6YvZHcxlRlwgtOQF5pfvz8S2uNqS+JxtTOUEYoz/N4IjIE8QTamp5TcVm+I17+vL+6K9 ZYnR5j4eqyPyNDnyQHSjSzmx2mD41nSmxAULkg9tFMMvv4UG69uTJgyyHB3dAJYz/R/j 4kggslVG6SUzR99HnYIiq8aVECRpevAck/hjkVeQ8kgpcN8SxQB7aB1acRg5YsdzzVD7 z3cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=drjhJDJmobr6Cf0JOPuS6+m62B1+L9wyxUWY4u85BkE=; b=ibJJ3dMfK8YIOvvvXoY8NHkbiaEDU1iO+9nq3nz9PabbVnssa8vHFnf3q8uyrJXCNn LjXGDQ5Z1FP2RFGRcH7tFgItpJfzh//4r45KtsZguemFoEwCcCmfxEdqeH5cAHxA/7g8 k7SOmia+gM3y/cvzJGjkHBH25FT/ycobhehMmO/zncvNhVSQGB4Fs/Js083ayS2wyTEc Qs9xsj6SwX1wc8kTn/3uKKbf2Sr989cOZ70pxsPLYg0eTTUfP5ftaHPcxXHywpw5y/pK w4Xkbp3jNFVR1zIaqEm5IahNp+Ji1hzabHafValpO6wYgoGg3auV+500FwQF8YL8mfHH YdGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=sKCldL2L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l18si4299245eds.376.2020.07.30.17.40.49; Thu, 30 Jul 2020 17:41:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=sKCldL2L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730982AbgGaAk3 (ORCPT + 99 others); Thu, 30 Jul 2020 20:40:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730975AbgGaAk0 (ORCPT ); Thu, 30 Jul 2020 20:40:26 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B8E3C061575 for ; Thu, 30 Jul 2020 17:40:26 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id l6so27398489qkc.6 for ; Thu, 30 Jul 2020 17:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=drjhJDJmobr6Cf0JOPuS6+m62B1+L9wyxUWY4u85BkE=; b=sKCldL2LIUXXUCo2BchwUNCP3/p0rPpgg0Vyj0YtDpGMcMBJ8QuD7CXv0o4bMd2Q24 UlNIT0/4AWq13RTLlibWN4aahPbqYSdMMn1uPKbrgw+Hj2+Xg3hKO5Ua6dVZCGbs8/tf 22fWQSacDv8lev3aXHsh+L7fzcZrL4ruRQKqU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=drjhJDJmobr6Cf0JOPuS6+m62B1+L9wyxUWY4u85BkE=; b=YwwSJLb1myrtDtB89rDDYlMAVKCz7cuYr5JnP5gzOV31CX83IC5CAC4TcEunDbbQI3 yPKK5zFMOiy18eLt4kCAiU5BElxWCqeXJ5uXoRVnWo61Y3r6Qp2j/z12SxvROKzoJr4e L22GsYFm7ettRGa8X2kcWTSb+yL7Gg0xYnNuyLhHT2YCyJBhEAZk5psu5B/e6ovQx8/e begoJHTVL1n/PoUwTHN9cFXFaNXJfSwFHdKsYao9kOELd+TJhcphU+mXzgBjLNL60PnE JojndCj3eAfVu+wHBen3sTlu1za4mwklebJbjHweddqGxLedJGzcdKbRZf8phacDIWsq 1aOw== X-Gm-Message-State: AOAM533DiW2AoxZq5YaYaMwS1EImsGLfpUYDSutHlEzXx/74/e9/4f6Y BFxf6aWhpvFGuhuDBhlSRtWVK6DcMo4= X-Received: by 2002:ae9:e407:: with SMTP id q7mr1750951qkc.451.1596156025395; Thu, 30 Jul 2020 17:40:25 -0700 (PDT) Received: from joelaf.cam.corp.google.com ([2620:15c:6:12:cad3:ffff:feb3:bd59]) by smtp.gmail.com with ESMTPSA id c5sm3077320qtp.62.2020.07.30.17.40.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2020 17:40:24 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , Josh Triplett , Lai Jiangshan , Mathieu Desnoyers , Neeraj Upadhyay , "Paul E. McKenney" , rcu@vger.kernel.org, Steven Rostedt Subject: [PATCH v2 2/3] rcu/tree: Clarify comments about FQS loop reporting quiescent states Date: Thu, 30 Jul 2020 20:40:11 -0400 Message-Id: <20200731004012.2324147-2-joel@joelfernandes.org> X-Mailer: git-send-email 2.28.0.163.g6104cc2f0b6-goog In-Reply-To: <20200731004012.2324147-1-joel@joelfernandes.org> References: <20200731004012.2324147-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At least since v4.19, the FQS loop no longer reports quiescent states unless it is a dire situation where an offlined CPU failed to report a quiescent state. Let us clarify the comment in rcu_gp_init() inorder to keep the comment current. Signed-off-by: Joel Fernandes (Google) --- kernel/rcu/tree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 6b6fc28bb670..a621932cc385 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -1701,8 +1701,8 @@ static bool rcu_gp_init(void) /* * Apply per-leaf buffered online and offline operations to the - * rcu_node tree. Note that this new grace period need not wait - * for subsequent online CPUs, and that quiescent-state forcing + * rcu_node tree. Note that this new grace period need not wait for + * subsequent online CPUs, and that RCU hooks in CPU offlining path * will handle subsequent offline CPUs. */ rcu_state.gp_state = RCU_GP_ONOFF; -- 2.28.0.163.g6104cc2f0b6-goog