Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp2380544ybg; Thu, 30 Jul 2020 19:35:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmZl14xg/lTjdWkIHVD7Q3qNX+Ofq60nipZVGIp82XZOX5NZNxIjs1A+yuqN4tf/K8FL2s X-Received: by 2002:a05:6402:1ad1:: with SMTP id ba17mr1793588edb.119.1596162919620; Thu, 30 Jul 2020 19:35:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596162919; cv=none; d=google.com; s=arc-20160816; b=SqxLEEtx7/Yv820HDYwJYgH8IaRMJvG1RJZqjxURt+HoNuSmnE52PgEwKjrOpZkgNh 3aCOvVzFpbJcO+HssLxP0S9DJrp666TMv6C68lHUh9+BN8sVi67wzQD7c4thBkSwa3PO U/teQ+FEbk7878ZyhLvoF0Xi/WAtifDLc+YpsjDA033xyE1dVyfZTAwup/oS50iySrAf dIHamETymUfWJ7Mt/r9rxOH+kgxGdNDM20ihRWzmljcD3TSMt1W8pHS+dz7i8NvFyYkx otIWv6aGjZQI6tcbXoCaGe6sTmrRM7uvgmw/di3sPuUaIEFryx8cj4W/LHJrjK3PMZt7 pKBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=5WRgw4l2+he84k4Q2ywuDOzVP6LEy6VHO7MnU8IoeOA=; b=jxZFo8MF4V1Hce5CQ6ApqYskWMvlIaDIhg3jjSDvRfPta8C/FIuuuI+wUa2clOCH+v 6GcALF/dESEk+Ox7WRCjka+7H2w5dD1o31zM0hQ2Cu65pjrDfDCDwCUuioxlr5bnDqut lNhq0L5QpQhEebF3XwkU8u5TFfFNQprzbFzAXnWe9kUIhfTVEYnFXKoBaBq8J3opz1LN N2TAjIbRxcPH+pXoOoOEdTtcyvgMTQtKPjJoRBMyrvLXQJc8J95oExEPYKMqvszsJUKA ujSEVsageai4S6oHSQwJ1NkygWQTit26tOfK074/8c9BN4rSdGOIFIxZ1UyWnHx81CBC rdmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v8si3888381ejc.311.2020.07.30.19.34.52; Thu, 30 Jul 2020 19:35:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730962AbgGaCdc (ORCPT + 99 others); Thu, 30 Jul 2020 22:33:32 -0400 Received: from regular1.263xmail.com ([211.150.70.201]:32884 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730644AbgGaCdb (ORCPT ); Thu, 30 Jul 2020 22:33:31 -0400 Received: from localhost (unknown [192.168.167.235]) by regular1.263xmail.com (Postfix) with ESMTP id 2B7F9A60; Fri, 31 Jul 2020 10:33:20 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ANTISPAM-LEVEL: 2 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 Received: from [172.16.12.230] (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P14615T140283744343808S1596162798780194_; Fri, 31 Jul 2020 10:33:19 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: <4a460cbde4c5ac07331aa2d6e4c56648> X-RL-SENDER: andy.yan@rock-chips.com X-SENDER: yxj@rock-chips.com X-LOGIN-NAME: andy.yan@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 X-System-Flag: 0 Subject: Re: [PATCH v2] drm/connector: Add of_drm_find_connector To: daniel@ffwll.ch Cc: airlied@linux.ie, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20200703094506.22527-1-andy.yan@rock-chips.com> From: Andy Yan Message-ID: <3359f775-ba70-c116-e9b9-29b9ba692400@rock-chips.com> Date: Fri, 31 Jul 2020 10:33:18 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200703094506.22527-1-andy.yan@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping On 7/3/20 5:45 PM, Andy Yan wrote: > Add a function to look up a connector by > device tree node, like what of_drm_find_bridge/panel > does. > > Signed-off-by: Andy Yan > Reported-by: kernel test robot > > --- > > Changes in v2: > - Add function declaration > > drivers/gpu/drm/drm_connector.c | 33 +++++++++++++++++++++++++++++++++ > include/drm/drm_connector.h | 14 ++++++++++++++ > 2 files changed, 47 insertions(+) > > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index d877ddc6dc57..516376cd1868 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > @@ -743,6 +743,39 @@ void drm_connector_list_iter_end(struct drm_connector_list_iter *iter) > } > EXPORT_SYMBOL(drm_connector_list_iter_end); > > +#ifdef CONFIG_OF > +/** > + * of_drm_find_connector - look up a connector using a device tree node > + * @np: device tree node of the connector > + * > + * > + * Return: A pointer to the connector which match the specified device tree > + * node or NULL if no panel matching the device tree node can be found, or > + * -ENODEV: the device is not available (status != "okay" or "ok") > + */ > +struct drm_connector *of_drm_find_connector(struct drm_device *dev, const struct device_node *np) > +{ > + struct drm_connector *connector; > + struct drm_connector_list_iter conn_iter; > + > + if (!of_device_is_available(np)) > + return ERR_PTR(-ENODEV); > + > + drm_connector_list_iter_begin(dev, &conn_iter); > + drm_for_each_connector_iter(connector, &conn_iter) { > + if (connector->of_node == np) { > + drm_connector_list_iter_end(&conn_iter); > + return connector; > + } > + } > + drm_connector_list_iter_end(&conn_iter); > + > + return NULL; > +} > +EXPORT_SYMBOL(of_drm_find_connector); > +#endif > + > + > static const struct drm_prop_enum_list drm_subpixel_enum_list[] = { > { SubPixelUnknown, "Unknown" }, > { SubPixelHorizontalRGB, "Horizontal RGB" }, > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > index fd543d1db9b2..d249e0498375 100644 > --- a/include/drm/drm_connector.h > +++ b/include/drm/drm_connector.h > @@ -1129,6 +1129,9 @@ struct drm_connector { > /** @attr: sysfs attributes */ > struct device_attribute *attr; > > + /** @of_node: device tree node */ > + struct device_node *of_node; > + > /** > * @head: > * > @@ -1647,6 +1650,17 @@ void drm_connector_list_iter_end(struct drm_connector_list_iter *iter); > bool drm_connector_has_possible_encoder(struct drm_connector *connector, > struct drm_encoder *encoder); > > +#if defined(CONFIG_OF) > +struct drm_connector * > +of_drm_find_connector(struct drm_device *dev, const struct device_node *np); > +#else > +static inline struct drm_connector * > +of_drm_find_connector(struct drm_device *dev, const struct device_node *np) > +{ > + return ERR_PTR(-ENODEV); > +} > +#endif > + > /** > * drm_for_each_connector_iter - connector_list iterator macro > * @connector: &struct drm_connector pointer used as cursor