Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932279AbWEMAAu (ORCPT ); Fri, 12 May 2006 20:00:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932271AbWEMAAR (ORCPT ); Fri, 12 May 2006 20:00:17 -0400 Received: from ns.suse.de ([195.135.220.2]:7874 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S932279AbWEMAAD (ORCPT ); Fri, 12 May 2006 20:00:03 -0400 Date: Fri, 12 May 2006 16:57:45 -0700 From: Greg KH To: Linus Torvalds Cc: Russell King , James Bottomley , Erik Mouw , Or Gerlitz , linux-scsi@vger.kernel.org, axboe@suse.de, Andrew Vasquez , Linux Kernel Mailing List , Todd Blumer Subject: Re: [BUG 2.6.17-git] kmem_cache_create: duplicate cache scsi_cmd_cache Message-ID: <20060512235745.GA31148@suse.de> References: <1147456038.3769.39.camel@mulgrave.il.steeleye.com> <1147460325.3769.46.camel@mulgrave.il.steeleye.com> <20060512203850.GC17120@flint.arm.linux.org.uk> <20060512205804.GD17120@flint.arm.linux.org.uk> <20060512215151.GG17120@flint.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1739 Lines: 45 On Fri, May 12, 2006 at 03:37:59PM -0700, Linus Torvalds wrote: > > > On Fri, 12 May 2006, Linus Torvalds wrote: > > > > On Fri, 12 May 2006, Russell King wrote: > > > > > > From: Todd Blumer > > > On a PXA27x handheld (iPAQ hx4700), when we eject a mounted SD memory > > > card, we get a kernel panic (kernel trying to clean up non-existent > > > device). One hack patch to avoid the panic is: > > > > > > --- fs/partitions/check.c 10 Apr 2006 22:57:27 -0000 1.15 > > > +++ fs/partitions/check.c 4 May 2006 20:30:15 -0000 > > > @@ -491,6 +491,7 @@ > > > kfree(disk_name); > > > } > > > put_device(disk->driverfs_dev); > > > + disk->driverfs_dev = 0; /* HACK - what's the right solution? */ > > > } > > > kobject_uevent(&disk->kobj, KOBJ_REMOVE); > > > kobject_del(&disk->kobj); > > > > Btw, on the face it of, I really think that this patch is correct > > regardless of any other issues. > > .. and I suspect it also shows what the "other issues" are. > > Shouldn't that KOBJ_REMOVE uevent happen _before_ we do all the freeing of > the backing dev object? That KOBJ_REMOVE thing actually seems to want to > report the pathname for the disk it removes. Preferably before the thing > is gone and can't be reported on.. > > Ie shouldn't the diff be something like this? It looks sane to me. Russell, does it solve your oops too? thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/