Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750754AbWEMBBW (ORCPT ); Fri, 12 May 2006 21:01:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750762AbWEMBBW (ORCPT ); Fri, 12 May 2006 21:01:22 -0400 Received: from py-out-1112.google.com ([64.233.166.176]:42557 "EHLO py-out-1112.google.com") by vger.kernel.org with ESMTP id S1750754AbWEMBBW convert rfc822-to-8bit (ORCPT ); Fri, 12 May 2006 21:01:22 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=rMjsxyWIXRKlqtPzSdz7FV+3O1rsbb/140AtRUDf9iNvVoh7JTNv3Ikh+f269WoMLRqU2HodApGNn+P2Igig/qplwzNej5PzygQEFE4mjvStLd27Hh2//ozyJsSxM4/v+JZAQnE08zFppdf8NMohSugIR1SA+pg7BpZgbf/Gl8A= Message-ID: Date: Fri, 12 May 2006 18:01:21 -0700 From: "Joshua Hudson" To: "Bryan O'Sullivan" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1 of 53] ipath - fix spinlock recursion bug In-Reply-To: <9b9f24aab3505e192ed1.1147477366@eng-12.pathscale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7BIT Content-Disposition: inline References: <9b9f24aab3505e192ed1.1147477366@eng-12.pathscale.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 651 Lines: 13 On 5/12/06, Bryan O'Sullivan wrote: > The local loopback path for RC can lock the rkey table lock without > blocking interrupts. The receive interrupt path can then call > ipath_rkey_ok() and deadlock. Since the lock only protects a 64 bit read, > the lock isn't needed. Uhhh, a 64 bit read is not atomic on all architectures. Certainly not i386. Might want to verify safety of this. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/