Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 31 Jul 2020 11:00:08 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Jessica Yu <jeyu@kernel.org>
Cc:     Christoph Hellwig <hch@lst.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE
Message-ID: <20200731090008.GA12930@lst.de>
References: <20200730061027.29472-1-hch@lst.de> <20200730061027.29472-9-hch@lst.de> <20200730141232.GA31539@linux-8ccs> <20200730162957.GA22469@lst.de> <20200731085129.GA20130@linux-8ccs>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200731085129.GA20130@linux-8ccs>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jul 31, 2020 at 10:51:30AM +0200, Jessica Yu wrote:
>> +	if (mod->using_gplonly_symbols) {
>> +		pr_info("%s: module using GPL-only symbols uses symbols from proprietary module %s.\n",
>> +			mod->name, owner->name);
>
> pr_err() maybe?
>
>> +		return false;
>> +	}
>> +
>> +	if (!test_bit(TAINT_PROPRIETARY_MODULE, &mod->taints)) {
>> +		pr_info("%s: module uses symbols from proprietary module %s, inheriting taint.\n",
>> +			mod->name, owner->name);
>
> and pr_warn()? But otherwise this looks much better.

Ok with me.  Can you just fix it up, or do you want a full resend?