Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] thermal: mediatek: Fix missing selection
To:     Henry Yen <henry.yen@mediatek.com>,
        Zhang Rui <rui.zhang@intel.com>,
        Amit Kucheria <amit.kucheria@verdurent.com>,
        Matthias Brugger <matthias.bgg@gmail.com>
Cc:     linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        Steven Liu <steven.liu@mediatek.com>,
        Michael Kao <michael.kao@mediatek.com>,
        Arnd Bergmann <arnd.bergmann@linaro.org>
References: <1596096304-16422-1-git-send-email-henry.yen@mediatek.com>
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
Message-ID: <69a4b653-9f47-63f1-7eb0-4880bf19497a@linaro.org>
Date:   Fri, 31 Jul 2020 11:59:33 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1596096304-16422-1-git-send-email-henry.yen@mediatek.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Hi Henry,

cc'ing Arnd

On 30/07/2020 10:05, Henry Yen wrote:
> Mediatek thermal driver is compatible with multiple platforms.
> Some of the platforms (e.g., MT2701) requires to enable
> MEDIATEK_MT6577_AUXADC option. If lacks the config, the driver
> will not be able to read correct temperature.
> 
> To fix it, select missing MEDIATEK_MT6577_AUXADC config.

The description states there is a dependency for some platforms not all
of them.

The change will select the option every time for any mediatek platform
or compile test.

I don't think it is the place to select the option.

> Signed-off-by: Henry Yen <henry.yen@mediatek.com>
> ---
>  drivers/thermal/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 3eb2348e5242..3a37f674f7f3 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -409,6 +409,7 @@ config MTK_THERMAL
>  	depends on NVMEM || NVMEM=n
>  	depends on RESET_CONTROLLER
>  	default y
> +	select MEDIATEK_MT6577_AUXADC
>  	help
>  	  Enable this option if you want to have support for thermal management
>  	  controller present in Mediatek SoCs
> 


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog