Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Florinel Iordache <florinel.iordache@nxp.com>
To:     madalin.bucur@nxp.com, davem@davemloft.net, kuba@kernel.org,
        netdev@vger.kernel.org, Markus.Elfring@web.de
Cc:     linux-kernel@vger.kernel.org,
        Florinel Iordache <florinel.iordache@nxp.com>
Subject: [PATCH net v2 1/5] fsl/fman: use 32-bit unsigned integer
Date:   Fri, 31 Jul 2020 13:49:18 +0300
Message-Id: <1596192562-7629-2-git-send-email-florinel.iordache@nxp.com>
In-Reply-To: <1596192562-7629-1-git-send-email-florinel.iordache@nxp.com>
References: <1596192562-7629-1-git-send-email-florinel.iordache@nxp.com>
Reply-to: florinel.iordache@nxp.com
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from fsr-ub1464-128.ea.freescale.net (83.217.231.2) by AM0PR04CA0103.eurprd04.prod.outlook.com (2603:10a6:208:be::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3239.16 via Frontend Transport; Fri, 31 Jul 2020 10:49:53 +0000
X-Mailer: git-send-email 1.9.1
X-Originating-IP: [83.217.231.2]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 2e63d8d3-56fd-4845-2086-08d8353f7546
X-MS-TrafficTypeDiagnostic: AM6PR04MB5943:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <AM6PR04MB594300BDE209EDE740432E93FB4E0@AM6PR04MB5943.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: X4AsY/lp/aEM3DqP5ajNFGzYgTjfj3MFVsW+Hecz7XZDoWGhNgxtQABPFIe/NJxvvQ90jQzdOVteJ3uS0lPZtr5yWpeFpz9VAkKu9bRVH/EjB6yV1vtfO1RsUFZuv/wwt7a18cHmb2vZXlOxzC8n0EBfpQqnTaTJMci2kECJ0anv6WPdD/JDuR1e+uR/mg6u9tKgrkVTBOIZTQ9hjZnbXK4Eba6AibxZ4h2G7UkjB6CEP0SEoIEclMpn8fi8SMjtYGzWQS3y2llSzYXrHrcZkExTmUXg5BmxqvosR4L1E7o3GLhPDmc8AhDE5o2viR4mjflN2gXbn7JaVXTYW7y8Qw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB5447.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(396003)(366004)(376002)(346002)(39860400002)(3450700001)(6666004)(478600001)(83380400001)(36756003)(52116002)(2906002)(4326008)(6486002)(316002)(66946007)(66556008)(6512007)(5660300002)(8676002)(86362001)(8936002)(956004)(2616005)(186003)(16526019)(26005)(44832011)(6506007)(66476007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: VHOysgUjux84JeJHrOO2ni0jRWNoVWXQn1tHSYciin46/K5vteZExta5iGun4MW5cbIhiIXr/+J1chBHBjRB7CyL+gjRWd9jj2rrQ8hkaHFpIkfFaRKL8Sks0Smbrx2wwO+Jdg6HK3Ar8wVgS+KhgJ+HeE2xZWvh2hhdAHuyknF32HWsA3eoi1eewQN634MSh9u1ApGL8G384I977ANZtWy8EafYBMAJnmpTt2JglY12ILOgW+n+9mqz1aiFOsqDmLSZRJqMJmfEVw7yCV+ZWGoAImg0p1NAL2/Y3yrJXcUVVXjdjqN6Z0epg7+CiCWzKneGXmMXuULJbDhKbVkPEMnGgJCoHacIuDSeRYMtVEhr31whlD30LZgObXOGUlIpXOceCgQG6ZUYMuswsKub190Ezl1oU4QFKT+FGj8XIUEu0QB64XZIx4BuZ7S0jXvMv0BYg9LjKaTj8n2qT61olvJTGDOxHJMbqZaZWJZEHMU594l6G9UMo85lo/Qy3yMmIzWx3EuR7ILOJuaK8zRg4Ymw/iwZOw3MKwsM3IvDoYaMQxXxQdN7rCDE1ZuL67oZwx3q3iIwPTZTRLWDeos98vR3Sfy3D/Ws3a3n7ZvDilagZyITrEAnO+tMGVCHvmW6WGgh379A71LBhgHeDEAJDw==
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e63d8d3-56fd-4845-2086-08d8353f7546
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5447.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2020 10:49:54.1056
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C0REAXgKmkT5SeFXe5c9Qmt2q0pSeeKqogHIaj/vs7k9TdFJ9jqM/9cn4kbwdPvyE7Ly32+yBvkT4gGfgljFnFv2H2AxSvw+OCZScjQ4k/4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5943
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Potentially overflowing expression (ts_freq << 16 and intgr << 16)
declared as type u32 (32-bit unsigned) is evaluated using 32-bit
arithmetic and then used in a context that expects an expression of
type u64 (64-bit unsigned) which ultimately is used as 16-bit
unsigned by typecasting to u16. Fixed by using an unsigned 32-bit
integer since the value is truncated anyway in the end.

Fixes: 414fd46e7762 ("fsl/fman: Add FMan support")

Signed-off-by: Florinel Iordache <florinel.iordache@nxp.com>
---
 drivers/net/ethernet/freescale/fman/fman.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fman/fman.c b/drivers/net/ethernet/freescale/fman/fman.c
index f151d6e..ef67e85 100644
--- a/drivers/net/ethernet/freescale/fman/fman.c
+++ b/drivers/net/ethernet/freescale/fman/fman.c
@@ -1398,8 +1398,7 @@ static void enable_time_stamp(struct fman *fman)
 {
 	struct fman_fpm_regs __iomem *fpm_rg = fman->fpm_regs;
 	u16 fm_clk_freq = fman->state->fm_clk_freq;
-	u32 tmp, intgr, ts_freq;
-	u64 frac;
+	u32 tmp, intgr, ts_freq, frac;
 
 	ts_freq = (u32)(1 << fman->state->count1_micro_bit);
 	/* configure timestamp so that bit 8 will count 1 microsecond
-- 
1.9.1