Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp167906pxa; Fri, 31 Jul 2020 08:58:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwm42F0Nw91DizeDcSefA7yl8elXjn13y4xgHpVs8/kxKWcCkg7xch8KXH+aha1jZLXToLG X-Received: by 2002:a17:906:4f0f:: with SMTP id t15mr4509690eju.337.1596211139305; Fri, 31 Jul 2020 08:58:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596211139; cv=none; d=google.com; s=arc-20160816; b=Swsw/16XCmKa6BdW863X+rynjiCe/0yo9eMVv9JT064RYod1M3GS1EC+lCxWYV20bj 87hhcJiUwzUyyzjfWL7WQ8pXbEKApwpF6lk8phWAUAzHORz5nBbanKp+X9E7P3+Ow4qh xuQptITOicgF3ZyoPQRIO5VRSufkI25SLsk/XVS28LffYfmc9oriUl7rDXvDQdSYToOO cPipPSk7jSRkLM+wZnJP8GrREWR6HbPjXnPeH8ktGUuIAUsRvw2yhDUldkGTaLcJVIvo MQBQBCQ2CvuSXv9paJp3ZdXNRq08wuHBjK1/FowpbbVpIokpo8WmcK/tupOGZaZPfin+ rfXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=qIA+A1IQicOISdoI1qS5ziDU8HeNys9edZxS3dOJev8=; b=jG9ezB0HqxVaTOta/+vHVvsRwdW59quX0smFzARYD1sIWlOMHmBHDKZJvs+moihw16 bW99M1BDpoCEtdzXBLFBLQ6Opo/ucfEHSvNo+4dGyVSY1yUkTUdS21iarMwFzl5/BwK0 uaAT8m/AWL01OoJ9HR4Z8Ca1Xnuu6G93xMy1vokmMJeIRTVbG9NH3ss4/fBX33Sd/dOP 5cVne1brRBfJt9IOSxTQYZOwoHQ1x/OkcwmdapyjEYmo+PEwG5HcafI3s1zGQP+6P44D v/DWliQuaHrEoz6UKteH32/SZWaBbeSiKmnOQpMtqtZa3sn9Le4at8LTLDRDQhQGBUl6 vxuQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dm21si757246edb.602.2020.07.31.08.58.37; Fri, 31 Jul 2020 08:58:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387619AbgGaP6T (ORCPT + 99 others); Fri, 31 Jul 2020 11:58:19 -0400 Received: from elvis.franken.de ([193.175.24.41]:56730 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387504AbgGaP6T (ORCPT ); Fri, 31 Jul 2020 11:58:19 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1k1XQH-0000Ng-00; Fri, 31 Jul 2020 17:58:17 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 900BEC0B21; Fri, 31 Jul 2020 17:45:39 +0200 (CEST) Date: Fri, 31 Jul 2020 17:45:39 +0200 From: Thomas Bogendoerfer To: Rob Herring Cc: Jiaxun Yang , "open list:MIPS" , "linux-kernel@vger.kernel.org" , Stephen Rothwell Subject: Re: [PATCH] of_address: Guard of_bus_pci_get_flags with CONFIG_PCI Message-ID: <20200731154539.GA16683@alpha.franken.de> References: <20200730005614.32302-1-jiaxun.yang@flygoat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 31, 2020 at 08:27:55AM -0600, Rob Herring wrote: > On Wed, Jul 29, 2020 at 7:04 PM Jiaxun Yang wrote: > > > > After 2f96593ecc37 ("of_address: Add bus type match for pci ranges parser"), > > the last user of of_bus_pci_get_flags when CONFIG_PCI is disabled had gone. > > > > This caused unused function warning when compiling without CONFIG_PCI. > > Fix by guarding it with CONFIG_PCI. > > > > Signed-off-by: Jiaxun Yang > > Reported-by: Stephen Rothwell > > Fixes: 2f96593ecc37 ("of_address: Add bus type match for pci ranges parser") > > --- > > drivers/of/address.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Acked-by: Rob Herring applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]