Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH v6 09/10] media: tegra-video: Add CSI MIPI pads
 calibration
To:     Sowjanya Komatineni <skomatineni@nvidia.com>,
        thierry.reding@gmail.com, jonathanh@nvidia.com, frankc@nvidia.com,
        hverkuil@xs4all.nl, sakari.ailus@iki.fi, robh+dt@kernel.org,
        helen.koike@collabora.com
Cc:     sboyd@kernel.org, gregkh@linuxfoundation.org,
        linux-media@vger.kernel.org, devicetree@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-i2c@vger.kernel.org
References: <1596186169-18729-1-git-send-email-skomatineni@nvidia.com>
 <1596186169-18729-10-git-send-email-skomatineni@nvidia.com>
 <3ac158c4-7df7-e3c1-f0e1-33e7ef017762@gmail.com>
 <f483329d-b5fe-fda5-e235-b8edb5fce440@nvidia.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <a08af0e8-80d8-0bd0-87a3-adfc8e70a92a@gmail.com>
Date:   Fri, 31 Jul 2020 19:14:36 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <f483329d-b5fe-fda5-e235-b8edb5fce440@nvidia.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

31.07.2020 18:46, Sowjanya Komatineni пишет:
> 
> On 7/31/20 4:39 AM, Dmitry Osipenko wrote:
>> 31.07.2020 12:02, Sowjanya Komatineni пишет:
>> ...
>>> @@ -249,13 +249,47 @@ static int tegra_csi_enable_stream(struct
>>> v4l2_subdev *subdev)
>>>           return ret;
>>>       }
>>>   +    if (csi_chan->mipi) {
>>> +        ret = tegra_mipi_enable(csi_chan->mipi);
>>> +        if (ret < 0) {
>>> +            dev_err(csi->dev,
>>> +                "failed to enable MIPI pads: %d\n", ret);
>>> +            goto rpm_put;
>>> +        }
>>> +
>>> +        /*
>>> +         * CSI MIPI pads PULLUP, PULLDN and TERM impedances need to
>>> +         * be calibrated after power on.
>>> +         * So, trigger the calibration start here and results will
>>> +         * be latched and applied to the pads when link is in LP11
>>> +         * state during start of sensor streaming.
>>> +         */
>>> +        ret = tegra_mipi_start_calibration(csi_chan->mipi);
>>> +        if (ret < 0) {
>>> +            dev_err(csi->dev,
>>> +                "failed to start MIPI calibration: %d\n", ret);
>>> +            goto disable_mipi;
>>> +        }
>> What would happen if CSI stream is enabled and then immediately disabled
>> without enabling camera sensor?
> 
> Nothing will happen as during stream enable csi receiver is kept ready.
> 
> But actual capture will not happen during that point.

Could you please show how the full call chain looks like? It's not clear
to me what keeps CSI stream "ready".