Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp274952pxa; Fri, 31 Jul 2020 11:38:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwffYGItCx9FLxmPlFaxgj8nID3Cxw4rY4831+Su+gE6NiF1gHbGm1g5f0oWeCwQtAMz48U X-Received: by 2002:a50:af45:: with SMTP id g63mr5399138edd.52.1596220713951; Fri, 31 Jul 2020 11:38:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596220713; cv=none; d=google.com; s=arc-20160816; b=dPTPqutguos4QAdNgN0iVk9tl5IykxyB8rCLDyiDbCmHDf+RfEq6SKnNahQSGByzGh B3/Bqb6Ed8pZy8mbMY3BMY5Y5TcOPaHfALlGTh+m8+LT2b+eiQw6sAHqZ1tOFrhXCrBg bU9s0S1O11yvO3k1KCFrcLiHBGZ6p/GGEZivpOXgjkjfLBiAKqx4IakDA+kdOMeM5U14 nO7Ci2euB6zjBycp1xh/EjtPybwQfWi1LldRO3QuoZ0ch+6lEbecq8RURhUIHy3BhpAa 4w7VKW5drncA1zLDsxKTfi0r3qwU0J+mXZtac+X5Oio3InM9noXn5fg8KjwD5LXkhUxO DstA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:from:subject:mime-version :message-id:date:dkim-signature; bh=xWSYjHc+nNdSzqwJCR0Bklwg1NIcyWlbe0Z3kPyxnWY=; b=lH/MJ2xhPs6VrUHALdHY6Qcu4jg4DNOBzI9G5s9Pf5thclTUhuXsw9bDe6jD9GZ/Hk he1FzeD5o5IE0OjRYjXyvBgZflJ0WlVd6CeePBqmdypyY+Kh9z1nQN+9ZXiheeVJk4Qf MhAFDJzTQL+kjKmIMHj5kpJg56/UWUJN/vOrjjfbe/fmsQe9VLB7GMLV9w0xT81fb1Sn KsovZql+SCGoyZC3GRtPs4tZuTguVTIVgk2DLSAXzXdkpIuwESxyvUe7Bvqr2PHGfcRS VVlSGV6AaIs2ac5KmIDPEadpBZ+VkOWKtCg+Cy+JdPclXq10Z5MGyGO9QW4Sz739FhaL +0uQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=UHl+j2V9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m26si6446552ejn.40.2020.07.31.11.38.12; Fri, 31 Jul 2020 11:38:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=UHl+j2V9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387693AbgGaShu (ORCPT + 99 others); Fri, 31 Jul 2020 14:37:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730040AbgGaSht (ORCPT ); Fri, 31 Jul 2020 14:37:49 -0400 Received: from mail-qt1-x849.google.com (mail-qt1-x849.google.com [IPv6:2607:f8b0:4864:20::849]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D922C061574 for ; Fri, 31 Jul 2020 11:37:49 -0700 (PDT) Received: by mail-qt1-x849.google.com with SMTP id r9so21616832qtp.7 for ; Fri, 31 Jul 2020 11:37:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=xWSYjHc+nNdSzqwJCR0Bklwg1NIcyWlbe0Z3kPyxnWY=; b=UHl+j2V9dhsDIpXllhTd7jR0aoK7gz3zEDu2e8D2wo87p2jNh2PEv05B77btBa2WHg t4q9x8YrBGZ9mWVt2w/JAycC+YM363ctKxR6EZAiLJ1H2iARbDjGX7llw1Nc+VeYE9es yLcU/z3RRBx0nUqSGNv5//jg5qgnMt5Wu8m3R/7GIOqQxw0kKjBTswm1QjKpSO78MsPD 3QPrOmOcbwtKQa5BO4IsGOI0g/U7+2GEkC1glS9jR40LCLfy1gPodeZY8yYY8H+aPQMA RSRRVYFCS/Ib7J0kJ1dmF/hxt8HVvPuyhMZglgFrgZH3/I5FkvLkG/kOCu9yAgBrbpJl xHlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=xWSYjHc+nNdSzqwJCR0Bklwg1NIcyWlbe0Z3kPyxnWY=; b=Tv6wYv0GMpJEi8TP3y5qLTX0saI4gwqkH/Xud4L2YbTOaOn+H1XlLddGaTliKcwgcK nYGrs6HbjsmRG0YGhpFiYIFDiqvXG5yiAs2pwty+HAxGm5NqjLI/z0dIkgiFIscQ/0aI EGyPhhrkzUzTuTjH9q+2eXTyLnVYAlZCVaxtkclh9uBLa0ouvO5i8EOk5WJZ7SdBVDVm /74ljA68wgSfcO7mz+3vnzlt/X8GoVadiQvUY0GUeKnbs6qkTcydGiBjATVvnh3+x/fL +0Y4aEMtlVM1sgJWwPP9wb/WQHHO9b5otEJkoHak9tKv0oN6eUjb4xfY7lWc/0CB9BZa 6FfA== X-Gm-Message-State: AOAM531PMvMsXG3Irgkt2reuNOceIZlQDu7YuugzHgLIVcceNPuqbaHz cA8TMxUNGDOo414oU3Z5FBneglPBaJBHOEY= X-Received: by 2002:a0c:d44e:: with SMTP id r14mr5459448qvh.105.1596220668284; Fri, 31 Jul 2020 11:37:48 -0700 (PDT) Date: Fri, 31 Jul 2020 14:37:42 -0400 Message-Id: <20200731183745.1669355-1-ckennelly@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.28.0.163.g6104cc2f0b6-goog Subject: [PATCH 0/2 v2] Selecting Load Addresses According to p_align From: Chris Kennelly To: Alexander Viro , Alexey Dobriyan , Song Liu Cc: David Rientjes , Ian Rogers , Hugh Dickens , Andrew Morton , Suren Baghdasaryan , Sandeep Patil , Fangrui Song , Nick Desaulniers , clang-built-linux@googlegroups.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Kennelly Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The current ELF loading mechancism provides page-aligned mappings. This can lead to the program being loaded in a way unsuitable for file-backed, transparent huge pages when handling PIE executables. While specifying -z,max-page-size=0x200000 to the linker will generate suitably aligned segments for huge pages on x86_64, the executable needs to be loaded at a suitably aligned address as well. This alignment requires the binary's cooperation, as distinct segments need to be appropriately paddded to be eligible for THP. For binaries built with increased alignment, this limits the number of bits usable for ASLR, but provides some randomization over using fixed load addresses/non-PIE binaries. Changes V1 -> V2: * Added test Chris Kennelly (2): fs/binfmt_elf: Use PT_LOAD p_align values for suitable start address. Add self-test for verifying load alignment. fs/binfmt_elf.c | 24 ++++++++ tools/testing/selftests/exec/.gitignore | 1 + tools/testing/selftests/exec/Makefile | 9 ++- tools/testing/selftests/exec/load_address.c | 68 +++++++++++++++++++++ 4 files changed, 100 insertions(+), 2 deletions(-) create mode 100644 tools/testing/selftests/exec/load_address.c -- 2.28.0.163.g6104cc2f0b6-goog