Date: Sat, 13 May 2006 07:29:38 -0700
From: Andrew Morton <akpm@osdl.org>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: chrisw@sous-sol.org, linux-kernel@vger.kernel.org,
       virtualization@lists.osdl.org, xen-devel@lists.xensource.com,
       ian.pratt@xensource.com, Christian.Limpach@cl.cam.ac.uk
Subject: Re: [RFC PATCH 29/35] Add the Xen virtual console driver.
Message-Id: <20060513072938.642bf600.akpm@osdl.org>
In-Reply-To: <4465D63F.4000605@yahoo.com.au>
References: <20060509084945.373541000@sous-sol.org>
	<20060509085159.285105000@sous-sol.org>
	<20060513052757.59446e03.akpm@osdl.org>
	<4465D63F.4000605@yahoo.com.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 995
Lines: 34

Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
> Andrew Morton wrote:
> 
> >>+static void kcons_write_dom0(
> >>+	struct console *c, const char *s, unsigned int count)
> >>+{
> >>+	int rc;
> >>+
> >>+	while ((count > 0) &&
> >>+	       ((rc = HYPERVISOR_console_io(
> >>+			CONSOLEIO_write, count, (char *)s)) > 0)) {
> >>+		count -= rc;
> >>+		s += rc;
> >>+	}
> >>+}
> > 
> > 
> > must.. not.. mention.. coding.. style..
> 
> Someone should write you a script to go through a patch and flag the
> most common style mistakes. Have the output formatted to look like
> you're replying to the mail, and wire it up to your inbox ;)
> 

Even better, someone should write a coding style document, so people get it
right from the outset.

Clever, aren't I?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/