Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200702215812.428188663@goodmis.org> <20200702215832.784471709@goodmis.org>
 <20200731193345.GA54749@xps13.dannf> <20200731171626.2c51e818@oasis.local.home>
In-Reply-To: <20200731171626.2c51e818@oasis.local.home>
From:   dann frazier <dann.frazier@canonical.com>
Date:   Fri, 31 Jul 2020 15:17:20 -0600
Message-ID: <CALdTtntOjg6zdYAYJAY_87Zpf7OYB-ZTp_BSWVOJva5Vx2acPQ@mail.gmail.com>
Subject: Re: [for-next][PATCH 09/18] tracing: Move pipe reference to trace
 array instead of current_tracer
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ian May <ian.may@canonical.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jul 31, 2020 at 3:16 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Fri, 31 Jul 2020 13:33:45 -0600
> dann frazier <dann.frazier@canonical.com> wrote:
>
> > > This is marked as "Fixes" but is more of a clean up than a true fix.
> > > Backport if you want, but its not critical.
> >
> > Thanks Steven! In case it helps backport consideration, I wanted to
> > note that this addresses an issue we've seen with users trying to
> > change current_tracer when they happen to have rasdaemon
> > installed. rasdaemon uses the trace_pipe interface at runtime, which
> > therefore blocks changing the current tracer. But of course, unless
> > you know about rasdaemon internals, it isn't exactly an obvious
> > failure mode.
>
> Ah, then this should probably be backported.
>
> When I push to Linus (during the next merge window) and it gets into
> Linus's tree. Feel free to send stable@vger.kernel.org the sha1 of this
> commit, and ask for it to be backported for the above stated reason.

Will do.

 -dann