Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp391215pxa; Fri, 31 Jul 2020 15:12:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTwI0EGPVYsWz90WLcBEaPQhcIu0XnU7gNoTHEhUeyC1vdbB9lcCmtEm5+kPlcBVIaPaif X-Received: by 2002:a17:906:3842:: with SMTP id w2mr6300286ejc.273.1596233523082; Fri, 31 Jul 2020 15:12:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596233523; cv=none; d=google.com; s=arc-20160816; b=EUpZHexjSHjCmqLEB963nNlg0EGow9ndIUHieobSdH8kwTS7F0zkLnl2QrKtG417aK SRDyzuEFvZostmYd1A4JsqHWVOnxNNC874R0S+A7Lu4ysqkyU4aHgpiRWVPJCIOlguGg QcU8PWjEPug0oem5qerS/9AvmN8XrHWCkwXAhAWJqN9w9o53G6aCijbJ47a2XEwLFTQU y98JsNipO5zPa51uaJfeZRhgwAFslQCmRVLrKQnwNwjxdUIPAdn2PQtinkOL/YZGNn0g JSXMTWRLh/0FoJm3fFnWbNrrIVRxgjIDO/7ot1h10q31IImPuyEveggVr7yGZwd8PYSm D11Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=YvWlsAjNuVUwYc2aw3/VDo/0eNLBzp24zVwCj2ccybU=; b=z00s37yd5yW4MrVRlQc8VelzvTfQBv7K6V+4wDI96r+9Xzv9hCzqr+XoIXgC2eBddr bzGy9oqKvbK3XEVHgJ7805lRcTvzk4DEA9Lu2zXDdTLWWBa2TgD6+QcovpD2J28UpHdG 7yLxBYToztjyvDx2LLVobcVqojH0G0QBafbEoLaypQPfBsbNHvl9Dw7bfc4LD/5X79h6 sVzQ4Cf13g8B2IaEIiiBZ4uVeh2KDlImXYWMbQbLELupu6Pvca/to73UctHmnW5CYjMN UuNzvCSmCiBthdE8M7isjGyt+HEphmvQ/qhbCpt7RWpUhQfEeX6ockFv6ZDnPnJW+RHJ bDrA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id by9si5812378edb.241.2020.07.31.15.11.37; Fri, 31 Jul 2020 15:12:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726163AbgGaWKZ (ORCPT + 99 others); Fri, 31 Jul 2020 18:10:25 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:37418 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725767AbgGaWKZ (ORCPT ); Fri, 31 Jul 2020 18:10:25 -0400 Received: by mail-lf1-f65.google.com with SMTP id s9so17634731lfs.4; Fri, 31 Jul 2020 15:10:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=YvWlsAjNuVUwYc2aw3/VDo/0eNLBzp24zVwCj2ccybU=; b=Deu6Onj4jmihbN8pxlHBRpfzfEltJowjcu0+q5KR/fhddN90awabBNpVrIIxHaoPVE CFCOwh+raBeP3AjqyL9BFMFiBz3S1FrS4IfvW6L/aDm5BOaWD/1j7jRcZPzCdkewpCil 4HeE3RiLj6LuoU0JU2fP151FqmpaLHhHrE1ADasoSEyJXnuZLBDt0HCYqk7LaF2v8pdY jYJm3QN2k/1MvXwx+Fx72Y0bbWUWG1j/ekq7F0Vx30bOogMz8+jtE5WdKQg1m1dvwN/S 2+z52GPzkEhrLvvGAbZ9Ig9iAICXEUYkCDChrwsz8sEIWyYzwmTITpXdY+RwANoOIluG jcqQ== X-Gm-Message-State: AOAM531gO2hrGy+oVNzW1+/a20Lnmb2T+mAn63KJ7YyHqqY35NSDvbRn R6Xn8HDXsWccl+986UCyMyTKDn30MBY= X-Received: by 2002:ac2:5f48:: with SMTP id 8mr2906571lfz.157.1596233421422; Fri, 31 Jul 2020 15:10:21 -0700 (PDT) Received: from [10.68.32.192] (broadband-37-110-38-130.ip.moscow.rt.ru. [37.110.38.130]) by smtp.gmail.com with ESMTPSA id y1sm2665908lfb.45.2020.07.31.15.10.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2020 15:10:20 -0700 (PDT) Subject: Re: [PATCH] scsi: libcxgbi: use kvzalloc instead of opencoded kzalloc/vzalloc To: Joe Perches , "Martin K. Petersen" , "James E.J. Bottomley" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200731215524.14295-1-efremov@linux.com> <33d943d2b83f17371df09b5962c856ea2d894954.camel@perches.com> From: Denis Efremov Autocrypt: addr=efremov@linux.com; keydata= mQINBFsJUXwBEADDnzbOGE/X5ZdHqpK/kNmR7AY39b/rR+2Wm/VbQHV+jpGk8ZL07iOWnVe1 ZInSp3Ze+scB4ZK+y48z0YDvKUU3L85Nb31UASB2bgWIV+8tmW4kV8a2PosqIc4wp4/Qa2A/ Ip6q+bWurxOOjyJkfzt51p6Th4FTUsuoxINKRMjHrs/0y5oEc7Wt/1qk2ljmnSocg3fMxo8+ y6IxmXt5tYvt+FfBqx/1XwXuOSd0WOku+/jscYmBPwyrLdk/pMSnnld6a2Fp1zxWIKz+4VJm QEIlCTe5SO3h5sozpXeWS916VwwCuf8oov6706yC4MlmAqsQpBdoihQEA7zgh+pk10sCvviX FYM4gIcoMkKRex/NSqmeh3VmvQunEv6P+hNMKnIlZ2eJGQpz/ezwqNtV/przO95FSMOQxvQY 11TbyNxudW4FBx6K3fzKjw5dY2PrAUGfHbpI3wtVUNxSjcE6iaJHWUA+8R6FLnTXyEObRzTS fAjfiqcta+iLPdGGkYtmW1muy/v0juldH9uLfD9OfYODsWia2Ve79RB9cHSgRv4nZcGhQmP2 wFpLqskh+qlibhAAqT3RQLRsGabiTjzUkdzO1gaNlwufwqMXjZNkLYu1KpTNUegx3MNEi2p9 CmmDxWMBSMFofgrcy8PJ0jUnn9vWmtn3gz10FgTgqC7B3UvARQARAQABtCFEZW5pcyBFZnJl bW92IDxlZnJlbW92QGxpbnV4LmNvbT6JAlcEEwEIAEECGwMFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4ACGQEWIQR2VAM2ApQN8ZIP5AO1IpWwM1AwHwUCXsQtuwUJB31DPwAKCRC1IpWwM1Aw H3dQD/9E/hFd2yPwWA5cJ5jmBeQt4lBi5wUXd2+9Y0mBIn40F17Xrjebo+D8E5y6S/wqfImW nSDYaMfIIljdjmUUanR9R7Cxd/Z548Qaa4F1AtB4XN3W1L49q21h942iu0yxSLZtq9ayeja6 flCB7a+gKjHMWFDB4nRi4gEJvZN897wdJp2tAtUfErXvvxR2/ymKsIf5L0FZBnIaGpqRbfgG Slu2RSpCkvxqlLaYGeYwGODs0QR7X2i70QGeEzznN1w1MGKLOFYw6lLeO8WPi05fHzpm5pK6 mTKkpZ53YsRfWL/HY3kLZPWm1cfAxa/rKvlhom+2V8cO4UoLYOzZLNW9HCFnNxo7zHoJ1shR gYcCq8XgiJBF6jfM2RZYkOAJd6E3mVUxctosNq6av3NOdsp1Au0CYdQ6Whi13azZ81pDlJQu Hdb0ZpDzysJKhORsf0Hr0PSlYKOdHuhl8fXKYOGQxpYrWpOnjrlEORl7NHILknXDfd8mccnf 4boKIZP7FbqSLw1RSaeoCnqH4/b+ntsIGvY3oJjzbQVq7iEpIhIoQLxeklFl1xvJAOuSQwII I9S0MsOm1uoT/mwq+wCYux4wQhALxSote/EcoUxK7DIW9ra4fCCo0bzaX7XJ+dJXBWb0Ixxm yLl39M+7gnhvZyU+wkTYERp1qBe9ngjd0QTZNVi7MbkCDQRbCVF8ARAA3ITFo8OvvzQJT2cY nPR718Npm+UL6uckm0Jr0IAFdstRZ3ZLW/R9e24nfF3A8Qga3VxJdhdEOzZKBbl1nadZ9kKU nq87te0eBJu+EbcuMv6+njT4CBdwCzJnBZ7ApFpvM8CxIUyFAvaz4EZZxkfEpxaPAivR1Sa2 2x7OMWH/78laB6KsPgwxV7fir45VjQEyJZ5ac5ydG9xndFmb76upD7HhV7fnygwf/uIPOzNZ YVElGVnqTBqisFRWg9w3Bqvqb/W6prJsoh7F0/THzCzp6PwbAnXDedN388RIuHtXJ+wTsPA0 oL0H4jQ+4XuAWvghD/+RXJI5wcsAHx7QkDcbTddrhhGdGcd06qbXe2hNVgdCtaoAgpCEetW8 /a8H+lEBBD4/iD2La39sfE+dt100cKgUP9MukDvOF2fT6GimdQ8TeEd1+RjYyG9SEJpVIxj6 H3CyGjFwtIwodfediU/ygmYfKXJIDmVpVQi598apSoWYT/ltv+NXTALjyNIVvh5cLRz8YxoF sFI2VpZ5PMrr1qo+DB1AbH00b0l2W7HGetSH8gcgpc7q3kCObmDSa3aTGTkawNHzbceEJrL6 mRD6GbjU4GPD06/dTRIhQatKgE4ekv5wnxBK6v9CVKViqpn7vIxiTI9/VtTKndzdnKE6C72+ jTwSYVa1vMxJABtOSg8AEQEAAYkCPAQYAQgAJgIbDBYhBHZUAzYClA3xkg/kA7UilbAzUDAf BQJexC4MBQkHfUOQAAoJELUilbAzUDAfPYoQAJdBGd9WZIid10FCoI30QXA82SHmxWe0Xy7h r4bbZobDPc7GbTHeDIYmUF24jI15NZ/Xy9ADAL0TpEg3fNVad2eslhCwiQViWfKOGOLLMe7v zod9dwxYdGXnNRlW+YOCdFNVPMvPDr08zgzXaZ2+QJjp44HSyzxgONmHAroFcqCFUlfAqUDO T30gV5bQ8BHqvfWyEhJT+CS3JJyP8BmmSgPa0Adlp6Do+pRsOO1YNNO78SYABhMi3fEa7X37 WxL31TrNCPnIauTgZtf/KCFQJpKaakC3ffEkPhyTjEl7oOE9xccNjccZraadi+2uHV0ULA1m ycHhb817A03n1I00QwLf2wOkckdqTqRbFFI/ik69hF9hemK/BmAHpShI+z1JsYT9cSs8D7wb aF/jQVy4URensgAPkgXsRiboqOj/rTz9F5mpd/gPU/IOUPFEMoo4TInt/+dEVECHioU3RRrW EahrGMfRngbdp/mKs9aBR56ECMfFFUPyI3VJsNbgpcIJjV/0N+JdJKQpJ/4uQ2zNm0wH/RU8 CRJvEwtKemX6fp/zLI36Gvz8zJIjSBIEqCb7vdgvWarksrhmi6/Jay5zRZ03+k6YwiqgX8t7 ANwvYa1h1dQ36OiTqm1cIxRCGl4wrypOVGx3OjCar7sBLD+NkwO4RaqFvdv0xuuy4x01VnOF Message-ID: <70fb8220-2102-adb5-bbe6-9c2ea74a0623@linux.com> Date: Sat, 1 Aug 2020 01:10:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <33d943d2b83f17371df09b5962c856ea2d894954.camel@perches.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/1/20 12:58 AM, Joe Perches wrote: > On Sat, 2020-08-01 at 00:55 +0300, Denis Efremov wrote: >> Remove cxgbi_alloc_big_mem(), cxgbi_free_big_mem() functions >> and use kvzalloc/kvfree instead. > > Sensible, thanks. > >> diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c > [] >> @@ -77,9 +77,9 @@ int cxgbi_device_portmap_create(struct cxgbi_device *cdev, unsigned int base, >> { >> struct cxgbi_ports_map *pmap = &cdev->pmap; >> >> - pmap->port_csk = cxgbi_alloc_big_mem(max_conn * >> - sizeof(struct cxgbi_sock *), >> - GFP_KERNEL); >> + pmap->port_csk = kvzalloc(array_size(max_conn, >> + sizeof(struct cxgbi_sock *)), >> + GFP_KERNEL); > > missing __GFP_NOWARN > kvmalloc_node adds __GFP_NOWARN internally to kmalloc call https://elixir.bootlin.com/linux/v5.8-rc4/source/mm/util.c#L568 Thanks, Denis