Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 31 Jul 2020 19:42:20 -0300
User-Agent: K-9 Mail for Android
In-Reply-To: <20200731173520.x3edhuk73zt7tyuo@mail.google.com>
References: <20200718064826.9865-1-changbin.du@gmail.com> <20200731173520.x3edhuk73zt7tyuo@mail.google.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH v7 00/18] perf: ftrace enhancement
To:     Changbin Du <changbin.du@gmail.com>
CC:     Jiri Olsa <jolsa@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        linux-kernel@vger.kernel.org
From:   Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Message-ID: <391BF8A0-1025-478A-965E-1BB85DB87F7D@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On July 31, 2020 2:35:20 PM GMT-03:00, Changbin Du <changbin=2Edu@gmail=2E=
com> wrote:
>Hi Arnaldo,
>Are we ready to merge this serias now Thanks=2E :)


Next week I'll be in vacation, do I'll have more time for upstream stuff,

- Arnaldo


>
>On Sat, Jul 18, 2020 at 02:48:08PM +0800, Changbin Du wrote:
>> The perf has basic kernel ftrace support but lack support of most
>tracing
>> options=2E This serias is target to enhance the perf ftrace
>functionality so
>> that we can make full use of kernel ftrace with perf=2E
>>=20
>> In general, this serias be cataloged into two main changes:
>>   1) Improve usability of existing functions=2E For example, we don't
>need to type
>>      extra option to select the tracer=2E
>>   2) Add new options to support all other ftrace functions=2E
>>=20
>> Here is a glance of all ftrace functions with this serias:
>>=20
>> $ sudo perf ftrace -h
>>=20
>>  Usage: perf ftrace [<options>] [<command>]
>>     or: perf ftrace [<options>] -- <command> [<options>]
>>=20
>>     -a, --all-cpus        system-wide collection from all CPUs
>>     -C, --cpu <cpu>       list of cpus to monitor
>>     -D, --delay <n>       ms to wait before starting tracing after
>program start
>>     -F, --funcs           Show available functions to filter
>>     -G, --graph-funcs <func>
>>                           trace given functions using function_graph
>tracer
>>     -g, --nograph-funcs <func>
>>                           Set nograph filter on given functions
>>     -m, --buffer-size <size>
>>                           size of per cpu buffer
>>     -N, --notrace-funcs <func>
>>                           do not trace given functions
>>     -p, --pid <pid>       trace on existing process id
>>     -T, --trace-funcs <func>
>>                           trace given functions using function tracer
>>     -t, --tracer <tracer>
>>                           tracer to use: function or function_graph
>(This option is deprecated)
>>     -v, --verbose         be more verbose
>>         --func-opts <options>
>>                           function tracer options, available options:
>call-graph,irq-info
>>         --graph-opts <options>
>>                           graph tracer options, available options:
>nosleep-time,noirqs,verbose,thresh=3D<n>,depth=3D<n>
>>         --inherit         trace children processes
>>         --tid <tid>       trace on existing thread id (exclusive to
>--pid)
>>=20
>> v7:
>>   o add back '--tid <tid>'=2E
>> v6:
>>   o fix return value of read_tracing_file_to_stdout()=2E
>>   o make __cmd_ftrace() shorter=2E
>>   o remove option '-t, --tid <tid>'=2E
>> v5:
>>   o trivial fixes=2E
>> v4:
>>   o add util/parse-sublevel-options=2Ec
>>   O remove -D/--graph-depth
>> v3:
>>   o add --func-opts and --graph-opts to set tracer specific options=2E
>>   o support units as a suffix for option '-m/--buffer-size'=2E
>> v2:
>>   o patches for option '-u/--userstacktrace' and '--no-pager' are
>dropped=2E
>>   o update all related perf documentation=2E
>>   o rename some options=2E Now all funcgraph tracer options are
>prefixed with
>>     '--graph-', while all function tracer options are prefixed with
>'--func-'=2E
>>   o mark old options deprecated instead of removing them=2E
>>=20
>>=20
>> Changbin Du (18):
>>   perf ftrace: select function/function_graph tracer automatically
>>   perf ftrace: add option '-F/--funcs' to list available functions
>>   perf ftrace: factor out function write_tracing_file_int()
>>   perf ftrace: add option '-m/--buffer-size' to set per-cpu buffer
>size
>>   perf ftrace: show trace column header
>>   perf ftrace: add option '--inherit' to trace children processes
>>   perf: util: add general function to parse sublevel options
>>   perf ftrace: add support for tracing option 'func_stack_trace'
>>   perf ftrace: add support for trace option sleep-time
>>   perf ftrace: add support for trace option funcgraph-irqs
>>   perf ftrace: add support for tracing option 'irq-info'
>>   perf ftrace: add option 'verbose' to show more info for graph
>tracer
>>   perf ftrace: add support for trace option tracing_thresh
>>   perf: ftrace: allow set graph depth by '--graph-opts'
>>   perf ftrace: add option -D/--delay to delay tracing
>>   perf ftrace: add option --tid to filter by thread id
>>   perf: ftrace: Add set_tracing_options() to set all trace options
>>   perf ftrace: add change log
>>=20
>>  tools/perf/Documentation/perf-config=2Etxt |   5 -
>>  tools/perf/Documentation/perf-ftrace=2Etxt |  36 +-
>>  tools/perf/builtin-ftrace=2Ec              | 415
>+++++++++++++++++++++--
>>  tools/perf/util/Build                    |   1 +
>>  tools/perf/util/debug=2Ec                  |  61 +---
>>  tools/perf/util/parse-sublevel-options=2Ec |  70 ++++
>>  tools/perf/util/parse-sublevel-options=2Eh |  11 +
>>  7 files changed, 513 insertions(+), 86 deletions(-)
>>  create mode 100644 tools/perf/util/parse-sublevel-options=2Ec
>>  create mode 100644 tools/perf/util/parse-sublevel-options=2Eh
>>=20
>> --=20
>> 2=2E25=2E1
>>=20

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E