Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp506674pxa; Fri, 31 Jul 2020 19:18:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwKshSrZVGGeY8L1uzsewPIlU4jFKdq7ftOcTc6DKY1iQPs4d8jJuOWDLuEj5dxAJ75lCsE X-Received: by 2002:aa7:db08:: with SMTP id t8mr6725724eds.36.1596248331204; Fri, 31 Jul 2020 19:18:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596248331; cv=none; d=google.com; s=arc-20160816; b=ah75++kfXUrV+xYocDV2TtA9YxaYexxvhZ/ZwWS3KSaHYZnCzCd97djDfl51AdZ8R5 Bs5f9ObS/KAVntW502JiQ2vnSpc7nQXH64pGPr+9rGKKCXHS4BthSdpuIQi936vVCnVK dN3aTtINuCv5Vz2Sjib05m3gY1Y6pkg7L52lzGCv/B39jn4wDXE4I8d+Nm1fm+AlLwBk kJzmhuw2D5cfxHXqI7K6mJpwi+/2hQu0leW/zC3cd8HtG7v5tJ72r00pBP99z5LAXUzZ Xo70b3yB7zhnUv37yXgIRMQ4IFiT0/vqUI10JUBQ0CGM5rrdpOVFOevHcbb22if+54Db dP3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=551gxb/V4cTHIiiIvEHAlAkEOZo6GSnjWtQQen+5b6w=; b=q6l9zNzgzdeoQhRWsdl56qCEoDQ932+sd0PKsPNNC9fDKWqcFqUViU9uFfC9QZjy43 zvWG1KBcQS6hFS02PSOnc55vqQsKArhreorGfsR5UvEa50T/T4p8X8Z0B9sPcWfCEmlO D+YAFIjwk8pKm4GQczVZjJgrlWxqqVkqv8zPyuJVjv9r2ZuOpgfMSOz1CFT5uXBK+KxV LePsGbGxgWVlprDrzK+5zelU077dSKS/V8cXBYRH1JKZylhJlFr8T4FtwXl9/aUzgCXd qZWtbg9hPOKkaZhQDHrJFzUh2e7rHHVZOsg/NtilUBor9U3ZW/oc5W7PbfMIjg/FxRwN 1PVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=kOp5n2iZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bi26si6606504edb.161.2020.07.31.19.18.28; Fri, 31 Jul 2020 19:18:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=kOp5n2iZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727977AbgHACRW (ORCPT + 99 others); Fri, 31 Jul 2020 22:17:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727047AbgHACRV (ORCPT ); Fri, 31 Jul 2020 22:17:21 -0400 Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8CE8C06174A for ; Fri, 31 Jul 2020 19:17:21 -0700 (PDT) Received: by mail-qt1-x844.google.com with SMTP id s23so24482536qtq.12 for ; Fri, 31 Jul 2020 19:17:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=551gxb/V4cTHIiiIvEHAlAkEOZo6GSnjWtQQen+5b6w=; b=kOp5n2iZXKZcz2c1X475lqnIm8vIuCa31L9u9JzJGWOkwWQbIQLlZ+H1amAAkf7QHz XgJ44qXJ+jM3HedbEquCiofO6qhNMjEnMpuqlRXhrGPiz62cxjy+LBGVuJGGZiD5cI79 sNV/5JsZtDcTbbGvs8Xx/qDgH4VKyZTgGqM1tXIbCvO+fKPIWWCy55t6XmV+OJ/7WbID ab4tZEkFPTd1ROZ/MT0fTdfVNwA2ucD+CJ0qbNV/nyTcMshplVmt9Ic2H/yoffvBXkjT /09Eg4qld3E0biyLZHdIXHcXQOvs+NPZwv0mWR23SQWtkTsnYJIsP0PUYtD5hSB3n496 8ndQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=551gxb/V4cTHIiiIvEHAlAkEOZo6GSnjWtQQen+5b6w=; b=rUDzHUE+ZEKWC7WRyuMXLPQLArWVmzqIQrTrXpTe3Ho+47Xm61NIF9bkHRD9CEUpkt OVyh5ACrbwWweq72Y3mLgvWClAHG5VxKhrcKx0pVH0KndYypkYMxxf4E0pYrRJpBLCws 6KedVEO37pOCETGdsTkYShBW7CyGyEDA/AplqRHaCWn4eEIJhnKmNPjc2i8kFmYDnZfn h1J5+3h2EbQodI+PgWEiZgIO04cQjd1YgzciPc+ACowbRo/59QKg822U7GQW9mn3sZr3 Ua3yOAwx8EkOe3tNT1tKt0iTMl5EO+kqeXA+2WnfFjwfjefYM/t7dJkQK0Y7xcFDkD19 74AA== X-Gm-Message-State: AOAM532hXkk15B1MvNKbC421hThaOCx8VFNDUz43cPnNjnh8VeJ9T9Ie bJOLwuDaNoWm2XoU9AoW6hEo+g== X-Received: by 2002:ac8:7402:: with SMTP id p2mr6521959qtq.19.1596248240453; Fri, 31 Jul 2020 19:17:20 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 78sm11130904qke.81.2020.07.31.19.17.18 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Fri, 31 Jul 2020 19:17:19 -0700 (PDT) Date: Fri, 31 Jul 2020 19:17:05 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Roman Gushchin cc: Hugh Dickins , Andrew Morton , Johannes Weiner , Michal Hocko , Vlastimil Babka , linux-mm@kvack.org, kernel-team@fb.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: vmstat: fix /proc/sys/vm/stat_refresh generating false warnings In-Reply-To: <20200801011821.GA859734@carbon.dhcp.thefacebook.com> Message-ID: References: <20200714173920.3319063-1-guro@fb.com> <20200730162348.GA679955@carbon.dhcp.thefacebook.com> <20200801011821.GA859734@carbon.dhcp.thefacebook.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 31 Jul 2020, Roman Gushchin wrote: > On Thu, Jul 30, 2020 at 09:06:55PM -0700, Hugh Dickins wrote: > > > > Though another alternative did occur to me overnight: we could > > scrap the logged warning, and show "nr_whatever -53" as output > > from /proc/sys/vm/stat_refresh: that too would be acceptable > > to me, and you redirect to /dev/null. > > It sounds like a good idea to me. Do you want me to prepare a patch? Yes, if you like that one best, please do prepare a patch - thanks! Hugh