Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
From:   Cambda Zhu <cambda@linux.alibaba.com>
Mime-Version: 1.0 (1.0)
Subject: Re:  [PATCH] checkpatch: skip macros when finding missing switch/case break
Message-Id: <46F62293-BC9E-4428-94BD-186B0E3D3A5E@linux.alibaba.com>
Date:   Sat, 1 Aug 2020 13:03:48 +0800
Cc:     linux-kernel@vger.kernel.org
To:     Joe Perches <joe@perches.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

﻿I agree with you. Actually there are some false warnings not mentioned in my patch, such as:

case xxx: {
   if () {
       return;
   } else {
           if () {
               return;
           } else {
               return;
           }
   }
}
case xxx:
   ...

Since compiler can do this now, I think this test should be removed.

Regards,
Cambda

> 在 2020年8月1日，02:05，Joe Perches <joe@perches.com> 写道：
> 
> ﻿On Wed, 2020-07-29 at 20:59 +0800, Cambda Zhu wrote:
>> The checkpatch.pl only searches 3 previous lines when finding missing
>> switch/case break, and macros are treated as normal statements. If the
>> cases are surrounded with CONFIG, checkpatch.pl may report false
>> warnings. For example:
> 
> Likely this test should be removed altogether as
> it's never really worked well and now compilers
> find this and emit warnings.