Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp913512pxa; Sat, 1 Aug 2020 10:04:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZEOA0MFnvST3x9ZMMa4E0ind2zjA6QfRg8pnQEYVZFX4melcn3jWfFOo77epYbGS3fwT7 X-Received: by 2002:a17:906:98c1:: with SMTP id zd1mr9664138ejb.410.1596301499762; Sat, 01 Aug 2020 10:04:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596301499; cv=none; d=google.com; s=arc-20160816; b=ie8fzH8+Rq/nazuwIONygki7qUEdrpEkwifAwktCtdayYZ6xpa5R/9ww8osjsNPzK6 qPzA0L6hg4AL1Go4/kDnCqElIsjDBUIznT6tZPbM+VzA6AuhB8A0ImpA8+PfExvjQyHB 2eqA5TFxQA+du8PgXOLKMQNsJrQh9Jkj8cO66nwDl8pM/aEgaKwPhcHt79TMFIQVg93D Yes032yYEx0V9dykinLQ0b/KvUWagZiMRMV8E1ififGgFTcfLHlAfVXX5Tw208jpCBMp e4HPJq9lqC4Aa93YGWSRZqIBtqd47kkJjId4DCUNi4z91RGSlGKe+CxiBPIApyOfUt1q fNzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=gVjl1fxVk2phmm6E3dsUk+Vd8Kon2yS4EGOlu+DC8qA=; b=QR01/ZAEOv+xR2DNVfxZSGLcIWSbIjG2n8tF/Cw7SVOFZrTjxfT3ELbT8L5oj7/MIo WSYXt9LmIDpI938EEz1FmowYjkLykBxzgv4NbLtmYOsWn0bBc/rlOyXPMfVY7fbxhKD/ zt5jCmZL8QIq/GEEWkgykK2HbzPj/8wVoJjSeNVkXH/skZVpPU4uIoAWYzl2nwIc2WjE Fy2SSWcsgmvx5zy/eV/YNJ36mvDdKQlaW0ZdUz05u4iZQMXgNrb1obs3g6w8yXL235FU G5rYhHuH+W5ZyjNiFZPX7MIZVuQ50NBd9WcHksKr6FHTdBuSaGLx/0g6WoEbo9a6HTcN q5NA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=xoGV0gXl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u24si3375575edi.194.2020.08.01.10.04.37; Sat, 01 Aug 2020 10:04:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=xoGV0gXl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727883AbgHARC0 (ORCPT + 99 others); Sat, 1 Aug 2020 13:02:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727074AbgHARC0 (ORCPT ); Sat, 1 Aug 2020 13:02:26 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80220C061756 for ; Sat, 1 Aug 2020 10:02:26 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id g19so6201523plq.0 for ; Sat, 01 Aug 2020 10:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=gVjl1fxVk2phmm6E3dsUk+Vd8Kon2yS4EGOlu+DC8qA=; b=xoGV0gXlv0W7TosbAf87l0OGfBJMV7uZa+lmmZpczEuAWDna/mwq+dGD1Luj2HWsJ/ r/incAFP942ignqie8l3t+1D25tkhIb5d8rFNgEN6UNwCqrmCPk2BWTkRgJemUPcgXEH nrblQmguOw6tZ+0cylPpmFuh86sYQs665GcdjWO8/ZFXRC12pBkfvgvr505huIp73Qfb LUMQBKgXDJPzOxETWdHmlpBqvlcxtWWZhGNNzt2O088uGtZvrCDOdxKqJUQSrLVV6lcC /Od5XWQ+3r6czO9wjniVOXkVvjokqhpdjgCIxEHme4ozSQqQ/DHQrQL9NoyYHPFRV5dz 8JPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gVjl1fxVk2phmm6E3dsUk+Vd8Kon2yS4EGOlu+DC8qA=; b=ph14/kkGmqoqGKHKcwLJnPSr8h/DR8NiybKEfs6t/pcWEcl24djU0bFF4ce5UVyuaP nTokq6u1mZeuij6eHXR7Jnq3FVmXDm86ZKz0H3hkMbBgF4IG1B+ryPay9PBWLCXuWJFl YPOCGy1VM7V6ssT5OY9rie43t8mY2IkjCz6SfRJKpbbj5zZlVEntlIbN3lLTumqUpMQY 9sMFePFM54V0N8ccqp0FsHcxioRsBBi1xVQqBs4LIFpZX0coyrrMU9Hnkjz0zP5Y1JUx Wb42OUXMLqldmHG7xnN8DglnrXwYXq7QBSdWgubz9FYStl8GsjFwXw4dUiYl9YMNdVWm o1CA== X-Gm-Message-State: AOAM531zdQb2Wd/5KJ5MQxafpDNOYOZuZng2SoX7iuLDec60keoxPong Ej+UvtEkthsBh8Bwhkl58bnyObMv4+c= X-Received: by 2002:a17:902:b706:: with SMTP id d6mr8251008pls.244.1596301345796; Sat, 01 Aug 2020 10:02:25 -0700 (PDT) Received: from [192.168.1.182] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id oc4sm9226846pjb.51.2020.08.01.10.02.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Aug 2020 10:02:25 -0700 (PDT) Subject: Re: [PATCH] fs: optimise kiocb_set_rw_flags() To: Pavel Begunkov , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe Message-ID: <636faf6f-4c85-0582-2482-b99002888d0d@kernel.dk> Date: Sat, 1 Aug 2020 11:02:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/1/20 4:36 AM, Pavel Begunkov wrote: > Use a local var to collect flags in kiocb_set_rw_flags(). That spares > some memory writes and allows to replace most of the jumps with MOVEcc. I've picked this one up. -- Jens Axboe