Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200801184603.310769-1-jbi.octave@gmail.com> <20200801184603.310769-3-jbi.octave@gmail.com>
 <91c6c45f0d8ec0d031c216711cd8d7f6e9aad7ad.camel@perches.com>
In-Reply-To: <91c6c45f0d8ec0d031c216711cd8d7f6e9aad7ad.camel@perches.com>
From:   Paul Moore <paul@paul-moore.com>
Date:   Sat, 1 Aug 2020 16:26:07 -0400
Message-ID: <CAHC9VhRZ8_ZH_HZxG7coSgXo5O+G-o91wYrCv-UPK8R03OjFxg@mail.gmail.com>
Subject: Re: [PATCH 2/4] audit: uninitialize global variable audit_sig_sid
To:     Joe Perches <joe@perches.com>, Jules Irenge <jbi.octave@gmail.com>
Cc:     linux-kernel@vger.kernel.org, Eric Paris <eparis@redhat.com>,
        "moderated list:AUDIT SUBSYSTEM" <linux-audit@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Aug 1, 2020 at 2:55 PM Joe Perches <joe@perches.com> wrote:
> On Sat, 2020-08-01 at 19:46 +0100, Jules Irenge wrote:
> > Checkpatch tool reports an error at variable audit_sig_sid declaration
> []
> > diff --git a/kernel/audit.c b/kernel/audit.c
> []
> > @@ -125,7 +125,7 @@ static u32        audit_backlog_wait_time = AUDIT_BACKLOG_WAIT_TIME;
> >  /* The identity of the user shutting down the audit system. */
> >  kuid_t               audit_sig_uid = INVALID_UID;
> >  pid_t                audit_sig_pid = -1;
> > -u32          audit_sig_sid = 0;
> > +u32          audit_sig_sid;
>
> All of these are unused outside of audit.c and might as
> well be static and removed from the .h file.

There's plenty of time before the merge window closes, doing this
would definitely make this patch much more useful than the typical
checkpatch noise.

-- 
paul moore
www.paul-moore.com