Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1012663pxa; Sat, 1 Aug 2020 13:50:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwbF7QascPkCUniok0Iyuks8VCpTJ+3BS5xQQtLS89BG/iUGkJudk9URSAhWVWvpO1I1R5+ X-Received: by 2002:a17:906:5a8a:: with SMTP id l10mr9426673ejq.397.1596315015462; Sat, 01 Aug 2020 13:50:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596315015; cv=none; d=google.com; s=arc-20160816; b=OsNtXRGIK3FCp9PDIo7SaBqON+0Z9HkaRAL4m0gXx75RPVp8vuhrRpqXju9Yga/pEw kzEGSrocD+O7M1cg4Xgqqtf/4DX3Ap9UyxgKKL4NEOTyysw0hTX+2sPc0qEjThEZvHYU Lg1TpD1fUgZFJb9Twv+kkU9TW/8EgjC+xX/nfiJxPhmFG9ufnNQJqUtbQ6j8VSjOoz2h 0B3eRmWzF7vsdhjxCvyIKVFYh8249CD6scgBKAwywy+6XdGJtHfExouoTiKsFbeMAbZa XWGAliuVX2LJ31ZQuXQay3Y1ExQ598v/Qbw844BcowhYmpzyCayNeFFIX73YckQ2Zk4F Ds2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=9wKPsRsas14J6rLcc90OvGkDesVW+dImVS3IdYYGJ0U=; b=cyz+jxLxyF7mQchG+YQiTV4JJtFHKkYpMAj1aKNRFlDlPUSlhMbGTIO8UjHmyZLvRp 0qKKYtdHkfgyBAZTflMAfayPR4DXyVZg4wMkiy6LW3IaI/p8sA8ldQ2N9FWB5iw0G63T Ye2EklBmcAy3DZcH0e9Z5R6FvBiAxTCKoJRLSI3U2Bv5EDGgaSor6ui9wWExEQicC2a4 TT6tv9ubLCQdIIgeIA2W3eOb4uBFHgD5i6VRny6OoY465s/8HkjEoWH6kvkycKnwmzNT qB3yjYniocB3SmIxJ7mJhkNtdeCgffBgirc+ZgQOqUMXGzA3jTH/E5dxxn+fAp6RVDV+ 2L1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CZp4IJOw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s4si7808894edc.555.2020.08.01.13.49.53; Sat, 01 Aug 2020 13:50:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CZp4IJOw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726946AbgHAUsu (ORCPT + 99 others); Sat, 1 Aug 2020 16:48:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725883AbgHAUst (ORCPT ); Sat, 1 Aug 2020 16:48:49 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD96EC06174A; Sat, 1 Aug 2020 13:48:49 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id f9so9364163pju.4; Sat, 01 Aug 2020 13:48:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=9wKPsRsas14J6rLcc90OvGkDesVW+dImVS3IdYYGJ0U=; b=CZp4IJOwaIO2gFQtha1lV1lYM+vm6IJnhuBrWQSjkDIFQDCKBnMy/mSL9Z2SF2WL7E VKXTFmC9lWNFNnsIvNp1itXadVnbCLjCM7QMuPhs1Q1mkwZblGqsHt6fB/1BdcTYIGoL 0QDA4+hWjuyCW/rRX/nqUX6GKkuUGHR0fkVYwaFfBoDdBdke3QLiwKmWH1HT6j/ipLVr kUDTft262j/6oGKJBOK8xk12jjRSSw+sHHeFFKqdjLkYKeZANU9GjZuSqojol68oxiYa 7ZVyFaUt6tPuvIqH/eusCYAhbcOLWYNisw66g2TyHWrkD12gBYZBqxzfEeN7OKynjSyf JaIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9wKPsRsas14J6rLcc90OvGkDesVW+dImVS3IdYYGJ0U=; b=U7irdd79GVFy8+Of30QDd2yv42HahIodAIcAN+s+zS/I3NUNouEhLTEdMiEuRNRk0G iMom55bGLbTjWuKQiS5fkTUc6JCJXtIU/QE/OhyA3v66656qOuWNqZ0KUqkLtECFj6Yb lnOR7th2nFbWpQBHbtv9rDAzWgL4pNTcjxK+YaJc8EokWN33cYSIkPxHDxR7jP6FyOEZ gH7KA9btjl7QjAh1IkXK5Xxj3HevLJA1Dc5n8aIcgO4LyGdVGhGy7THnfEYPv8sRz04S jRbKySJ3btZ1RCtK7T1pM5cj/oO2P9zAoRI9pZei1KTfbm8H6KHr3BupYWsHpc485MDz KIDQ== X-Gm-Message-State: AOAM530iNDmkCsXMWJYIUUgt5LHaIrP5qiIBKTkTUTgsFRhdD9mWIkMW KBuFpEn9+P8Rh1LP9qWITd9bkzp3 X-Received: by 2002:a17:90a:eb98:: with SMTP id o24mr9098627pjy.150.1596314928450; Sat, 01 Aug 2020 13:48:48 -0700 (PDT) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id j142sm15011790pfd.100.2020.08.01.13.48.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Aug 2020 13:48:47 -0700 (PDT) Subject: Re: [PATCH net-next v3 1/2] net: dsa: qca8k: Add define for port VID To: Jonathan McDowell , Andrew Lunn , Vivien Didelot , Vladimir Oltean , David Miller , Jakub Kicinski , Russell King - ARM Linux admin , Matthew Hagan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200721171624.GK23489@earth.li> <08fd70c48668544408bdb7932ef23e13d1080ad1.1596301468.git.noodles@earth.li> From: Florian Fainelli Message-ID: Date: Sat, 1 Aug 2020 13:48:46 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <08fd70c48668544408bdb7932ef23e13d1080ad1.1596301468.git.noodles@earth.li> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/1/2020 10:05 AM, Jonathan McDowell wrote: > Rather than using a magic value of 1 when configuring the port VIDs add > a QCA8K_PORT_VID_DEF define and use that instead. Also fix up the > bitmask in the process; the top 4 bits are reserved so this wasn't a > problem, but only masking 12 bits is the correct approach. > > Signed-off-by: Jonathan McDowell Reviewed-by: Florian Fainelli -- Florian