Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Message-ID: <trinity-2bdb3521-256a-4d4d-928a-be9b8c179d4c-1596355539029@3c-app-gmx-bs58>
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc:     Chun-Kuang Hu <chunkuang.hu@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        David Airlie <airlied@linux.ie>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        DRI Development <dri-devel@lists.freedesktop.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        Daniel Vetter <daniel@ffwll.ch>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Bibby Hsieh <bibby.hsieh@mediatek.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Aw: Re: [PATCH v2 1/5] drm/mediatek: config component output by
 device node port
Content-Type: text/plain; charset=UTF-8
Date:   Sun, 2 Aug 2020 10:05:39 +0200
Importance: normal
Sensitivity: Normal
In-Reply-To: <CAAOTY_8nm0KDHFzOX9+qTTHOUd0Vik063J+rScu_y-hTBTkrCQ@mail.gmail.com>
References: <20200728111800.77641-1-frank-w@public-files.de>
 <20200728111800.77641-2-frank-w@public-files.de>
 <CAAOTY_8nm0KDHFzOX9+qTTHOUd0Vik063J+rScu_y-hTBTkrCQ@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> Gesendet: Sonntag, 02. August 2020 um 02:03 Uhr
> Von: "Chun-Kuang Hu" <chunkuang.hu@kernel.org>
> An: "Frank Wunderlich" <frank-w@public-files.de>
> Cc: "Chun-Kuang Hu" <chunkuang.hu@kernel.org>, "Philipp Zabel" <p.zabel@=
pengutronix.de>, "David Airlie" <airlied@linux.ie>, "linux-kernel" <linux-=
kernel@vger.kernel.org>, "DRI Development" <dri-devel@lists.freedesktop.or=
g>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@lists.infrad=
ead.org>, "Daniel Vetter" <daniel@ffwll.ch>, "Matthias Brugger" <matthias.=
bgg@gmail.com>, "Bibby Hsieh" <bibby.hsieh@mediatek.com>, "Linux ARM" <lin=
ux-arm-kernel@lists.infradead.org>
> Betreff: Re: [PATCH v2 1/5] drm/mediatek: config component output by dev=
ice node port
> > +
> > +               if (comp_type !=3D MTK_DSI && comp_type !=3D MTK_DPI) =
{
> > +                       port =3D of_graph_get_port_by_id(node, 0);
> > +                       if (!port)
> > +                               continue;
> > +                       ep =3D of_get_child_by_name(port, "endpoint");
> > +                       of_node_put(port);
> > +                       if (!ep)
> > +                               continue;
> > +                       remote =3D of_graph_get_remote_port_parent(ep)=
;
> > +                       of_node_put(ep);
> > +                       if (!remote)
> > +                               continue;
> > +                       of_id =3D of_match_node(mtk_ddp_comp_dt_ids, r=
emote);
> > +                       if (!of_id)
> > +                               continue;
> > +                       comp_type =3D (enum mtk_ddp_comp_type)of_id->d=
ata;
> > +                       for (i =3D 0; i < private->data->main_len - 1;=
 i++)
> > +                               if (private->data->main_path[i] =3D=3D=
 comp_id)
> > +                                       private->data->main_path[i + 1=
] =3D
> > +                                       mtk_ddp_comp_get_id(node, comp=
_type);
> > +                       for (i =3D 0; i < private->data->ext_len - 1; =
i++)
> > +                               if (private->data->ext_path[i] =3D=3D =
comp_id)
> > +                                       private->data->ext_path[i + 1]=
 =3D
> > +                                       mtk_ddp_comp_get_id(node, comp=
_type);
> > +               }
>
> The port property is not defined in binding document [1], so define it
> in binding document first.
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/t=
ree/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt?h=
=3Dv5.8-rc7

hi,
would be the following enough for describing the ports?

Port binding
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

some nodes like

- connector (e.g. hdmi-connector)
- bls (mediatek,mt7623-disp-pwm)
- hdmix (mediatek,mt7623-hdmi)

can have port bindings to connect each other. Each port can have only 1 en=
dpoint

more detail about ports/endpoints in ../../media/video-interfaces.txt
hdmi-connector is described here: ../connector/hdmi-connector.txt

example:

connector {
	compatible =3D "hdmi-connector";

	port {
		hdmi_connector_in: endpoint {
			remote-endpoint =3D <&hdmi0_out>;
		};
	};
};


&bls {
	status =3D "okay";

	port {
		bls_out: endpoint {
			remote-endpoint =3D <&dpi0_in>;
		};
	};
};

&dpi0 {
	status =3D "okay";

	ports {
		#address-cells =3D <1>;
		#size-cells =3D <0>;
		port@0 {
			reg =3D <0>;
			dpi0_out: endpoint {
				remote-endpoint =3D <&hdmi0_in>;
			};
		};

		port@1 {
			reg =3D <1>;
			dpi0_in: endpoint {
				remote-endpoint =3D <&bls_out>;
			};
		};
	};
};

&hdmi0 {

	ports {
		#address-cells =3D <1>;
		#size-cells =3D <0>;
		port@0 {
			reg =3D <0>;
			hdmi0_in: endpoint {
				remote-endpoint =3D <&dpi0_out>;
			};
		};

		port@1 {
			reg =3D <1>;
			hdmi0_out: endpoint {
				remote-endpoint =3D <&hdmi_connector_in>;
			};
		};
	};
};

regards Frank