Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1431445pxa; Sun, 2 Aug 2020 07:26:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwm6yMZ1hlDa6NSgGRi+mlc/o1o9bgvbh4bJQOUcgODCqKgJaoNBF7hl3Jm4vIYET73wCl X-Received: by 2002:a05:6402:1764:: with SMTP id da4mr12234677edb.187.1596378402877; Sun, 02 Aug 2020 07:26:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596378402; cv=none; d=google.com; s=arc-20160816; b=EpKvTwBfViczN1fNBcYfDO4F7yHXTxmO7dd6mEQwu0wUCMvw2p8NKW4467lVs95pxL z3u1k2Ln6ydFZs7Tan9fjYOHh2M0f3jpCd/3VkgwVOw9zvTDwT6Rd/rY8C+P5nGdjkxy TfwaxuzzpESNVWsVULa+tbhiLItWt12qexEnkA/7FznX3nn9VZfE121aNSpf0H9TvEzm vlu45dxTgJx0A94ri7uYMLtMa47pV+TsTdGObos0VjUOale1sK9k+U9/vk3WMoREr/Gj LEwTPeDsPIpR/s0EeU6g8BmYlrBoTD4av3Gzl8T21NCth/nOQGl4Amrf/ecLXrI/fsF6 dEVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=2/kHNXwW/Okw1oeFagoA94XTuvPYMO2ieikygdNu33E=; b=KmbzWPlDkyMKaECr+P87svCH6aPq0fzfF8v1NlzR5QmV85Qo4+wWRTkEUOFIKTwaqT l2bYmieH56fcjeKxsuQmCrmIHRuY1b7CAuAUdsHletOZTKYriUqE/BjWhEqJV/zdnilB AO+nPLU2PTyDxlHD7lYJrpXk7dih+sMSVtW4RKUqaor2dWBUt/K4NJrmY6oUFtM0Ona1 UR0WxNqTjuLGBo8yWJ/MRlgk1WEZiBh6jC4qyY5rW6FBuTv+/xRRxltAv9nYHEJQYnXu HJ4cJpsw0AXvR/GCUdJwJ1WvBIszo5i46CyvqXNMi44VVb/YZPpZibvbZJyRlXyA7AV5 sKqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Erj3Mq7s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a18si4041763ejr.616.2020.08.02.07.26.20; Sun, 02 Aug 2020 07:26:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Erj3Mq7s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726222AbgHBOXu (ORCPT + 99 others); Sun, 2 Aug 2020 10:23:50 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:26934 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725780AbgHBOXt (ORCPT ); Sun, 2 Aug 2020 10:23:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596378228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=2/kHNXwW/Okw1oeFagoA94XTuvPYMO2ieikygdNu33E=; b=Erj3Mq7sCoAsePSyM9uTtcVGmZNB5aknHoaeFRYUiebTKHGbxts3am1Ntp8osMpsmQ+BAV eYbAqbXculULk14YwXtmT/BErUb2rWz9pQp16OaXUnlWxHM0QtCIzUV0l0UOd1+egC0Lwg Hc9R6W3oFNb4b2HaP+4AgvLqli3gOmo= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-257-96u3dJ5bPJGxpffmzPcAag-1; Sun, 02 Aug 2020 10:23:46 -0400 X-MC-Unique: 96u3dJ5bPJGxpffmzPcAag-1 Received: by mail-qv1-f72.google.com with SMTP id l18so5879778qvq.16 for ; Sun, 02 Aug 2020 07:23:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2/kHNXwW/Okw1oeFagoA94XTuvPYMO2ieikygdNu33E=; b=ufzSnXN3+46Ij3TZApm/4yV4lYKrrPiPV18Dw0sjW+lxBDzpAURjM9FM9LnIjyR0KR 4cT13uz9G+n9gq1T5yUz8FcFwO142oyaXznp3PsEVd62l4u0M0UGZT42667MHzHBDm8D ReFT+mP1oFIsHIkGzewIRg7XGtBcCAqmzLfiEfuzEb5PsTwzOoXAsNWZyojppMt7c40i 38N+c8kc0gEVzYiIoRZUjtzfVtaMU8NltPumNlWpuajgHMBiiW0HBMi7JjSQ9ys0JHwA 1jh/7k4pP5P+uzGYsgdH+xHoNWehGWUarz2OSkL6Hb54QCpoqqmGPsbZGU478AmJG1BQ GFsw== X-Gm-Message-State: AOAM530t5B7H3k/aCQzqgngybAhHHOokutHKv3hPyQjvX4kuXwD/J0q1 iURuziWPxWMl3dDf0+zdZpJzU5nsQl69KWlav/BvcR71Hv51RmIt6dXiFArlHC93xWt+mW8t8br 3759UIpk1UXIkNyoGVzPguTW3 X-Received: by 2002:a37:62cc:: with SMTP id w195mr12855863qkb.33.1596378226336; Sun, 02 Aug 2020 07:23:46 -0700 (PDT) X-Received: by 2002:a37:62cc:: with SMTP id w195mr12855832qkb.33.1596378226027; Sun, 02 Aug 2020 07:23:46 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id g61sm18050245qtd.65.2020.08.02.07.23.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2020 07:23:45 -0700 (PDT) From: trix@redhat.com To: michael.hennerich@analog.com, alex.aring@gmail.com, stefan@datenfreihafen.org, davem@davemloft.net, kuba@kernel.org, marcel@holtmann.org Cc: linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] ieee802154/adf7242: check status of adf7242_read_reg Date: Sun, 2 Aug 2020 07:23:39 -0700 Message-Id: <20200802142339.21091-1-trix@redhat.com> X-Mailer: git-send-email 2.18.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tom Rix Clang static analysis reports this error adf7242.c:887:6: warning: Assigned value is garbage or undefined len = len_u8; ^ ~~~~~~ len_u8 is set in adf7242_read_reg(lp, 0, &len_u8); When this call fails, len_u8 is not set. So check the return code. Fixes: 7302b9d90117 ("ieee802154/adf7242: Driver for ADF7242 MAC IEEE802154") Signed-off-by: Tom Rix --- drivers/net/ieee802154/adf7242.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c index c11f32f644db..7db9cbd0f5de 100644 --- a/drivers/net/ieee802154/adf7242.c +++ b/drivers/net/ieee802154/adf7242.c @@ -882,7 +882,9 @@ static int adf7242_rx(struct adf7242_local *lp) int ret; u8 lqi, len_u8, *data; - adf7242_read_reg(lp, 0, &len_u8); + ret = adf7242_read_reg(lp, 0, &len_u8); + if (ret) + return ret; len = len_u8; -- 2.18.1