Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1446475pxa; Sun, 2 Aug 2020 08:00:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwM5nP/D1/qCrTwXgdy6v1mve9+1WamDBUY8eqiLi706FeGo8YUsmi/KxXat2EZj8uJH+OT X-Received: by 2002:aa7:da0e:: with SMTP id r14mr12245270eds.236.1596380453409; Sun, 02 Aug 2020 08:00:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596380453; cv=none; d=google.com; s=arc-20160816; b=gM/Gd4/7h8nKSm5xQiZq8C4U/l1ZEUNEPvvWKumLPZVD8emZCcSqMn9OFhneZeb8qg np6SJKEpYDdlLcYkIOyp8Okd2QvgxhfXadgKZrAe3cAdNCTAc3taoRuRYnZNudv2muwM iEsDjYqPy3Mj+oKMUz26IuvfFWxPNDO83sPnezpxevDSPRLhiWrxBrWs8mMmUnAWtCj4 e8ccq/W5zxHiypW8DQZnek4DyQmCbwu3uee9wVstMN7N5vK+VvzHNeKNze2XPvf11xt6 SoTuQaamcORRVxUiKGAupf28K3pBHhP95d+5RIzo1yJbRt6Yr4T4usbZR/zPpjIeQiB4 hwoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=BKtA1y2+cg1n0Oxr+QAJxIgbuRnTbM/9xV3TLuWzV9E=; b=qGLoHw934MAbSmpx1K87PtIyxkAB2sRoLsORfTEjDlNltjBkvZRrurRTwAPN74mLMA 2E4Ab8iesDwm64uvLsXgoCqg7ZTmytP8FasAhqrOmT2XPZ6fsWfcZQvjgC3cDkBAe6MO cOksneKI7lzDLeFzHJobQPfkfntl95YgspFX+2UpRnI2OvFg/gT9SnHXpioxfHH4fUMX 52+UE/qH5gZESNsOWCPigl/Ci8Ae6edeM3GLwjybWL5zWmQO15dzG3upqkQTOeDzmX+z cRojgO2owW/m6tF93Y5GL5yiO01SLK+Xuc/Ah51MU4bF02hLWA3IZeW+EQwSEq2aBIq9 A5bg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=FHsEHe8n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x4si9062667edv.40.2020.08.02.08.00.31; Sun, 02 Aug 2020 08:00:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=FHsEHe8n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726787AbgHBO7X (ORCPT + 99 others); Sun, 2 Aug 2020 10:59:23 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:17966 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726041AbgHBO7W (ORCPT ); Sun, 2 Aug 2020 10:59:22 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1596380361; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=BKtA1y2+cg1n0Oxr+QAJxIgbuRnTbM/9xV3TLuWzV9E=; b=FHsEHe8nsUbuoai5+llKsA+IyBVDI+NVf6qKsUHqm9j5kfAVk13JHddgpuuJQ01lkcO2Htik p2gw+Ppjw78/GlCYpBRrwtKvn84ZuToKWLZFA3m5Q5U/F6PH42V8zHG6ZGSjnyDlLNnZpNfD gstoV4heWQ4nwtLUxSB/K3/q1e4= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 5f26d4c621feae908b0648e6 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sun, 02 Aug 2020 14:59:18 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 0818CC43395; Sun, 2 Aug 2020 14:59:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 61ABAC433C9; Sun, 2 Aug 2020 14:59:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 61ABAC433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v1] prism54: islpci_hotplug: use generic power management From: Kalle Valo In-Reply-To: <20200721125514.145607-1-vaibhavgupta40@gmail.com> References: <20200721125514.145607-1-vaibhavgupta40@gmail.com> To: Vaibhav Gupta Cc: Bjorn Helgaas , Bjorn Helgaas , Bjorn Helgaas , Vaibhav Gupta , "David S. Miller" , Jakub Kicinski , Luis Chamberlain , Vaibhav Gupta , linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Shuah Khan , netdev@vger.kernel.org, linux-wireless@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200802145918.0818CC43395@smtp.codeaurora.org> Date: Sun, 2 Aug 2020 14:59:18 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vaibhav Gupta wrote: > Drivers using legacy power management .suspen()/.resume() callbacks > have to manage PCI states and device's PM states themselves. They also > need to take care of standard configuration registers. > > Switch to generic power management framework using a single > "struct dev_pm_ops" variable to take the unnecessary load from the driver. > This also avoids the need for the driver to directly call most of the PCI > helper functions and device power state control functions as through > the generic framework, PCI Core takes care of the necessary operations, > and drivers are required to do only device-specific jobs. > > Signed-off-by: Vaibhav Gupta Patch applied to wireless-drivers-next.git, thanks. 81cf72b74671 prism54: islpci_hotplug: use generic power management -- https://patchwork.kernel.org/patch/11675653/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches