Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1463043pxa; Sun, 2 Aug 2020 08:31:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwSahLQ3uLoe0PLTUCgOWatLmRnehT1p1V5Tzc8ElH+EN42958QTvFVVNL9mEb/lcvLb/m X-Received: by 2002:a17:906:1604:: with SMTP id m4mr2122919ejd.6.1596382267630; Sun, 02 Aug 2020 08:31:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596382267; cv=none; d=google.com; s=arc-20160816; b=N0zUYFenwoG9qICj0TiI0AH5bpm2LydTaXVWXLxKWt7sQkgLqsScabVcCCYR//nrb+ XMpseqh3UYptcRM83lurV9uVTQ7Fb1jMpL1iCVPqqgJ2RrBB0kEyO2bgzRUchKjM5QGM v8LJbeVo+Q09BTIaZ1PpR/SIuPCDm4SQvpNazGWc8nSEcNdmaRWE06Y+GFmlWQlEtlSK F944g56FpkniPt42JobRhku82H+1koc5K0BwLwKh7IqjNndU+9f4lCNqftS0JC4R/CS6 UrjfQxVB2yx7liKfhIpjMPbyVd3amtl300+1lDbm5kyW3SCCqe2wAoBLjne5UZ7NjG0d jDig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=A+g2QS0HdfByZolMx/cDo4EMXXNg/jBWqy9XDQ2JidY=; b=vNsORPEI8qWIkLgjvF7D14HU07PztjYhTxtTmDgr0rZe0CpglER6g/g8vW0joMOfV7 OcrURHAzF0crWYElE2rqwxLfRioFLNuH5jSXRN7DIrDMcJCfYyHKngt0yDfmyPwlpAgn 82TPSCyrodt7RyfylemWESNFny9LRCKrJ9YghajQTuOKDoxGFsIxYB4PBx5ksPy69TqI 3P5NkvASPZvWMhOkRin5ao/fsumzwpepqHrY4L3R3ib8IBz2nGRB49hYEhqaYv09oJ4X SbSuFnsOQA8Eb1J4CPXFDq00Pj42fi+5GMRKeBCDbTZIhC9rQUgcer9IZMmqBUf33+FL r5+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=n62munwO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jx1si8804593ejb.520.2020.08.02.08.30.45; Sun, 02 Aug 2020 08:31:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=n62munwO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726764AbgHBPaP (ORCPT + 99 others); Sun, 2 Aug 2020 11:30:15 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:49327 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725968AbgHBPaP (ORCPT ); Sun, 2 Aug 2020 11:30:15 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1596382214; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=A+g2QS0HdfByZolMx/cDo4EMXXNg/jBWqy9XDQ2JidY=; b=n62munwOVvuZCpl3EsjA62hRT37oEAu+rhIqlCgB9ZXsmOgDJKbs5aawOmee6V4bRfIRXCML QoSrP0pQ0qwmE4rBhY0J8VNcHlpv1tHn0uUlNyXXucaSdh7OgkeFvlRieCF7lWc23QEjgTeQ sX2LPopJ3M3NmQm/tfTokyuA+iI= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n14.prod.us-east-1.postgun.com with SMTP id 5f26dbf09403087e1001c11e (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sun, 02 Aug 2020 15:29:52 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 3F2C4C433C6; Sun, 2 Aug 2020 15:29:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 84F2AC433C6; Sun, 2 Aug 2020 15:29:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 84F2AC433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH net-next] brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach From: Kalle Valo In-Reply-To: <1595237765-66238-1-git-send-email-wangyufen@huawei.com> References: <1595237765-66238-1-git-send-email-wangyufen@huawei.com> To: Wang Yufen Cc: , , , , , , , , Wang Yufen User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200802152951.3F2C4C433C6@smtp.codeaurora.org> Date: Sun, 2 Aug 2020 15:29:51 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wang Yufen wrote: > When brcmf_proto_msgbuf_attach fail and msgbuf->txflow_wq != NULL, > we should destroy the workqueue. > > Fixes: 05491d2ccf20 ("brcm80211: move under broadcom vendor directory") Moving the driver to another directory cannot have caused this bug, so I'm removing the fixes tag. Please check your commit logs, don't just blindly copy what git-blame says. -- https://patchwork.kernel.org/patch/11673291/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches