Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1536822pxa; Sun, 2 Aug 2020 11:05:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyHbRvpz1PAOaPVQjwYw390NSB+0sZdzybOgzW5+9dz/FJSduU2KLA5vciXID20AsGJX803 X-Received: by 2002:aa7:d155:: with SMTP id r21mr11970048edo.87.1596391531557; Sun, 02 Aug 2020 11:05:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596391531; cv=none; d=google.com; s=arc-20160816; b=zFu5yN1aYG4Qx2Y5OU9IwtkT+sDmTk2Ig1HXwCTf400+5soHsjWWlKobbLj31VCFor zvMSCC+FnHGLOge5VusJMTRnZUC0S/0C3xLyO6KiLpEg9fW0invBN1fGf+tDiqzcGT3d UHQENcceenFXiiSB6t9aMtXZLbW5IA71k2wWFpwdRKpxaxXzhPZZXkc/8tBzIHMZymof kaJTSbdx8ZpKcnFnGiqNWme+Vmu2xFr1jgGD3/cDzS6U+rRsv3Jhs3oWbXdi4EjZ3cV4 s+aPWFG153f0OQzEsvH9NcA7SSvpw3K/XfhoVmjn+h4Ae7yt8/NEkuf5/jJRaNPhfhPv iDFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=hIidJgHuEfm+QUxSjJcyWhB4lu2Xjl7LW3yKbJJeIh0=; b=aBqwjKSPprNpxwhijbJBk0IWDCDRfuYIyvcWOVx2l1Su6U9eKe+T44NgW8kMiZ+u/Y EaaFirivBGUhN3t7u/rRKU6R4xd7yWleBsp+lXWBasgkSbpDR9he2nXhDeg9vJlwzVzs IO3rFBdRbcaAPK2CmkXsG3qHSpT/0+fWaMTNIYjXXmDT0oonx5en9RwhnyBzLCrWNRJP VmQH6/DbJlo/IvhsuQb4mCZx9UiGeoGWajIgRIuJoaJAnqyRF6nU0f094vpzZPXna0C3 58+0cnGYsMMTt7qQcjEoaFR9MKXT+HRqoyz/9NXErtFw3Ynt0cbHsVyWLM2irML2ZLAP PSdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="uIs7/vU9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id us11si6025890ejb.699.2020.08.02.11.05.09; Sun, 02 Aug 2020 11:05:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="uIs7/vU9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727828AbgHBSC3 (ORCPT + 99 others); Sun, 2 Aug 2020 14:02:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725906AbgHBSC2 (ORCPT ); Sun, 2 Aug 2020 14:02:28 -0400 Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16C94C06174A; Sun, 2 Aug 2020 11:02:28 -0700 (PDT) Received: by mail-ed1-x542.google.com with SMTP id c15so16010048edj.3; Sun, 02 Aug 2020 11:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hIidJgHuEfm+QUxSjJcyWhB4lu2Xjl7LW3yKbJJeIh0=; b=uIs7/vU9Kx/pklkEtgD7hBiuHs6a0R+dGlNTjUGRPw721sRkbKusjxGi7PfHcXOJ+P EjAE8Vd54opYw74GdBkeR4XNF5IP2MPUk9fmgk6V6Ahfe99oRVQ2eTOjx4V/HNnjxo1p 8JTL4om9ZC3cnlFf7IvLus1+6HB/iVpPvgkNBuxCV3vkFTVqsYvmHOwMCmyNnjJul9R4 NyUbZELRb/+vAfU647duOFbumJn5NHcHvq2jBsmvofhPXlaOdyNnECGIYrfm3l1GH6Kt lYQels7sHnZLCY218xDI/G+/wAKH/pz8dPVH6DrvKapbnVTrwoCPcuTqLRUxp8GcwS18 4m4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=hIidJgHuEfm+QUxSjJcyWhB4lu2Xjl7LW3yKbJJeIh0=; b=JP5m+gLpa0w+fNX6l3aEOLFr8Ii/uIV3PUZ4/5bKR3YeO7pwsyfBmeViSDCok/+kG1 xm97vjhdI+V0/negVVfjxZuYq1c8879Xb2VeBpR+hrCCTvNeH6O9782XtDfeGiUAIPIK 0v7cukw3uu3SgstdDD+mWwglE455DQYF0VtjoaK07wSvp6V+AVl0SVYMwPx5uS9WweUi cn5fA1u4pmuC4rlnttzEZlceYNHPKimkLXeVm3JYg/EkZGighzhVpej+mBSQbUFdY6ph hZG9hfk4d9mUwB/VrOdVpCBPjqAUMl6J40phkoUKwXkAwCbOTh4brJZFBinYrgcnR1qz SXZQ== X-Gm-Message-State: AOAM532fVmUo+auDPMb5/10Y7gnxzH/iAxO7yYRvAMRNgSwUvDnyMlp5 8LITHijlxIkRW0ozROc+yVw= X-Received: by 2002:aa7:cb15:: with SMTP id s21mr12929126edt.175.1596391346876; Sun, 02 Aug 2020 11:02:26 -0700 (PDT) Received: from gmail.com (54033286.catv.pool.telekom.hu. [84.3.50.134]) by smtp.gmail.com with ESMTPSA id j21sm14090092edq.20.2020.08.02.11.02.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2020 11:02:26 -0700 (PDT) Date: Sun, 2 Aug 2020 20:02:23 +0200 From: Ingo Molnar To: Mike Rapoport Cc: Andrew Morton , Andy Lutomirski , Baoquan He , Benjamin Herrenschmidt , Borislav Petkov , Catalin Marinas , Christoph Hellwig , Dave Hansen , Emil Renner Berthing , Ingo Molnar , Hari Bathini , Marek Szyprowski , Max Filippov , Michael Ellerman , Michal Simek , Mike Rapoport , Palmer Dabbelt , Paul Mackerras , Paul Walmsley , Peter Zijlstra , Russell King , Stafford Horne , Thomas Gleixner , Will Deacon , Yoshinori Sato , clang-built-linux@googlegroups.com, iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp, x86@kernel.org Subject: Re: [PATCH v2 14/17] x86/setup: simplify reserve_crashkernel() Message-ID: <20200802180223.GB86614@gmail.com> References: <20200802163601.8189-1-rppt@kernel.org> <20200802163601.8189-15-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200802163601.8189-15-rppt@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Mike Rapoport wrote: > From: Mike Rapoport > > * Replace magic numbers with defines > * Replace memblock_find_in_range() + memblock_reserve() with > memblock_phys_alloc_range() > * Stop checking for low memory size in reserve_crashkernel_low(). The > allocation from limited range will anyway fail if there is no enough > memory, so there is no need for extra traversal of memblock.memory > > Signed-off-by: Mike Rapoport Assuming that this got or will get tested with a crash kernel: Acked-by: Ingo Molnar Thanks, Ingo