Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200728111800.77641-1-frank-w@public-files.de>
 <20200728111800.77641-2-frank-w@public-files.de> <CAAOTY_8nm0KDHFzOX9+qTTHOUd0Vik063J+rScu_y-hTBTkrCQ@mail.gmail.com>
 <trinity-2bdb3521-256a-4d4d-928a-be9b8c179d4c-1596355539029@3c-app-gmx-bs58>
In-Reply-To: <trinity-2bdb3521-256a-4d4d-928a-be9b8c179d4c-1596355539029@3c-app-gmx-bs58>
From:   Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date:   Mon, 3 Aug 2020 07:47:01 +0800
Message-ID: <CAAOTY__TsqrfRX-z+DE0+X_UzxBqChJ+VdyQG6z9N6Qr4bn2Kg@mail.gmail.com>
Subject: Re: Re: [PATCH v2 1/5] drm/mediatek: config component output by
 device node port
To:     Frank Wunderlich <frank-w@public-files.de>
Cc:     Chun-Kuang Hu <chunkuang.hu@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        David Airlie <airlied@linux.ie>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        DRI Development <dri-devel@lists.freedesktop.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        Daniel Vetter <daniel@ffwll.ch>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Bibby Hsieh <bibby.hsieh@mediatek.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi, Frank:

Frank Wunderlich <frank-w@public-files.de> =E6=96=BC 2020=E5=B9=B48=E6=9C=
=882=E6=97=A5 =E9=80=B1=E6=97=A5 =E4=B8=8B=E5=8D=884:06=E5=AF=AB=E9=81=93=
=EF=BC=9A
>
> > Gesendet: Sonntag, 02. August 2020 um 02:03 Uhr
> > Von: "Chun-Kuang Hu" <chunkuang.hu@kernel.org>
> > An: "Frank Wunderlich" <frank-w@public-files.de>
> > Cc: "Chun-Kuang Hu" <chunkuang.hu@kernel.org>, "Philipp Zabel" <p.zabel=
@pengutronix.de>, "David Airlie" <airlied@linux.ie>, "linux-kernel" <linux-=
kernel@vger.kernel.org>, "DRI Development" <dri-devel@lists.freedesktop.org=
>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@lists.infradea=
d.org>, "Daniel Vetter" <daniel@ffwll.ch>, "Matthias Brugger" <matthias.bgg=
@gmail.com>, "Bibby Hsieh" <bibby.hsieh@mediatek.com>, "Linux ARM" <linux-a=
rm-kernel@lists.infradead.org>
> > Betreff: Re: [PATCH v2 1/5] drm/mediatek: config component output by de=
vice node port
> > > +
> > > +               if (comp_type !=3D MTK_DSI && comp_type !=3D MTK_DPI)=
 {
> > > +                       port =3D of_graph_get_port_by_id(node, 0);
> > > +                       if (!port)
> > > +                               continue;
> > > +                       ep =3D of_get_child_by_name(port, "endpoint")=
;
> > > +                       of_node_put(port);
> > > +                       if (!ep)
> > > +                               continue;
> > > +                       remote =3D of_graph_get_remote_port_parent(ep=
);
> > > +                       of_node_put(ep);
> > > +                       if (!remote)
> > > +                               continue;
> > > +                       of_id =3D of_match_node(mtk_ddp_comp_dt_ids, =
remote);
> > > +                       if (!of_id)
> > > +                               continue;
> > > +                       comp_type =3D (enum mtk_ddp_comp_type)of_id->=
data;
> > > +                       for (i =3D 0; i < private->data->main_len - 1=
; i++)
> > > +                               if (private->data->main_path[i] =3D=
=3D comp_id)
> > > +                                       private->data->main_path[i + =
1] =3D
> > > +                                       mtk_ddp_comp_get_id(node, com=
p_type);
> > > +                       for (i =3D 0; i < private->data->ext_len - 1;=
 i++)
> > > +                               if (private->data->ext_path[i] =3D=3D=
 comp_id)
> > > +                                       private->data->ext_path[i + 1=
] =3D
> > > +                                       mtk_ddp_comp_get_id(node, com=
p_type);
> > > +               }
> >
> > The port property is not defined in binding document [1], so define it
> > in binding document first.
> >
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/=
tree/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt?h=
=3Dv5.8-rc7
>
> hi,
> would be the following enough for describing the ports?
>
> Port binding
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>
> some nodes like
>
> - connector (e.g. hdmi-connector)
> - bls (mediatek,mt7623-disp-pwm)
> - hdmix (mediatek,mt7623-hdmi)

Now I just care about the bls to dpi. So in mediatek,disp.txt, you
just need to add a Optional properties - port (input and output), and
modify mediatek,dpi.txt for its input port.

Regards,
Chun-Kuang.

>
> can have port bindings to connect each other. Each port can have only 1 e=
ndpoint
>
> more detail about ports/endpoints in ../../media/video-interfaces.txt
> hdmi-connector is described here: ../connector/hdmi-connector.txt
>
> example:
>
> connector {
>         compatible =3D "hdmi-connector";
>
>         port {
>                 hdmi_connector_in: endpoint {
>                         remote-endpoint =3D <&hdmi0_out>;
>                 };
>         };
> };
>
>
> &bls {
>         status =3D "okay";
>
>         port {
>                 bls_out: endpoint {
>                         remote-endpoint =3D <&dpi0_in>;
>                 };
>         };
> };
>
> &dpi0 {
>         status =3D "okay";
>
>         ports {
>                 #address-cells =3D <1>;
>                 #size-cells =3D <0>;
>                 port@0 {
>                         reg =3D <0>;
>                         dpi0_out: endpoint {
>                                 remote-endpoint =3D <&hdmi0_in>;
>                         };
>                 };
>
>                 port@1 {
>                         reg =3D <1>;
>                         dpi0_in: endpoint {
>                                 remote-endpoint =3D <&bls_out>;
>                         };
>                 };
>         };
> };
>
> &hdmi0 {
>
>         ports {
>                 #address-cells =3D <1>;
>                 #size-cells =3D <0>;
>                 port@0 {
>                         reg =3D <0>;
>                         hdmi0_in: endpoint {
>                                 remote-endpoint =3D <&dpi0_out>;
>                         };
>                 };
>
>                 port@1 {
>                         reg =3D <1>;
>                         hdmi0_out: endpoint {
>                                 remote-endpoint =3D <&hdmi_connector_in>;
>                         };
>                 };
>         };
> };
>
> regards Frank