Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1717015pxa; Sun, 2 Aug 2020 18:29:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwk/MfTaUCsSC0fniPT3ss9TolxS7vWB1Q+St1wgOZrs6p7tcHSLsCKcVDTsrSN8rTIXuOk X-Received: by 2002:aa7:dcd2:: with SMTP id w18mr14057093edu.307.1596418190061; Sun, 02 Aug 2020 18:29:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596418190; cv=none; d=google.com; s=arc-20160816; b=mGAxWI43qGT3GzxJ3Vtan8pTU0dDVPvP7OpVtPdsvXGlSsqTxS1hLzE2GhheKJjXmd Ot9hsh7E10uoyl1d2vN2T/niSMcrP8xEdG/sNXCkWbVSYFLySDncOjohNfLX0nLJYjlr tP+oFhzblrodsEpQXlRqPEVurn7l/lRCqXK4AmKTvYWHVXNhP2EkZ6OCIvPUmDdEAzSl +o+aLP3cY7RXX+iifHEgbhRHBNcbdlRTJMr+7E785ckT/Weqfke4xM2YH1RWwHYG6Sr5 kYtEhvk0YBCeGmHvuuVJ0+0uhO9EDsVVWelmULnOOsNxnSV461DYb1zo7szNQ1BDBPhj l8Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=wVSfXa5Ic9bcSsi1l7jOjJtzRsSr8hAuHXLBgAaKg4Y=; b=OvFWLDHTdS+hZgo8UD0dPyjEslRPYbESiL81m0fcODuk8SuUwbrluV8CbmKEMTsb35 TN25nYcbbS3jkKqib13t8XbnB55/TbtsiytTZbKwyOIEcJOgeEjp1Iackeh2h0l+wBXi yJ4W4oxd84csShjHtkGMziPwhgM2z3TZphaC+H/ysuDsrXYrUx0xcVLDrmLsMv1nhcbH 1wM7jkGdT/mszwtbd3nUn8OQ0XmNI5UJf4avoyIyO3MOgYW3H0/wNF5lYwAj9597i7UZ VcGlD2tiKq0Pm6Z++PvBNTzT+CrEtRCydqjDjuA/ujl/vDsuqyFI0h+D2T356sONCdAM GRtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FQudipL0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j2si9558014edp.166.2020.08.02.18.29.27; Sun, 02 Aug 2020 18:29:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FQudipL0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726252AbgHCBZ0 (ORCPT + 99 others); Sun, 2 Aug 2020 21:25:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725820AbgHCBZZ (ORCPT ); Sun, 2 Aug 2020 21:25:25 -0400 Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 750DDC06174A; Sun, 2 Aug 2020 18:25:25 -0700 (PDT) Received: by mail-io1-xd43.google.com with SMTP id d18so36993251ion.0; Sun, 02 Aug 2020 18:25:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wVSfXa5Ic9bcSsi1l7jOjJtzRsSr8hAuHXLBgAaKg4Y=; b=FQudipL07NEvLgz8nTn96jNAE2t+GE/6dbCq3s/St2AO8HkzFo758+5PskcCIwhlmM 3PC9+v1r4/vJqZerGpylYkcUbYW9v0GJnOkEcAQDtSMDo12z5V57HoTB5A5CY6w5vBdS XaqFVGkz3P1hVAncm8M0WRH7nqRrY8KIJCfLyHixiDHkqgO2k+fJXybCUyAaD0QHcMCy SeoAuYY26g25MEXUyZm9Tj4ilZFWANQL+nQ/f6bTDLd4A4LGNdlbG9BOUUI4wtrDevDg 2E/RPm27a+6fGTPUlKIzQ6UZKtVPCRWIlYoXOBnPCsGD1jhKD1nu8bsztzLeLdK1eJby 51Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wVSfXa5Ic9bcSsi1l7jOjJtzRsSr8hAuHXLBgAaKg4Y=; b=J2vMwaM4vEhItqfVF6RibIhFYL2+MMLlr0bbYQuFgRlhy+Z3ka5/BqF1uPphAaROzW t8tC2Rciqn1h2vOoxGunTfvuOL3pbQe3CBWUR0Ccqk0mI8nK8ELKSrhPeUmW4zgu9S2S R+hrvgGZ8RDzyphlpuoEgkarF9/sMFNjfK7z/JmbQ/+o7msVKTT6vDtHLSgVS2AK2Hwh +Nc8IhIz2wlUYm1+ReR4eocmHtP+aiwCbaB3c2SgeDPrTPYpuE4n5HtGbP9ueNAWEwub MZ0AxLmHyPuEELz0LA2mKnMIlRZwvTCwUv9hnkf9v0sDSOP1ctvfVjvzg54MI9X5HSu1 yvvw== X-Gm-Message-State: AOAM5326Uh0qDIbWYNu+o6X2WsYiL9VhbcPlZG4ZsEDKJVqVzuxeCKgD V8l5bzM+FiV00uH3eG5BKcTG9MvwkGAmZpcekF4= X-Received: by 2002:a5d:93c5:: with SMTP id j5mr14700313ioo.161.1596417924507; Sun, 02 Aug 2020 18:25:24 -0700 (PDT) MIME-Version: 1.0 References: <20200731082513.11806-1-gmayyyha@gmail.com> <8e87954aa5d04dd25330afd68b396ef40ff53398.camel@kernel.org> In-Reply-To: <8e87954aa5d04dd25330afd68b396ef40ff53398.camel@kernel.org> From: Yanhu Cao Date: Mon, 3 Aug 2020 09:25:13 +0800 Message-ID: Subject: Re: [v2] ceph: use frag's MDS in either mode To: Jeff Layton Cc: Ilya Dryomov , ceph-devel , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 31, 2020 at 7:57 PM Jeff Layton wrote: > > On Fri, 2020-07-31 at 16:25 +0800, Yanhu Cao wrote: > > When doing some tests with multiple mds, there are many > > mds forwarding requests between them and then the client request > > is resent. > > > > If the request is a modification operation and the mode is set to USE_AUTH_MDS. > > Auth mds should be selected to handle the request, and if auth mds for > > frag is already set, it can be returned directly without the logic behind it. > > > > But the current logic doesn't return directly because the condition > > 'mode == USE_AUTH_MDS', and sometimes frag's mds is not equal to > > cap's session mds, which then causes the request to be resent. > > > > Signed-off-by: Yanhu Cao > > --- > > fs/ceph/mds_client.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c > > index a50497142e59..b2255a9be7c0 100644 > > --- a/fs/ceph/mds_client.c > > +++ b/fs/ceph/mds_client.c > > @@ -1103,8 +1103,7 @@ static int __choose_mds(struct ceph_mds_client *mdsc, > > frag.frag, mds); > > if (ceph_mdsmap_get_state(mdsc->mdsmap, mds) >= > > CEPH_MDS_STATE_ACTIVE) { > > - if (mode == USE_ANY_MDS && > > - !ceph_mdsmap_is_laggy(mdsc->mdsmap, > > + if (!ceph_mdsmap_is_laggy(mdsc->mdsmap, > > mds)) > > goto out; > > } > > > Much better! A good changelog is as important as the patch, esp in code > like this that is quite non-obvious. > > Merged into testing branch. I did clean up the changelog a bit before I > merged it. Please take a look when you have time and let me know if you > think I got it wrong. LGTM. Thanks. > > Thanks! > -- > Jeff Layton >