Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1756342pxa; Sun, 2 Aug 2020 20:14:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBE89GZ1JK0SeacJ6EKtiD72GgcX1ceWFZxComYJKtuQpbYOe6Xz7mWdm0jnNeUPorHi1B X-Received: by 2002:a05:6402:b4b:: with SMTP id bx11mr13442344edb.286.1596424453665; Sun, 02 Aug 2020 20:14:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596424453; cv=none; d=google.com; s=arc-20160816; b=nVRrG/IKpnrPaSmJCQJUX6w8HC+dBd7Ll1PTIOUE22eWFYjHwUmQX6Md2qcwdSdvUx z+CRNHmrxhUZGGFSSzJPC5t2XgSBbz07N2eDdyuUOf8ykN+/zlcU08XFBiodChL0SYDg EvNr8/NzuMmUS9x4pxoDQjv9Fm0QfEKroOlSQjkOmMV9ytyxoV7Bhseh+CDUUh714HwJ uEemporTehuc6nhtmm1VZMHzG7vc7+2DX/70CSWfkufhBGiB5PUnECnenoQjLiHJ2dG5 aEeo1RBhxnvfWpKktRoX5LDUlQW9Fe4icVnDsmxwdLiTUB5uyz1sdfRNjOO26GDsbLmW NXVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=nf3xdvRmh1qxPw9xaehxZVxmJAEdSCtmDvi8x8RGLZA=; b=gF7nDOcKoSHUzMDLNxD23liXwnYwBLUhv9i4HNnNOXSlxMf3G4qpRA1byI+4kXCuh2 qn1HAETId15rwxeuGTW22ChG8mDmqoF0VCHuEgYhdzwE+rqdhZ8KJLUfXecubSENDXaj AzY6DcxSkCgUSl7mQ5tnUZgNQZi6gm/msEdAU9eivp46+S/iVHjsQno5JSVrAHIZ/fHZ VHcM+2zkT2r+9djBDrUNu1y9dIq3JN7efGFGk4W3shuCet76FGLn+ZZ3JQyHxgsGz2bR UgDXsferTR0Lxbf39hZE9Id78vwSWollNkwQUkJYyXo/7De7+WMlx1aeIigIk6VU7eAW njGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s16si9560817ejm.36.2020.08.02.20.13.50; Sun, 02 Aug 2020 20:14:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727103AbgHCDMH (ORCPT + 99 others); Sun, 2 Aug 2020 23:12:07 -0400 Received: from mail-pj1-f68.google.com ([209.85.216.68]:50894 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726497AbgHCDMG (ORCPT ); Sun, 2 Aug 2020 23:12:06 -0400 Received: by mail-pj1-f68.google.com with SMTP id e4so6950430pjd.0; Sun, 02 Aug 2020 20:12:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=nf3xdvRmh1qxPw9xaehxZVxmJAEdSCtmDvi8x8RGLZA=; b=qjEKE6sHu829+ot5rhDLdrx3zplfNv5pYUAKVvMCUojkm2VxUT6Paw0hGLGXfKQQEp nZbfkKtQwp+U2iMnHq2E/KZSLnQQrRuj/QeUQGG5rHl0Dd/+xxHKeWSwkYCLTE8TDksm aurEtrMNDqFwAzPfiZbTz7vadtJ2WhriVaFbqpC4iz+HmkIdp/MDkz93/VkK9kZzNI9P bFzVdBniCKZnjdkLyRd07NpFa4VxHm1MyV25nlEIxhzj1ihbi+2KFJelubj5nuIV0P2n 3Wgme9wakjOEvWCJfeaZ8f91jqBszWr3qgRdEb7aStPTH9qQTfDUKONIKZUK89+YdeSd D7cA== X-Gm-Message-State: AOAM530VeAhM9rtjEi6GU5g12RsNjRRvgsk35k6B36PraRslbtOrOK+K A/yz56SgSM3YwQeeJrn4E8g= X-Received: by 2002:a17:902:6bc2:: with SMTP id m2mr12379497plt.119.1596424325859; Sun, 02 Aug 2020 20:12:05 -0700 (PDT) Received: from [192.168.3.219] (c-73-241-217-19.hsd1.ca.comcast.net. [73.241.217.19]) by smtp.gmail.com with ESMTPSA id y10sm15060677pjv.55.2020.08.02.20.12.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Aug 2020 20:12:04 -0700 (PDT) Subject: Re: [PATCH v4] scsi: ufs: Cleanup completed request without interrupt notification To: Can Guo Cc: Stanley Chu , Avri Altman , linux-scsi@vger.kernel.org, martin.petersen@oracle.com, alim.akhtar@samsung.com, jejb@linux.ibm.com, beanhuo@micron.com, asutoshd@codeaurora.org, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kuohong.wang@mediatek.com, peter.wang@mediatek.com, chun-hung.wu@mediatek.com, andy.teng@mediatek.com, chaotian.jing@mediatek.com, cc.chou@mediatek.com References: <20200724140246.19434-1-stanley.chu@mediatek.com> <1596159018.17247.53.camel@mtkswgap22> <97f1dfb0-41b6-0249-3e82-cae480b0efb6@acm.org> <8b0a158a7c3ee2165e09290996521ffc@codeaurora.org> <548b602daa1e15415625cb8d1f81a208@codeaurora.org> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: <80f5e213-502b-3532-e782-6f26a778274e@acm.org> Date: Sun, 2 Aug 2020 20:12:03 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <548b602daa1e15415625cb8d1f81a208@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-07-31 16:17, Can Guo wrote: > For scsi_dma_unmap() part, that is true - we should make it serialized with > any other completion paths. I've found it during my fault injection test, so > I've made a patch to fix it, but it only comes in my next error recovery > enhancement patch series. Please check the attachment. Hi Can, It is not clear to me how that patch serializes scsi_dma_unmap() against other completion paths? Doesn't the regular completion path call __ufshcd_transfer_req_compl() without holding the host lock? Thanks, Bart.