Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1799767pxa; Sun, 2 Aug 2020 22:07:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxa8d+P3/iTe4HSTGSA6trbOur8PiE3HJt7IV4409YtRGsUNbjWlPZ25EAO86KrrrmLl61k X-Received: by 2002:a17:906:b2d0:: with SMTP id cf16mr14789113ejb.476.1596431258986; Sun, 02 Aug 2020 22:07:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596431258; cv=none; d=google.com; s=arc-20160816; b=L8Zt/CGrY9D1WHpLKAlN04vvJfSt6XeHYS2kcaVBoDftBO1ixEWSm/HpD5+jLIZxN1 aOVnnLKn+NhHw/KK69sWAxMNKedaM2TN3acejvrVXlRR3SfcgyTzCZXRjXvWoNrBeden 16Sp89Wj6NLlen9jw0VEeqzWhNU3hvJpppR+/J6+88VkoAIFUP7bYmXSFirSsgXHXmZR UDH479mGX1zwrmKlJbPH7a8SO9GcTd3OC95J43TTrBhXB2rG4+vfHXw1H+6Bnv9PokT+ vZNfFubd7UYdasBbR1k6Y71xjgGyZTIlR2P6ZSOOWpg9qj6KBXTdOCcv1YK3wt0P8qfU AE/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :subject:references:in-reply-to:message-id:cc:to:from:date :dkim-signature; bh=jG5Ttu2IFR0hBTgY1CkuGVNQzM97L3YaR4HgFRRkO2Y=; b=nT+vBUmkAkTDAvOlWa13zB4MDuxxOceLwZMbKtRYbU1vh3WTWPj8Md5ZcTBM75PHjY LXgAlka6g8lQTFapQtcEiu6alac69ufwwF3Et/shKvhe5E3LTU8GguV5Y6Jfc2eCt3S/ ZVOrNhV8WMBcihJMMgVERtsGfSzkjdT9KUaX+K+w9TnE/42EwOf3631qyYV6Qhetn8Tn Dam4hq+LLaGQ6KzqT/AkUL49d/5iNqlbzyr/gM0zxVlRLfN3T29DM5n14mpneIX4mbeX V4/uxwKtioXHjMYi95XWzW7grMFN6tp6PzoGN5XcR7Kc9FuUh1rmlOtO2L1O7zlrTnVE nS9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=qsuUjjXa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn20si14607167ejc.111.2020.08.02.22.07.17; Sun, 02 Aug 2020 22:07:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=qsuUjjXa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727121AbgHCFEZ (ORCPT + 99 others); Mon, 3 Aug 2020 01:04:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725268AbgHCFEZ (ORCPT ); Mon, 3 Aug 2020 01:04:25 -0400 Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40F1DC06174A; Sun, 2 Aug 2020 22:04:25 -0700 (PDT) Received: by mail-io1-xd43.google.com with SMTP id w12so23686764iom.4; Sun, 02 Aug 2020 22:04:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-transfer-encoding; bh=jG5Ttu2IFR0hBTgY1CkuGVNQzM97L3YaR4HgFRRkO2Y=; b=qsuUjjXaCVRc88NKXyC1q3qETut38wpfLJsTYlOf8l4aOOcJaEJmxmrmVNsiCzx16v Sej6ZBkm3+CloRFsjDkncvSWsgoE2W9OXxYIRyUT2ES93/ZaV5DBmkdlYg/DsvM1Pkw8 5ohLFELVgacdOGMSg39B9a66dQCNXk3GazOqO/1x+odVwWyqm7RZDgwUuOJ/Zm7ZiQCa S2V2lqbrZx0fVhu0euDtebgKVAdTH5yGgpVctvzW6qw+iWvuLY7d/uYI07LJmkMqaBhp V76sIXuXsMD66hhshZ77fu7qHIjpLAarO9lQA9XN1XHAbsn41mP5KGoD2C4++d+KUqWP Q/Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-transfer-encoding; bh=jG5Ttu2IFR0hBTgY1CkuGVNQzM97L3YaR4HgFRRkO2Y=; b=STVT+odWGgRWdQCNC1tp+iMRPPdaEgE4NZCAb3GvRsq2S+pgZC8iG3ppuTMZKiDB1S hPUMecyW0fpAElyVPIgN/wvO1qxqfZ0sKva8Gw3xPJW0J3s3KY+pVRkB/O4+0U5Qc7pa cf83LMHJYqJlIu+ac9DH+lj42ccnSb276atzS4qYQ/QjVK+9WqkiHOKZUAMcuaywfTCP nFnGjvR70+t+owaz3OLmKtQteVr2AyFKaqz792s1MF7toCZKfeh7lXiqyfnPTYKkTmZA OiwPjj3x73jb7kkVgAqJg7J1ZUYnF3BqrjoJoMaUodiXgFJc8EKJHBcREoZlCZLD9Dfe ZUmw== X-Gm-Message-State: AOAM531R0Rw/tO2RHju6noNHLPJLxQhnpzeg0vTprpoOacnr9PfZvgTh M/oqABTQ9Sra6sFHl39n7hw= X-Received: by 2002:a02:838e:: with SMTP id z14mr19188094jag.84.1596431064695; Sun, 02 Aug 2020 22:04:24 -0700 (PDT) Received: from localhost ([184.63.162.180]) by smtp.gmail.com with ESMTPSA id f84sm5869159ilh.72.2020.08.02.22.04.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2020 22:04:23 -0700 (PDT) Date: Sun, 02 Aug 2020 22:04:14 -0700 From: John Fastabend To: Andrii Nakryiko , Tianjia Zhang Cc: Alexei Starovoitov , Daniel Borkmann , Martin Lau , Song Liu , Yonghong Song , Andrii Nakryiko , john fastabend , KP Singh , Quentin Monnet , Jakub Kicinski , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Tobias Klauser , Jiri Olsa , Networking , bpf , open list , tianjia.zhang@alibaba.com Message-ID: <5f279aceeb809_5782b0a7167a5c487@john-XPS-13-9370.notmuch> In-Reply-To: References: <20200802111540.5384-1-tianjia.zhang@linux.alibaba.com> Subject: Re: [PATCH] tools/bpf/bpftool: Fix wrong return value in do_dump() Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrii Nakryiko wrote: > On Sun, Aug 2, 2020 at 4:16 AM Tianjia Zhang > wrote: > > > > In case of btf_id does not exist, a negative error code -ENOENT > > should be returned. > > > > Fixes: c93cc69004df3 ("bpftool: add ability to dump BTF types") > > Cc: Andrii Nakryiko > > Signed-off-by: Tianjia Zhang > > --- > > > Acked-by: Andrii Nakryiko > Acked-by: John Fastabend