Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1834223pxa; Sun, 2 Aug 2020 23:29:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUp1XbDrKJIVMyYCrAoFLwgA2U5HFbxB4gXfyimv1Hhe8hCOjXTLFDF0uX0ZPhKUqV/GmM X-Received: by 2002:a17:906:2f17:: with SMTP id v23mr14807367eji.343.1596436168069; Sun, 02 Aug 2020 23:29:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596436168; cv=none; d=google.com; s=arc-20160816; b=Sa9DnYae7eYtSkN0zIVTH8A5tEmuQkaToleHmoY7M0EG9OB1tub+zQQsduNrBKwBn8 QtiVFztPnfC3BRhOkRDp44HCal9W6Rezx01lh1D+65TyxYBeVh7TnOiz+5KTwvoc7haF xJZuWL2Poz0aCUXC+En7pnjQfoCM7McRftVCP+M/MslsFuXRmdLT+PfDBrheXFG4T9Er 2WE0NsNr82904wJbG+btTM34IwX9AR/FBWV01KMa9TTac0R7LwhGpHFUVNiqhsAKFTRT HEBQKh5/tj1UkYuN1PGVodr1Gk4g/I46lvr88rJYB4Xc3FI91veKfc51KHCFORpIhNN0 kB7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=bKDqFQckR0BYepkPjJBOZU8MFpvk25sGRNDFDQroL08=; b=KQmh7o8eDpLht+EQfLuOSZkbLv9c9K2vTI8P/2dU38RERYaJB13YYTgMylzTkEtEZ1 YzC0ZXYJlnKekf2ei0xF7EMs2iMqsf16JZq3QzMIjdDD/meoZNlAfznloyWoJbW3gzTd 5io8cjv/a3vLRg2MymkPjSnZ55L9mQfxlA4xfdWK4r0XADOTPrE8iyL9F5TykTg3Lf3A yLnf64+AKuO8PHk7VeLylxfihQ+QiEGjjiX5BWn4ITft8DHO1itRfA83gu9nqSPn/o67 5rnCbL2vzyYRqfv8Os3QIqLz4mK03Yg13TjpP4w/x9bLKscxReevvQVRgN5HYVTcIN+I HEKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q25si9781204edr.402.2020.08.02.23.29.05; Sun, 02 Aug 2020 23:29:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728300AbgHCGSV (ORCPT + 99 others); Mon, 3 Aug 2020 02:18:21 -0400 Received: from mx2.suse.de ([195.135.220.15]:60532 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725908AbgHCGSU (ORCPT ); Mon, 3 Aug 2020 02:18:20 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 16439AF38; Mon, 3 Aug 2020 06:18:34 +0000 (UTC) Subject: Re: [PATCH v3 1/4] xen/balloon: fix accounting in alloc_xenballooned_pages error path To: Roger Pau Monne , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Boris Ostrovsky , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20200727091342.52325-1-roger.pau@citrix.com> <20200727091342.52325-2-roger.pau@citrix.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <11ba709b-6b9f-ff87-708f-60dd5200dcde@suse.com> Date: Mon, 3 Aug 2020 08:18:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200727091342.52325-2-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27.07.20 11:13, Roger Pau Monne wrote: > target_unpopulated is incremented with nr_pages at the start of the > function, but the call to free_xenballooned_pages will only subtract > pgno number of pages, and thus the rest need to be subtracted before > returning or else accounting will be skewed. > > Signed-off-by: Roger Pau Monné > Reviewed-by: Juergen Gross > Cc: stable@vger.kernel.org Pushed to xen/tip.git for-linus-5.9 Juergen