Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1941972pxa; Mon, 3 Aug 2020 03:19:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvFB9El2bLKMUOCACYuHyymStzJ2OX2hTVirRKl6k7L3RzZc0Ao0SwbJRqJjCCsXuhKynr X-Received: by 2002:a17:906:af0c:: with SMTP id lx12mr1736753ejb.228.1596449942510; Mon, 03 Aug 2020 03:19:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596449942; cv=none; d=google.com; s=arc-20160816; b=0OlRd5DgPfNqPr/bGYois7dU2c1bUf9rWGUhXj2cN2GdaN4/Svm6QdpFTy/+oTeLpt ERd63v2IwrxKZ6/H44ikwF+gHHA4EbhBWRoXqM6RfINEBp7vyx9YAX+4MPEQr6cnYX8j siE9N6S5qvii1sz8R94XjJypDz22hJzex2UhJDb0h2W3jNNGV6IihNlWOmmPPD4ExvjO 8UDPi1nZgZ2p/wdJmwyfx97z6OUb4CZEfaCojzhnosnTcOFg9+dsB/MgV5rKNQW8LQH5 u0QnqfK9k6wj2r1l6MyJZTFal0V8fo1hW74/EYsKLuFs3wK20JfuSW/vtFj8/lbN/v0E 4A4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization :dkim-signature; bh=bfXMCNI/Os0PHSTlvW49y4Nr2+FnMZYDapmptaEW04U=; b=V/f4GsfttpqBdTBmvCM2Xs4UeV3J6N7JQnzjAUJFmKIv1jXtvhDyj9FVTUthnkDijf Jcqey+ZJG1o6hz+vVlihCWrxOkSNrVjRCIMCXq2jDHndgHjErWSsZS8cJOjrjbbV1rfU DM55Fi9ILjEsxObpIiXeS4oMc8OggKGejsVBzgovG7sx26XHxNDNuynBxkmJ0dxhJK2o 3PWiSWgZ3qpGA5okDY8qsDiLk/Yx7FTsATzDFG394ZnALKVkyVBQ17j83XVuaUPdW4xP Afewb8ZeHAPTlh+9oHMb2h3y04dR6o1qnSGvRwMaDK5iIqAMriA/DxQ69GBT3XJT2Zre oOaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VBEL9t0T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bi20si9960800ejb.365.2020.08.03.03.18.39; Mon, 03 Aug 2020 03:19:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VBEL9t0T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726772AbgHCKSV (ORCPT + 99 others); Mon, 3 Aug 2020 06:18:21 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:47234 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726752AbgHCKSU (ORCPT ); Mon, 3 Aug 2020 06:18:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596449899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bfXMCNI/Os0PHSTlvW49y4Nr2+FnMZYDapmptaEW04U=; b=VBEL9t0Tt4gA/grwTrDZ2wi4qyr/OqEpSfoE2D9y2Kriajvba9USa8C5AAl9BQWE9skC1z 8wwB+lHyKNKam+MzzSWaq50JzNYlxr1bEOnvOOmda5QqAf+bJHzv2HsIy2/do6YFeNJa8y 3CA8uOkWlP19XIBMVYNOe0HuD7R+YXc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-368-K_5LoHEKMdSlR3ZUeqZ2fw-1; Mon, 03 Aug 2020 06:18:16 -0400 X-MC-Unique: K_5LoHEKMdSlR3ZUeqZ2fw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 449B81005504; Mon, 3 Aug 2020 10:18:13 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-32.rdu2.redhat.com [10.10.112.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 17FC888F20; Mon, 3 Aug 2020 10:18:09 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <1293241.1595501326@warthog.procyon.org.uk> <158454378820.2863966.10496767254293183123.stgit@warthog.procyon.org.uk> <158454391302.2863966.1884682840541676280.stgit@warthog.procyon.org.uk> <2003787.1595585999@warthog.procyon.org.uk> <865566fb800a014868a9a7e36a00a14430efb11e.camel@themaw.net> <2023286.1595590563@warthog.procyon.org.uk> To: Miklos Szeredi Cc: dhowells@redhat.com, Ian Kent , Linus Torvalds , Al Viro , Casey Schaufler , Stephen Smalley , Nicolas Dichtel , Christian Brauner , andres@anarazel.de, Jeff Layton , dray@redhat.com, Karel Zak , keyrings@vger.kernel.org, Linux API , linux-fsdevel@vger.kernel.org, LSM , linux-kernel@vger.kernel.org Subject: Re: [PATCH 13/17] watch_queue: Implement mount topology and attribute change notifications [ver #5] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1283474.1596449889.1@warthog.procyon.org.uk> Date: Mon, 03 Aug 2020 11:18:09 +0100 Message-ID: <1283475.1596449889@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Miklos Szeredi wrote: > > fsinfo() then allows you to retrieve them by path or by mount ID. > > Shouldn't the notification interface provide the unique ID? Hmmm... If I'm going to do that, I have to put the fsinfo-core branch first otherwise you can't actually retrieve the unique ID - and thus won't be able to make sense of the notification record. Such a rearrangement might make sense anyway since Ian and Karel have been primarily concentrating on fsinfo and only more recently started adding notification support. David