Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 3 Aug 2020 13:56:44 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Sebastian Reichel <sre@kernel.org>
Cc:     Pavel Machek <pavel@denx.de>, Qiwu Huang <yanziily@gmail.com>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        jiangfei1@xiaomi.com, Qiwu Huang <huangqiwu@xiaomi.com>
Subject: Re: [PATCH v4 1/4] power: supply: core: add quick charge type
 property
Message-ID: <20200803115644.GC955269@kroah.com>
References: <cover.1595214246.git.huangqiwu@xiaomi.com>
 <c9d3199ec18625f9cc4448c3b2049ea2ae80358b.1595214246.git.huangqiwu@xiaomi.com>
 <20200802120015.GA1289@bug>
 <20200802123742.GA257810@kroah.com>
 <20200802142825.GA20261@amd>
 <20200802165738.GA293244@kroah.com>
 <20200803114950.oyb3gzyiccybah3u@earth.universe>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200803114950.oyb3gzyiccybah3u@earth.universe>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Aug 03, 2020 at 01:49:50PM +0200, Sebastian Reichel wrote:
> More importantely I prefer not to merge new APIs without any users
> (i.e. a driver making use of those values). Having a reference
> driver means, that there is an example how to use the values
> correctly and proves it is actually needed upstream. Right now
> this looks like "let's modify the upstream kernel, so that we can
> easily maintain our out of tree driver".

Agreed.  Qiwu, can you also submit your driver so we can see these
values be used?

thanks,

greg k-h