Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2005566pxa; Mon, 3 Aug 2020 05:11:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyiYhnnO5pQE7/AOiyOM8D+Ydhwwz+t5iXYXIRt0uQ8cb8v84tRirqceWgJNDNOAJOfUXHy X-Received: by 2002:a17:906:2e0c:: with SMTP id n12mr16099553eji.35.1596456686304; Mon, 03 Aug 2020 05:11:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596456686; cv=none; d=google.com; s=arc-20160816; b=apfc2MpOJ6DJ4GopAwH/yCXGt+iFayfNvaOSfkf/CqPrAqiqGZM2O6RylQljSNERCZ DaEbjWb3mONUuofb4917PLP78csQxOCoqMEIqYPEjCvZWqN6esh28ZlQ8Fbyl1h3DfSf 7pAX0R6LZJp0YAlLtYg/m1HcGixRQFTUmS1hosl3rmewh023+6ADamCY6jta4PXn3woR mkIZT6WOmDXOYFe7FMtyB8OAx0GtQBdqbhXDt6aegzn0zbCh9mjyb+gMdWVyNSfYlnG6 QiaXq54sUCDcGFDjSAoKIYWt/GcaGMciI5l1iY5E9VgJxoo2fKGSMuGfweYAEacUkFPI vmuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=U0tL39aLglkJrbRA5E3dM2LRcS8d3XyI4lDc3p0DpU8=; b=aaIqSttUsUOAevh3U26QJhYMzFzzKL7qdg08GLtD/FS+ls8RbKQvKt+oyrxx/BDp0N A2artVkU/7EL1+AtiUBlVsCRsfVFDsgS3KnVSW8G0ceykBzSmTmRsFz9Od49Puna1P36 3wl2/Uu+7OV8M8/AA5veVOS5UfgIcj/7wCnE5+acUqgh+3d5weokSPHrdeQXCbaC/pWi 6vOLKxPEIeMJu64m2OWUykyqtK3UYF0rjIWZ1v3qXS9w+/5sAqHccprrTq/blnu+hcbt hYUfzTN9uLwmj5zigdlc8oBbS6wvmPnHZtrTV3hUr8uQCWonRTItuvUwsEh2I3YHhy6b Yraw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Hk4ynhZ1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g8si9979453ejm.100.2020.08.03.05.11.02; Mon, 03 Aug 2020 05:11:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Hk4ynhZ1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726300AbgHCMKl (ORCPT + 99 others); Mon, 3 Aug 2020 08:10:41 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:55427 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726118AbgHCMKi (ORCPT ); Mon, 3 Aug 2020 08:10:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596456637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U0tL39aLglkJrbRA5E3dM2LRcS8d3XyI4lDc3p0DpU8=; b=Hk4ynhZ1ReHggt8hJFmI94bx1Y4geoQ34MzJa1ykXAvFLgwvkKdDNFBoLRtwVh8nZo9X6a LX+gak9N+uVlwDxqa10gyaxRz1dZeeeIvoAiAaYIyX1YzaXvDkPgSYJ+h7Quc193u8ylVa bKdttf0/tzj2iB0vezRiMvjgXUmCgs0= Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-370-yUbhHb5tNVaOU5VD3DJREQ-1; Mon, 03 Aug 2020 08:10:35 -0400 X-MC-Unique: yUbhHb5tNVaOU5VD3DJREQ-1 Received: by mail-oo1-f70.google.com with SMTP id y22so16621115oog.21 for ; Mon, 03 Aug 2020 05:10:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U0tL39aLglkJrbRA5E3dM2LRcS8d3XyI4lDc3p0DpU8=; b=AaWmD9UUVsW20hl6T+loNUYxuLMMzwgashYUlurihpVwcEF2YS3HlcIEb6Dyl5sYCS Qt1IKQ5o8I5oOl87eaPu3TlqeIGe20TJfu51Xn7SnP+bJ0n8hBDtH89Gk1/tRlCu9FxO ZeJremYL/sIOQ+DNH+jTNVQse2S/0Y/KvHbdSIK0IGhassCuXPWW0pArsMdXVR9r8lX9 wWsRP9RgTMZxBAvDXwcZ/A5LS40snx9qiUuGcE+N8i3iMU/qJpngFOc7gSrXt4VSnFs3 OdzVeoPyZRQ3Xu9+7+ErY+ZToe0VpsEe5uVy76UmCQHrOQkTp28qaR09pH9sF2IWl6ud YANA== X-Gm-Message-State: AOAM533QzoG3oXCyEv9zZtWogVN+epNvv0qEmtxaxp0kDF7gVYNhJclz afK5SzFx04DbB7fCLYOpApZ9zNZNDLe9wsrAnmpa5UjCm/a8sm0OuGQAFttou7fazZ3WPHCjotm 2/oJl2t5ZxPmVLgP1ywvM3ZYVqqzIHcnw8anHgY/m X-Received: by 2002:a9d:2186:: with SMTP id s6mr13383605otb.58.1596456634862; Mon, 03 Aug 2020 05:10:34 -0700 (PDT) X-Received: by 2002:a9d:2186:: with SMTP id s6mr13383590otb.58.1596456634670; Mon, 03 Aug 2020 05:10:34 -0700 (PDT) MIME-Version: 1.0 References: <20200731212818.10782-1-efremov@linux.com> <777bd9d1-35b0-842a-83df-55792126c652@linux.com> In-Reply-To: <777bd9d1-35b0-842a-83df-55792126c652@linux.com> From: Andreas Gruenbacher Date: Mon, 3 Aug 2020 14:10:23 +0200 Message-ID: Subject: Re: [PATCH] gfs2: Use kvmalloc instead of opencoded kmalloc/vmalloc To: Denis Efremov Cc: Bob Peterson , cluster-devel , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Sat, Aug 1, 2020 at 2:05 PM Denis Efremov wrote: > Please, skip this patch. I missed that kvmalloc checks (flags & GFP_KERNEL) == GFP_KERNEL > before calling vmalloc. okay. Assuming that you'll follow up with a fixed version, please also mention that this change supplements commit 3cdcf63ed2d1 ("GFS2: use kvfree() instead of open-coding it"). Thanks, Andreas