Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
To:     Michael Walle <michael@walle.cc>
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Simon Xue <xxm@rock-chips.com>
Subject: Re: [PATCH] iio: adc: rockchip_saradc: select IIO_TRIGGERED_BUFFER
Date:   Mon, 03 Aug 2020 13:59:12 +0200
Message-ID: <2468442.jk0zRepj8P@diego>
Organization: Theobroma Systems
In-Reply-To: <20200803083001.6689-1-michael@walle.cc>
References: <20200803083001.6689-1-michael@walle.cc>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Am Montag, 3. August 2020, 10:30:01 CEST schrieb Michael Walle:
> The kernel fails to compile due to undefined reference to
> devm_iio_triggered_buffer_setup() if IIO_TRIGGERED_BUFFER is not
> enabled. The original patch [1] had this dependency. But somehow it
> didn't make it into the kernel tree. Re-add it.
> 
> [1] https://lore.kernel.org/lkml/20200623233011.2319035-3-heiko@sntech.de/
> 
> Fixes: 4e130dc7b413 ("iio: adc: rockchip_saradc: Add support iio buffers")
> Signed-off-by: Michael Walle <michael@walle.cc>

Reviewed-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>

> ---
>  drivers/iio/adc/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 66d9cc073157..d94dc800b842 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -865,6 +865,8 @@ config ROCKCHIP_SARADC
>  	tristate "Rockchip SARADC driver"
>  	depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
>  	depends on RESET_CONTROLLER
> +	select IIO_BUFFER
> +	select IIO_TRIGGERED_BUFFER
>  	help
>  	  Say yes here to build support for the SARADC found in SoCs from
>  	  Rockchip.
>