Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2024075pxa; Mon, 3 Aug 2020 05:40:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6DmnUkM/Qs3gvTO+TpWFY+8C3WXj434bHjBUz1fdveLo393Fxz2yx7JV1P9Qeu3bvxedK X-Received: by 2002:a17:906:fcb3:: with SMTP id qw19mr10336916ejb.271.1596458410245; Mon, 03 Aug 2020 05:40:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596458410; cv=none; d=google.com; s=arc-20160816; b=0Vg/T8gi1rsEtO4xJMOAouKGaIv8Sg81MmF4lfM6V0p5V7JG7zLzuPv2AFsr0yPrHC VzqvKxPHSAHZFJ46r68jA9aAuG3bMVQjhW5uN73lF2O8f5auXBh6wYvLvG/h441kKcic 1Xddwf+YsJhvnPfX4tolssrbl72hxd9BQRlTYX3uzN4gy+PfrvH5OTXORDDEweMgSZmD usmX9qq1Kzdad/TBbbzvhoFcEBYyXBXp0EiFrpA8AC5UR6U5ZHBaN5d9zo8f5sws08i4 ARbIDqhC7EoNJnSjhVDoKXLuRYVW/0+koZVkYPGRfqys/w3d0xvIriAn62hZdyZjdS8e 7pYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WClhIINmirm/N/XMc2ys0t8dgCDn7pW8qEmgs/+jfsU=; b=mZNl+VKHz8FnhBx1fOBjqe9xBb3Y/+jMd6eWEbNo9wLYbzl5VU6ouqUvqLhh4eoOwr /BuZ/Ueqwu4GLm32zM2fyoGaG3ZUsdAjBjOkrzhrwBlkL5qEu6y8m5HFqaklGkhzAJRm sMxPywjgastmyAxBKbSdVJuxvA2ow2eRtbyUQkzB+8df3PeH3FDojp0CGKqLVRPMp/Qm 8RbYmZNTHL0fFeEsz6KdH26Vt6SAiGk4Gg757HWC2x5klOMfSpJX6zVCDkJBZPevdioQ fkUK1KEaCgDsMuXok/AL1nrgUvIYSM3L7YbMX77WJj1Ss491PUMoB6ZLoHMYlw4pvqtc QD5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UZbOQGlA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id du22si3098727ejc.24.2020.08.03.05.39.47; Mon, 03 Aug 2020 05:40:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UZbOQGlA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728878AbgHCMjn (ORCPT + 99 others); Mon, 3 Aug 2020 08:39:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:33446 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729446AbgHCMdb (ORCPT ); Mon, 3 Aug 2020 08:33:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F6142076B; Mon, 3 Aug 2020 12:33:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596458009; bh=h3F50YRu/vJdUAaf8yXaUUqx+mIxdpj9HxIcTXfF7B0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UZbOQGlAagGARcq78DJzmAufKHR8TMZkJrBEsl136L2ShbdJPpP/pMuThFvYNfB8V mdxO9k2fT+VZhF+eczv2sFYkCuJqqa/pPJv6EvlsRRuq+aeAkTQe0lVHv/wqlw80qK PFmSUASDXMXZAc6hCrxGXoj+BYEhWiH42SgbZOaI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stephen Rothwell , Emese Revfy , Kees Cook , Willy Tarreau , Linus Torvalds Subject: [PATCH 4.19 22/56] random32: remove net_rand_state from the latent entropy gcc plugin Date: Mon, 3 Aug 2020 14:19:37 +0200 Message-Id: <20200803121851.414965160@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200803121850.306734207@linuxfoundation.org> References: <20200803121850.306734207@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Linus Torvalds commit 83bdc7275e6206f560d247be856bceba3e1ed8f2 upstream. It turns out that the plugin right now ends up being really unhappy about the change from 'static' to 'extern' storage that happened in commit f227e3ec3b5c ("random32: update the net random state on interrupt and activity"). This is probably a trivial fix for the latent_entropy plugin, but for now, just remove net_rand_state from the list of things the plugin worries about. Reported-by: Stephen Rothwell Cc: Emese Revfy Cc: Kees Cook Cc: Willy Tarreau Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- include/linux/random.h | 2 +- lib/random32.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- a/include/linux/random.h +++ b/include/linux/random.h @@ -116,7 +116,7 @@ struct rnd_state { __u32 s1, s2, s3, s4; }; -DECLARE_PER_CPU(struct rnd_state, net_rand_state) __latent_entropy; +DECLARE_PER_CPU(struct rnd_state, net_rand_state); u32 prandom_u32_state(struct rnd_state *state); void prandom_bytes_state(struct rnd_state *state, void *buf, size_t nbytes); --- a/lib/random32.c +++ b/lib/random32.c @@ -48,7 +48,7 @@ static inline void prandom_state_selftes } #endif -DEFINE_PER_CPU(struct rnd_state, net_rand_state) __latent_entropy; +DEFINE_PER_CPU(struct rnd_state, net_rand_state); /** * prandom_u32_state - seeded pseudo-random number generator.