Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2080763pxa; Mon, 3 Aug 2020 07:04:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxrJRLMX53KxzNX42DTPvOOT+s3bpYo/XPO0YnF7WIGWvJuAn4FtMYc/z1P0YsR5e0FnsEt X-Received: by 2002:a17:906:c34e:: with SMTP id ci14mr17758018ejb.335.1596463451359; Mon, 03 Aug 2020 07:04:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596463451; cv=none; d=google.com; s=arc-20160816; b=D6ASpXBM5JvbNi+B1KCbGd9JiGE7yPaa+Q9H7FgUHLm7kZg5ti9q+Uili0XQD0rJ5V TqTINhHutIm1+7igVvvNPegYkIsaa0qR3CAfHUa03UdqmljFzSXRyrUBCboK9YrCTNsa n4AuRU8WKVPK1YXnvI+UiQP3yyuuwloABx5I9rpld+B31Xnf+ycr4LfgvCv0ggzWmrWz HoxM1f/2jak6Obd4c9o8+fCo+GR/jSgGe2jPDWprAUlXVK/RLKKj0b6lJ7bN3VdJmSL8 pb5uKypfwJooMDxFj5b1/DWECiE1MO2a44DrX+0oaR/UtUnK5eGTqcOVDcGBz3DjiAdf Gorg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from; bh=rNaAgj73MICBYjCemh8IgazvIYDqlHNG1l63zYRiZ/U=; b=XP/lX4g89fhm9/m5Hwn1m5+B0k+8dOSS9S7dtD2OmPU/eSK+QGHQUbV1bb8qXCcIkF y9/BDDjZ7KxrNnA0xS9GW1m49cLgl0BbcwvgfAnNoKO42NQSd7LmHdue6dgSrfnono+I swZbI3+slwlDNJw62al6UrSzFa5kgQeDNqsbsS6ZzjGBvAPYUjBwewIS8vHsQpQQmEi4 6cTIhBjouRnqRe6MF9bTZm4mp3jlu6Xznfui21pY/nUAjJ5FJ2TZeYPpCtynkAtCcW6C wm/30sNiqdVq+npz1ZA/sdR2HK6emBSZcJ3lA0sblPzQ8Zwisjoapw7vO6rm8y8dqGlw DVPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s16si10353244ejm.36.2020.08.03.07.03.48; Mon, 03 Aug 2020 07:04:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727972AbgHCOBb (ORCPT + 99 others); Mon, 3 Aug 2020 10:01:31 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:63588 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726785AbgHCOBb (ORCPT ); Mon, 3 Aug 2020 10:01:31 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 073Dct2B053806; Mon, 3 Aug 2020 10:01:25 -0400 Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 32pbywnnqu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 03 Aug 2020 10:01:23 -0400 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 073E0TQF022470; Mon, 3 Aug 2020 14:01:21 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma03ams.nl.ibm.com with ESMTP id 32n01828fc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 03 Aug 2020 14:01:21 +0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 073Dxq8Y62980514 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 3 Aug 2020 13:59:52 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C995A42047; Mon, 3 Aug 2020 14:01:18 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9E70442049; Mon, 3 Aug 2020 14:01:18 +0000 (GMT) Received: from tuxmaker.linux.ibm.com (unknown [9.152.85.9]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Mon, 3 Aug 2020 14:01:18 +0000 (GMT) From: Sven Schnelle To: Thomas Gleixner Cc: Vincenzo Frascino , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] vdso: allow to add architecture-specific vdso data References: <20200803055645.79042-1-svens@linux.ibm.com> <20200803055645.79042-2-svens@linux.ibm.com> <87ime0lyg6.fsf@nanos.tec.linutronix.de> Date: Mon, 03 Aug 2020 16:01:18 +0200 In-Reply-To: <87ime0lyg6.fsf@nanos.tec.linutronix.de> (Thomas Gleixner's message of "Mon, 03 Aug 2020 14:13:13 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-08-03_13:2020-08-03,2020-08-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=901 mlxscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 adultscore=0 clxscore=1015 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008030102 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thomas Gleixner writes: > just a few nits. > > Can you please spare that #ifdef and do: > > #ifdef CONFIG_ARCH_HAS_VDSO_DATA > #include > #else > struct arch_vdso_data {}; > #endif Ok. > Please keep the tabular alignment of the struct members and add kernel > doc in the comment above the struct. Ok. > Aside of that 'arch' is not really a intuitive name. 'arch_data' or > something like that. Hmm? arch_data is fine, thank you for your comments. Regards Sven